I suspect it comes from this code:
$( 'div#centralNotice' ) .attr( 'class', mw.html.escape( 'cn-' + cn.internal.state.getData().category ) )
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ext.centralNotice.display: Fix class of CN div | mediawiki/extensions/CentralNotice | master | +1 -1 |
Event Timeline
Comment Actions
@Krinkle how big of a deal is this? We're in code freeze for non-essential fixes to CentralNotice through the December fundraising campaign.
Comment Actions
It means some part of CentralNotice frontend is broken. I don't know how severe.
- It could mean that critical data such as buckets or categories are not available for many users and that banners are not shown per the intended criteria.
- Or it could mean that the show criteria is fine, but that the display is only off. Which could result in e.g. fundraising designs being distorted or not rendering as intended if some of the layout classes they might use is not present unexpectedly.
Either way, I don't know. I merely saw the leak when debugging something unrelated. Where it's leaking from, how much, and what it is causing you'd have to ask someone who knows CentralNotice better.
Comment Actions
All banners come with a default category of {{{campaign}}}, and we're using the category for an increasing amount of real stuff, so this needs fixin'.
Comment Actions
Change 252768 had a related patch set uploaded (by AndyRussG):
ext.centralNotice.display: Fix class of CN div