Page MenuHomePhabricator
Create Task
Maniphest T121116

Infinite redirect loop when trying to re-translate article after deleting draft
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Start translating an article
  2. Go to dashboard
  3. Delete the draft
  4. Start again translating the same article

Observe: infinite redirect loop. Should allow starting translation from scratch.

Details

SubjectRepoBranchLines +/-
Do not pass draft id while resuming, remove references to draft idmediawiki/extensions/ContentTranslationmaster+67 -42
Avoid fetching the draft if it was deletedmediawiki/extensions/ContentTranslationmaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Dec 10 2015, 4:56 PM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: ContentTranslation.
Nikerabbit subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 10 2015, 4:56 PM
gerritbot subscribed.Dec 11 2015, 6:01 AM

Change 258420 had a related patch set uploaded (by Santhosh):
Avoid fetching the draft if it was deleted

https://gerrit.wikimedia.org/r/258420

gerritbot added a project: Patch-For-Review.Dec 11 2015, 6:01 AM
• santhosh claimed this task.Dec 11 2015, 6:01 AM
• santhosh triaged this task as Medium priority.
• santhosh edited projects, added LE-CX7-Sprint 4; removed Patch-For-Review.
• santhosh set Security to None.
• santhosh added a project: Patch-For-Review.
• santhosh moved this task from Backlog to In Review on the LE-CX7-Sprint 4 board.
• santhosh removed a subscriber: gerritbot.
KartikMistry merged a task: T121192: Deleting draft and restarting article again leads to infinite loop of 'Error while loading the saved version' on Dashboard.Dec 11 2015, 6:03 AM
KartikMistry added subscribers: Pginer-WMF, Ladsgroup, Arrbee and 2 others.
KartikMistry removed a subscriber: Ladsgroup.
Arrbee renamed this task from Infinite redirect look when trying to re-translate article after deleting draft to Infinite redirect loop when trying to re-translate article after deleting draft.Dec 11 2015, 7:02 AM
Arrbee added a project: Unplanned-Sprint-Work.
Arrbee mentioned this in T120635: Reloading a translation from translationview does not restore the saved content.
Nikerabbit moved this task from In Review to QA on the LE-CX7-Sprint 4 board.Dec 11 2015, 1:54 PM
gerritbot added a comment.Dec 13 2015, 11:30 AM

Change 258420 merged by Umherirrender:
Avoid fetching the draft if it was deleted

https://gerrit.wikimedia.org/r/258420

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 13 2015, 12:00 PM
Amire80 added a project: Essential-Work.Dec 13 2015, 9:25 PM
Arrbee added a comment.Dec 14 2015, 10:37 AM

Verified. This works as expected.

Amire80 moved this task from Needs Triage to CX7 on the ContentTranslation board.Dec 14 2015, 10:37 AM
Arrbee moved this task from QA to Done on the LE-CX7-Sprint 4 board.Dec 15 2015, 6:57 AM
Arrbee added a comment.Dec 18 2015, 3:44 PM

@santhosh I am moving this out of done and back into QA for confirmation from you. This problem still exists if the original article has been published.

Steps to reproduce:

  1. Start translating an article and then publish it
  2. Go to dashboard and check that it is under the 'published articles' tab
  3. Start translating the same article again
Arrbee moved this task from Done to QA on the LE-CX7-Sprint 4 board.Dec 18 2015, 3:45 PM
• santhosh edited projects, added LE-CX7-Sprint break; removed LE-CX7-Sprint 4.Dec 22 2015, 7:13 AM
• santhosh added a comment.Dec 23 2015, 5:40 AM

I tried the above steps and thre was no redirect also, draft from my previous translation was restored.

• santhosh moved this task from Backlog to In Review on the LE-CX7-Sprint break board.Dec 30 2015, 6:22 AM
gerritbot added a comment.Jan 15 2016, 3:45 AM

Change 258929 had a related patch set uploaded (by Santhosh):
Do not pass draft id while resuming, remove references to draft id

https://gerrit.wikimedia.org/r/258929

• santhosh edited projects, added LE-CX8-Sprint 1; removed LE-CX7-Sprint break.Jan 18 2016, 6:21 AM
• santhosh moved this task from Backlog to In Review on the LE-CX8-Sprint 1 board.
Arrbee raised the priority of this task from Medium to High.Jan 18 2016, 6:53 AM
Amire80 moved this task from CX7 to CX8 on the ContentTranslation board.Jan 20 2016, 11:14 PM
gerritbot added a comment.Jan 22 2016, 1:13 PM

Change 258929 merged by Nikerabbit:
Do not pass draft id while resuming, remove references to draft id

https://gerrit.wikimedia.org/r/258929

Nikerabbit moved this task from In Review to QA on the LE-CX8-Sprint 1 board.Jan 22 2016, 1:51 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 22 2016, 2:00 PM
Arrbee added a comment.Jan 29 2016, 5:02 AM

Verified, Not happening any more.

Arrbee moved this task from QA to Done on the LE-CX8-Sprint 1 board.Jan 29 2016, 5:02 AM
Amire80 closed this task as Resolved.Feb 4 2016, 7:46 PM
Amire80 mentioned this in T125866: ContentTranslation shows an unnecessary "Failed to load the saved translation" when starting a translation that was earlier deleted.
Amire80 subscribed.

Verified fixed in production, but there's a minor follow-up: T125866.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL