Page MenuHomePhabricator
Create Task
Maniphest T121126

On single edit tab wikis, 'undo' links in history when editor will be VE don't work
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We need to do special-handling for the undoafter=252141&undo=262492 stuff.

Details

SubjectRepoBranchLines +/-
Single edit tab: Fall back to the wikitext editor when certain parameters show upmediawiki/extensions/VisualEditormaster+15 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT121126 On single edit tab wikis, 'undo' links in history when editor will be VE don't work

Event Timeline

Jdforrester-WMF created this task.Dec 10 2015, 6:15 PM
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF raised the priority of this task from to High.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.
Jdforrester-WMF added subscribers: Aklapper, Krenair.
Krenair added a comment.Dec 10 2015, 7:57 PM

Unless/until we want to explicitly support this inside VE itself, this was the sort of thing I had in mind to go on the list of parameters that cause the wikitext editor to be loaded instead.

gerritbot subscribed.Dec 10 2015, 11:15 PM

Change 258370 had a related patch set uploaded (by Alex Monk):
Single edit tab: Fall back to the wikitext editor when certain parameters show up

https://gerrit.wikimedia.org/r/258370

gerritbot added a project: Patch-For-Review.Dec 10 2015, 11:15 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Dec 11 2015, 1:55 AM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF closed this task as Resolved.Dec 11 2015, 3:29 AM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 11 2015, 3:32 AM

Change 258370 merged by jenkins-bot:
Single edit tab: Fall back to the wikitext editor when certain parameters show up

https://gerrit.wikimedia.org/r/258370

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 11 2015, 4:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL