Page MenuHomePhabricator

Undo notification is not sent if the editor switches to the visual editor
Open, Needs TriagePublic

Description

Steps to reproduce:

  1. Undo an edit.
  2. Make any change in the wikitext editor.
  3. Switch to the visual editor. (Optionally, make more changes in visual mode.)
  4. Save the page.
  5. Discover aftewards that the editor whose work you reverted didn't get a notification.

If you skip step #2, then the edit won't be undone because of T185542: Undo doesn't work, if you switch to the visual mode, although the edit summary will claim that it was undone.

Reported at enwiki by User:NewYorkActuary

Related Objects

StatusAssignedTask
OpenNone
Resolved AlexMonk-WMF
OpenNone
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
ResolvedKrenair
DeclinedWhatamidoing-WMF
ResolvedKrenair
ResolvedKrenair
InvalidKrinkle
ResolvedKrenair
ResolvedKrenair
OpenNone
OpenNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Most likely the undo and undoafter query string parameters are getting lost here.

kostajh claimed this task.Jun 18 2018, 3:17 PM
kostajh removed kostajh as the assignee of this task.Aug 16 2018, 1:15 PM
kostajh added a subscriber: kostajh.

Unassigning myself in case someone else wants to pick this up; otherwise I'll come back to it when I have more time.

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 16 2018, 1:15 PM

Untagging Notifications; this is almost certainly due to VE failing to pass the undo/undoafter parameter(s) to the edit API.