Page MenuHomePhabricator
Create Task
Maniphest T185548

Undo notification is not sent if the editor switches to the visual editor
Open, Needs TriagePublic
Actions

Description

Steps to reproduce:

  1. Undo an edit.
  2. Make any change in the wikitext editor.
  3. Switch to the visual editor. (Optionally, make more changes in visual mode.)
  4. Save the page.
  5. Discover aftewards that the editor whose work you reverted didn't get a notification.

If you skip step #2, then the edit won't be undone because of T185542: Undo doesn't work, if you switch to the visual mode, although the edit summary will claim that it was undone.

Reported at enwiki by User:NewYorkActuary

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT120966 On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly
 ResolvedKrenairT120965 On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option
 ResolvedKrenairT120969 On single edit tab wikis, if the user has a 'wt always' preference, action=edit gives a blank page
 ResolvedKrenairT120970 On single edit tab wikis, if the user has a 've always' preference, there's a FOUC from 'edit' to 'edit source' on non-VE namespaces
 ResolvedKrenairT120978 On single edit tab wikis, if the user navigates straight to 'veaction=edit' without clicking and they don't have a editor preference cookie, nothing happens (they just get a read page)
 ResolvedKrenairT121122 On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option
 ResolvedKrenairT121126 On single edit tab wikis, 'undo' links in history when editor will be VE don't work
 ResolvedKrenairT120987 Switching to edit source giving blank page when I have option "Show me both editors"
 ResolvedKrenairT121189 On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting
 ResolvedKrenairT121257 On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it
 ResolvedKrenairT121298 On single edit tab wikis, if your browser is not supported but your settings (or default) says VE you get a blank edit page and no way to fix it
 ResolvedKrenairT121343 SingleEditTab: Exception thrown switching from VE to WE while logged out
 ResolvedKrenairT121342 With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading
 ResolvedKrenairT121460 On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set
 ResolvedKrenairT121599 On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"
 ResolvedKrenairT123457 On single edit tab wikis, if your browser runs JS but is only grade C supported (no MW JS) you probably get a blank edit page and no way to fix it
 ResolvedKrenairT124316 On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference causes VE to load up again
 ResolvedPRODUCTION ERRORKrenairT124264 Notice: Undefined index: 1 in /srv/mediawiki/php-1.27.0-wmf.11/extensions/VisualEditor/VisualEditor.hooks.php on line 83
 ResolvedKrenairT124650 On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit
 ResolvedKrenairT124743 On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE
 ResolvedKrenairT124652 Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"
 Declined• Whatamidoing-WMFT122389 Single edit tab: Preferences dialog is not showing in Firefox (? on Macs only)
 ResolvedKrenairT124708 Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch when using the Edit/Edit source tabs at the top of the page
 ResolvedKrenairT125670 VisualEditor SET doesn't set the <title> element
 InvalidKrinkleT125864 Fix the broken JS getCookie() call, which sets a cookie not recognised by the server
 ResolvedKrenairT125998 In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen
 ResolvedKrenairT126145 When CustomEditor is used, the EditPage robot policy isn't loaded
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor

Event Timeline

• Whatamidoing-WMF created this task.Jan 22 2018, 11:18 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 22 2018, 11:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope subscribed.Jan 22 2018, 11:21 PM

Most likely the undo and undoafter query string parameters are getting lost here.

• Whatamidoing-WMF updated the task description. (Show Details)Jan 22 2018, 11:50 PM
• Elitre awarded a token.Jan 22 2018, 11:56 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Mar 6 2018, 8:20 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
kostajh claimed this task.Jun 18 2018, 3:17 PM
kostajh mentioned this in T185542: Undo doesn't work, if you switch to the visual mode.Jun 20 2018, 2:47 PM
kostajh mentioned this in T78550: The undo link in the page history leads to the source editor and not VisualEditor.Jun 20 2018, 9:39 PM
kostajh added a parent task: T78550: The undo link in the page history leads to the source editor and not VisualEditor.Jun 22 2018, 2:34 PM
kostajh removed kostajh as the assignee of this task.Aug 16 2018, 1:15 PM
kostajh subscribed.

Unassigning myself in case someone else wants to pick this up; otherwise I'll come back to it when I have more time.

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 16 2018, 1:15 PM
Catrope removed projects: Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications.Aug 20 2018, 10:51 PM

Untagging Notifications; this is almost certainly due to VE failing to pass the undo/undoafter parameter(s) to the edit API.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits