Page MenuHomePhabricator
Create Task
Maniphest T120965

On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

If 'Temporarily disable the visual editor while it is in beta' is checked (or autodisable is), the 'Editing tab' option should be hidden.

Details

SubjectRepoBranchLines +/-
Hide VE tabs preference when user has disabled VEmediawiki/extensions/VisualEditormaster+7 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT120965 On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option

Event Timeline

Jdforrester-WMF created this task.Dec 9 2015, 4:59 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2015, 4:59 PM
Jdforrester-WMF added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.Dec 9 2015, 5:02 PM
Krenair subscribed.Dec 9 2015, 10:29 PM

So if they change the value of that, we need to dynamically hide/unhide the tab preference?

Jdforrester-WMF added a comment.Dec 9 2015, 10:30 PM
In T120965#1867308, @Krenair wrote:

So if they change the value of that, we need to dynamically hide/unhide the tab preference?

I think it's OK to not do it dynamically.

gerritbot subscribed.Dec 9 2015, 10:41 PM

Change 258052 had a related patch set uploaded (by Alex Monk):
Hide VE tabs preference when user has disabled VE

https://gerrit.wikimedia.org/r/258052

gerritbot added a project: Patch-For-Review.Dec 9 2015, 10:41 PM
Jdforrester-WMF closed this task as Resolved.Dec 9 2015, 10:55 PM
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Dec 9 2015, 10:59 PM

Change 258052 merged by jenkins-bot:
Hide VE tabs preference when user has disabled VE

https://gerrit.wikimedia.org/r/258052

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 9 2015, 11:00 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Dec 10 2015, 10:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL