The undo link in the page history leads to the source editor and not VisualEditor
Open, Needs TriagePublic8 Estimated Story Points
Actions

Assigned To

None

Authored By

	Amire80
	Dec 15 2014, 3:34 PM

Description

The undo link in the page history leads to the source editor and not VisualEditor. It should lead to the VisualEditor for people who prefer to use it.

It's probably not a high priority at this point, but if the VisualEditor is supposed to replace the source editor, this issue should be handled at some point.

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] Undo support	mediawiki/extensions/VisualEditor	master	+138 -38

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Resolved		• AlexMonk-WMF	T55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
Open		None	T114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
Resolved		Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
Resolved		Krenair	T120966 On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly
Resolved		Krenair	T120965 On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option
Resolved		Krenair	T120969 On single edit tab wikis, if the user has a 'wt always' preference, action=edit gives a blank page
Resolved		Krenair	T120970 On single edit tab wikis, if the user has a 've always' preference, there's a FOUC from 'edit' to 'edit source' on non-VE namespaces
Resolved		Krenair	T120978 On single edit tab wikis, if the user navigates straight to 'veaction=edit' without clicking and they don't have a editor preference cookie, nothing happens (they just get a read page)
Resolved		Krenair	T121122 On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option
Resolved		Krenair	T121126 On single edit tab wikis, 'undo' links in history when editor will be VE don't work
Resolved		Krenair	T120987 Switching to edit source giving blank page when I have option "Show me both editors"
Resolved		Krenair	T121189 On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting
Resolved		Krenair	T121257 On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it
Resolved		Krenair	T121298 On single edit tab wikis, if your browser is not supported but your settings (or default) says VE you get a blank edit page and no way to fix it
Resolved		Krenair	T121343 SingleEditTab: Exception thrown switching from VE to WE while logged out
Resolved		Krenair	T121342 With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading
Resolved		Krenair	T121460 On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set
Resolved		Krenair	T121599 On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"
Resolved		Krenair	T123457 On single edit tab wikis, if your browser runs JS but is only grade C supported (no MW JS) you probably get a blank edit page and no way to fix it
Resolved		Krenair	T124316 On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference causes VE to load up again
Resolved	PRODUCTION ERROR	Krenair	T124264 Notice: Undefined index: 1 in /srv/mediawiki/php-1.27.0-wmf.11/extensions/VisualEditor/VisualEditor.hooks.php on line 83
Resolved		Krenair	T124650 On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit
Resolved		Krenair	T124743 On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE
Resolved		Krenair	T124652 Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"
Declined		• Whatamidoing-WMF	T122389 Single edit tab: Preferences dialog is not showing in Firefox (? on Macs only)
Resolved		Krenair	T124708 Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch when using the Edit/Edit source tabs at the top of the page
Resolved		Krenair	T125670 VisualEditor SET doesn't set the <title> element
Invalid		Krinkle	T125864 Fix the broken JS getCookie() call, which sets a cookie not recognised by the server
Resolved		Krenair	T125998 In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen
Resolved		Krenair	T126145 When CustomEditor is used, the EditPage robot policy isn't loaded
Open		None	T78550 The undo link in the page history leads to the source editor and not VisualEditor
Open		None	T185548 Undo notification is not sent if the editor switches to the visual editor

Event Timeline

Amire80 created this task.Dec 15 2014, 3:34 PM

Amire80 raised the priority of this task from to Needs Triage.

Amire80 updated the task description. (Show Details)

Amire80 added a project: VisualEditor.

Amire80 changed Security from none to None.

Amire80 subscribed.

Jdforrester-WMF triaged this task as Low priority.Dec 15 2014, 6:26 PM

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Dec 15 2014, 7:26 PM

Suggest that specifically the undo link should lead to the editing interface selected in the user preferences or, in the absence of preference, to the default editor.

Amire80 mentioned this in T95342: clicking a red link should (optionally) lead to the VisualEditor.Apr 7 2015, 8:32 PM

Krenair mentioned this in T89060: VisualEditor is not the editor linked from the diff page.Jul 14 2015, 12:27 AM

Jdforrester-WMF added a subtask: T114531: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation.Oct 2 2015, 8:56 PM

When you press an undo button, not only do we set the revision text to the previous revision, but we also set up the standard revert summary as the default summary, and show the diff they're about to cause, and show a warning. I'm wondering what a similar experience in VE would look like.

the VisualEditor is supposed to replace the source editor

Thunders and lightnings!

Jdforrester-WMF removed a subtask: T114531: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation.Feb 16 2016, 4:58 PM

Jdforrester-WMF added a parent task: T114531: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation.

Jdforrester-WMF edited a custom field.

• Elitre subscribed.May 16 2016, 11:03 AM

For some reasons I thought this was already fixed? It's particularly annoying/confusing on SET wikis.

I just hit this problem in my pet project, which has SET with VE enabled by default to everyone. Indeed, this problem is more annoying in this context because then editors who preferred VE or who didn't even use the wikitext editor are left with two problems after clicking Undo:

They are now facing a wikitext UI.
Their preference has now changed to wikitext, which means that all future edits will be presented on wikitext unless they find out how to bring VE back.

Change 323357 had a related patch set uploaded (by Alex Monk):
[WIP] Undo support

https://gerrit.wikimedia.org/r/323357

gerritbot added a project: Patch-For-Review.Nov 24 2016, 3:46 AM

• AlexMonk-WMF mentioned this in T153294: Use NWE to revert edit(s).Dec 15 2016, 10:44 PM

This is higher priority with the new source mode.

Change 323357 abandoned by Alex Monk:
[WIP] Undo support

https://gerrit.wikimedia.org/r/323357

Change 323357 restored by Esanders:
[WIP] Undo support

https://gerrit.wikimedia.org/r/323357

Jdforrester-WMF merged a task: T153294: Use NWE to revert edit(s).Jan 17 2017, 8:21 PM

Jdforrester-WMF added subscribers: Dvorapa, • AlexMonk-WMF, Schnark.

Esanders mentioned this in T175446: 2017 wikitext editor doesn't load when I want to undo an edit.Sep 9 2017, 10:08 PM

Esanders mentioned this in T180261: Undo still doesn't use VisualEditor's 2017 wikitext mode.Nov 11 2017, 7:31 PM

Dvorapa merged a task: T180261: Undo still doesn't use VisualEditor's 2017 wikitext mode.Nov 12 2017, 2:44 PM

Dvorapa added a subscriber: • Whatamidoing-WMF.

Dvorapa merged a task: T189236: "undo" link loads old editor.Mar 8 2018, 8:09 PM

Dvorapa added a subscriber: Framawiki.

Dvorapa raised the priority of this task from Low to Needs Triage.Mar 8 2018, 8:13 PM

@Esanders: Yes, the priority should be higher. @Esanders, @AlexMonk-WMF (@Krenair): What is the status of this? How far is the patch to merge?

I came across this issue while working on T185548: Undo notification is not sent if the editor switches to the visual editor, which in turn led me to T185542: Undo doesn't work, if you switch to the visual mode.

I rebased the patch on master and overall it works (nice work!), but there are a few small issues:

Undo notifications are still broken per T185548 because undidRevId isn't set when updating via the API (it's currently only set in WikiPage.php's doEditContent(). This should be pretty easy to fix and I could push a commit to this patchset if you'd like.
The edit summary is no longer working. As noted in T185542: Undo doesn't work, if you switch to the visual mode (item 5 in the task description), the edit summary used to correctly autopopulate with VE but it doesn't with this patch.
When going to "View history" and then clicking on "Undo", I'd often be prompted by VE that "This page was edited since you last loaded it." VE then prompts to resume editing or start a new edit. If you click "Resume editing" the diff review won't show, but if you click "start a new edit", it will.
Something is not quite right with auto-save functionality (line 518 of ArticleTarget.js). If you don't comment out surfaceModel.restoreChanges();, then VE informs you "Changes recovered" and you don't see the diff window.