In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen
Closed, ResolvedPublic1 Story Points

Description

You are left with a blank page and the URL is changed to look like you are reading the page...
I guess we should attempt to fall back to the wikitext editor somehow in this case?
I'm getting increasingly worried about all the different ways the "suppress wikitext editor if we expect VE to load over the top of it immediately" CustomEditor hack could break. :/

Krenair created this task.Feb 5 2016, 4:29 PM
Krenair updated the task description. (Show Details)
Krenair raised the priority of this task from to Needs Triage.
Krenair added a subscriber: Krenair.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 5 2016, 4:29 PM
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set Security to None.

@Jdforrester-WMF: So what should be the proper behaviour in this case?

Fallback to an editor, any editor.

The problem is ensuring we don't try to fallback into VE itself and get into a loop.

Fallback to WT if VE fails to load seems better than falling back to read mode (and much better than an infinite look or a blank page, yes).

So, I think we can do this: When we detect failure to load on action=edit but there's no #wpTextbox1 on the page, change location to the current URL with &veswitched=1
This should avoid setting any cookies/preferences, and not interfere with WTE->VE switch failures.

Change 270440 had a related patch set uploaded (by Alex Monk):
Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit

https://gerrit.wikimedia.org/r/270440

Krenair claimed this task.Feb 12 2016, 11:46 PM

Change 270440 merged by jenkins-bot:
Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit

https://gerrit.wikimedia.org/r/270440