Page MenuHomePhabricator

VisualEditor SET doesn't set the <title> element
Closed, ResolvedPublic1 Estimated Story Points

Description

Reported at https://gerrit.wikimedia.org/r/259771

The <title> is empty. We should may sure OutputPage::setPageTitle() gets called with an appropiate message. This will improve performance by not having to do it in JavaScript instead. Either from the VE hook, or by changing core to set a default message in EditAction.php instead of EditPage.php. (using the editing or creating message accordingly).

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

I would quite like to move part of EditPage::setHeaders out to EditAction, but it's checking internals like edit conflict status, section id, parser output, etc. :/

Change 268609 had a related patch set uploaded (by Alex Monk):
Move EditPage robot policy out into EditAction

https://gerrit.wikimedia.org/r/268609

Change 268610 had a related patch set uploaded (by Alex Monk):
Set page title when we take over action=edit

https://gerrit.wikimedia.org/r/268610

Change 268610 merged by jenkins-bot:
Set page title when we take over action=edit

https://gerrit.wikimedia.org/r/268610

Jdforrester-WMF renamed this task from VisualEditor Single-edit-tab breaks certain Edit page semantics to VisualEditor SET doesn't set the <title> element.Feb 7 2016, 1:21 AM
Jdforrester-WMF updated the task description. (Show Details)