Page MenuHomePhabricator
Create Task
Maniphest T121342

With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Also happens from the edit source, although the title there "Editing X" is less jarring.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Take pageCanLoadVE into account when figuring out whether VE will load in-page or notmediawiki/extensions/VisualEditormaster+4 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
ResolvedKrenairT121342 With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading
· · ·

Event Timeline

Esanders created this task.Dec 13 2015, 2:41 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, VisualEditor-MediaWiki.
Esanders added subscribers: Esanders, Krenair.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 13 2015, 2:41 PM
Esanders added a comment.Dec 13 2015, 2:42 PM

Is there a reason we can't stick with the existing behaviour, which is to load the read page then trigger VE?

Esanders updated the task description. (Show Details)Dec 13 2015, 3:10 PM
Esanders set Security to None.
gerritbot subscribed.Dec 14 2015, 4:58 PM

Change 259013 had a related patch set uploaded (by Alex Monk):
Take pageCanLoadVE into account when figuring out whether VE will load in-page or not

https://gerrit.wikimedia.org/r/259013

gerritbot added a project: Patch-For-Review.Dec 14 2015, 4:59 PM
Krenair claimed this task.Dec 14 2015, 4:59 PM
gerritbot added a comment.Dec 14 2015, 5:14 PM

Change 259013 merged by jenkins-bot:
Take pageCanLoadVE into account when figuring out whether VE will load in-page or not

https://gerrit.wikimedia.org/r/259013

Krenair closed this task as Resolved.Dec 14 2015, 5:35 PM
Krenair added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.
Jdforrester-WMF triaged this task as Medium priority.Dec 14 2015, 5:52 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 14 2015, 6:00 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jan 13 2016, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits