Page MenuHomePhabricator
Create Task
Maniphest T121178

Invalidate "waitdate" status whenever the impression diet maximum impressions limit is increased
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

We're losing a lot of potential banner impressions by an unintended interaction between the "waitdate" rule and maximum number of impressions. The outcome is that a reader could have seen 3 impressions when that was the maximum, been put into the waitdate status for a number of days, but if we increase the maximum meanwhile, they still will not see additional impressions.

We should:

  • When "waitdate" is triggered, do not clear the total number of impressions seen by this reader.
  • Never trust waitdate alone, always compare the maximum impression limit with the total seen by this individual.

Details

SubjectRepoBranchLines +/-
Rename some impressionDiet variablesmediawiki/extensions/CentralNoticemaster+51 -30
Improve impression diet state machinemediawiki/extensions/CentralNoticewmf_deploy+47 -48
Improve impression diet state machinemediawiki/extensions/CentralNoticemaster+47 -48
Customize query in gerrit

Event Timeline

awight created this task.Dec 11 2015, 12:29 AM
awight raised the priority of this task from to Unbreak Now!.
awight updated the task description. (Show Details)
awight added projects: MediaWiki-extensions-CentralNotice, Fundraising-Backlog, Wikimedia-Fundraising.
awight added subscribers: awight, AndyRussG, Pcoombe, MeganHernandez_WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2015, 12:29 AM
gerritbot subscribed.Dec 11 2015, 3:29 AM

Change 258414 had a related patch set uploaded (by Awight):
WIP Increasing impression maximums will affect readers in the "waitdate" state

https://gerrit.wikimedia.org/r/258414

gerritbot added a project: Patch-For-Review.Dec 11 2015, 3:29 AM
awight claimed this task.Dec 11 2015, 11:29 AM
awight added projects: Fundraising Sprint Zapp, Unplanned-Sprint-Work.
awight moved this task from Backlog to Review on the Fundraising Sprint Zapp board.
awight set Security to None.
• DStrine moved this task from Triage to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Dec 11 2015, 4:54 PM
gerritbot added a comment.Dec 11 2015, 11:04 PM

Change 258414 merged by jenkins-bot:
Improve impression diet state machine

https://gerrit.wikimedia.org/r/258414

gerritbot added a comment.Dec 11 2015, 11:33 PM

Change 258641 had a related patch set uploaded (by AndyRussG):
Improve impression diet state machine

https://gerrit.wikimedia.org/r/258641

gerritbot added a comment.Dec 11 2015, 11:36 PM

Change 258641 merged by jenkins-bot:
Improve impression diet state machine

https://gerrit.wikimedia.org/r/258641

Ejegg moved this task from Review to Done on the Fundraising Sprint Zapp board.Dec 13 2015, 12:37 AM
Pcoombe closed this task as Resolved.Dec 17 2015, 9:45 PM

AFAIK this is resolved now.

• DStrine edited a custom field.Dec 29 2015, 8:07 PM
gerritbot added a comment.Oct 31 2016, 11:07 PM

Change 319003 had a related patch set uploaded (by Ejegg):
Rename some impressionDiet variables

https://gerrit.wikimedia.org/r/319003

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptOct 31 2016, 11:07 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:34 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:44 PM
gerritbot added a comment.Mar 23 2018, 3:48 PM

Change 319003 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Rename some impressionDiet variables

https://gerrit.wikimedia.org/r/319003

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL