Page MenuHomePhabricator

Convert Special:CentralAuth to use OOUI
Closed, ResolvedPublic

Description

The Special:CentralAuth page should be converted to use OOUI. This is because the mobile experience seen using this form is not good, as the fieldsets do not have any styling. Conversion to OOUI is one step towards converting the page to use Codex. However, we cannot currently convert the page to Codex due to the wiki list table and it's popup dialogs.

The username form

BeforeAfter
before.JPG (638×1 px, 66 KB)
after.JPG (638×1 px, 69 KB)

And the rest of the page

BeforeAfter
image.png (1×1 px, 70 KB)
Screenshot 2024-09-11 150417.png (1×1 px, 70 KB)

Event Timeline

Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: UI-Standardization.
Paladox subscribed.

Change 424373 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/CentralAuth@master] Partially Convert Special:CentralAuth to use OOUI

https://gerrit.wikimedia.org/r/424373

Change 424373 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Partially convert Special:CentralAuth to use OOUI

https://gerrit.wikimedia.org/r/424373

Change 479584 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/CentralAuth@master] Use DerivativeContext in Special:CentralAuth

https://gerrit.wikimedia.org/r/479584

@matmarex Change 479584 needs to deploy as soon as possible.

Since I had to figure out why: the issue is that viewing https://meta.wikimedia.org/wiki/Special:CentralAuth/foo, then typing in a different username and submitting the form, result in a URL like "https://meta.wikimedia.org/wiki/Special:CentralAuth/foo?target=bar" rather than "https://meta.wikimedia.org/wiki/Special:CentralAuth?target=bar" (the URL still includes the previous usename).

However, the page still works correctly. Only the URL looks silly. So while this is a bug, I don't think it is severe enough for me to be deploying it. Feel free to schedule a SWAT deployment yourself though; the next slot is on Monday (https://wikitech.wikimedia.org/wiki/Deployments).

Change 479584 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Use DerivativeContext in Special:CentralAuth

https://gerrit.wikimedia.org/r/479584

@Volker_E Will we need to convert the legend of these both?

Global account information.png (654×1 px, 183 KB)

I have done my work on Global account information. Check it out.

Screenshot_2018-12-17 Global account manager for AA - AlphaWiki.png (210×1 px, 15 KB)

@Jayprakash12345 I have too little information and insight (and time right now) to give you useful feedback. I do think though, that we should go away from normal fieldset treatment and transform such pieces to OOUI when possible. Do you have more specific questions?

What the page looks like on mobile currently:

image.png (925×1 px, 104 KB)

Mock-up of what the page will look like with OOUI:

global-account-manager-2.png (2×1 px, 199 KB)

To be clear, we will not be converting this page to use Codex because of this comment:

Myself and @Dreamy_Jazz reviewed the current mockup and discussed how to display wikis exempt from global blocks.
...

Change #1071204 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Remove unused ReadOnlyMode instance from SpecialCentralAuth

https://gerrit.wikimedia.org/r/1071204

Change #1071205 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Test Special:CentralAuth's admin set status form

https://gerrit.wikimedia.org/r/1071205

Change #1071206 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Test Special:CentralAuth's delete global account form

https://gerrit.wikimedia.org/r/1071206

Change #1071248 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] [WIP] Convert Special:CentralAuth to OOUI

https://gerrit.wikimedia.org/r/1071248

Change #1071204 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove unused ReadOnlyMode instance from SpecialCentralAuth

https://gerrit.wikimedia.org/r/1071204

Change #1071205 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Test Special:CentralAuth's admin set status form

https://gerrit.wikimedia.org/r/1071205

Change #1071206 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Test Special:CentralAuth's delete global account form

https://gerrit.wikimedia.org/r/1071206

Change #1071672 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] [WIP] Test Special:CentralAuth's wiki list unmerge form

https://gerrit.wikimedia.org/r/1071672

Change #1071831 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] [WIP] Convert Special:CentralAuth "Unmerge local accounts" to OOUI

https://gerrit.wikimedia.org/r/1071831

Change #1071672 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Test Special:CentralAuth's wiki list unmerge form

https://gerrit.wikimedia.org/r/1071672

After discussing with @KColeman-WMF, the design has been modified slightly to make the reason dropdown in the admin status form look more like the reason dropdown present in Special:Block.

Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)

Change #1071248 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Convert Special:CentralAuth to OOUI except "Unmerge local accounts"

https://gerrit.wikimedia.org/r/1071248

Change #1071831 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Convert Special:CentralAuth "Unmerge local accounts" to OOUI

https://gerrit.wikimedia.org/r/1071831