Page MenuHomePhabricator
Create Task
Maniphest T122343

MWTimestamp::getHumanTimestamp() throws exception for invalid language code
Closed, DeclinedPublicPRODUCTION ERROR
Actions

Description

Spamming exception logs:

{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/cldr/CldrNames.php","line":28,"function":"getFileName","class":"Language","type":"::","args":["string","string","string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/cldr/TimeUnits.body.php","line":66,"function":"getOverrideFileName","class":"CldrNames","type":"::","args":["string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/cldr/TimeUnits.body.php","line":26,"function":"loadLanguage","class":"TimeUnits","type":"::","args":["string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/cldr/TimeUnits.body.php","line":156,"function":"getUnits","class":"TimeUnits","type":"::","args":["string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/includes/Hooks.php","line":195,"function":"onGetHumanTimestamp","class":"TimeUnits","type":"::","args":["string","MWTimestamp","MWTimestamp","User","Language"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/languages/Language.php","line":2538,"function":"run","class":"Hooks","type":"::","args":["string","array"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/includes/MWTimestamp.php","line":219,"function":"getHumanTimestamp","class":"Language","type":"->","args":["MWTimestamp","MWTimestamp","User"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/formatters/NotificationFormatter.php","line":124,"function":"getHumanTimestamp","class":"MWTimestamp","type":"->","args":[]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/formatters/BasicFormatter.php","line":446,"function":"formatTimestamp","class":"EchoNotificationFormatter","type":"->","args":["string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/formatters/BasicFormatter.php","line":212,"function":"formatFooter","class":"EchoBasicFormatter","type":"->","args":["EchoEvent","User"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/controller/NotificationController.php","line":372,"function":"format","class":"EchoBasicFormatter","type":"->","args":["EchoEvent","User","string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/DataOutputFormatter.php","line":154,"function":"formatNotification","class":"EchoNotificationController","type":"::","args":["EchoEvent","User","string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/DataOutputFormatter.php","line":121,"function":"formatNotification","class":"EchoDataOutputFormatter","type":"::","args":["EchoEvent","User","string","Language"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/api/ApiEchoNotifications.php","line":166,"function":"formatOutput","class":"EchoDataOutputFormatter","type":"::","args":["EchoNotification","string","User","Language"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/extensions/Echo/includes/api/ApiEchoNotifications.php","line":43,"function":"getPropList","class":"ApiEchoNotifications","type":"->","args":["User","array","integer","NULL","string"]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/includes/api/ApiQuery.php","line":287,"function":"execute","class":"ApiEchoNotifications","type":"->","args":[]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/includes/api/ApiMain.php","line":1306,"function":"execute","class":"ApiQuery","type":"->","args":[]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/includes/api/ApiMain.php","line":460,"function":"executeAction","class":"ApiMain","type":"->","args":[]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/includes/api/ApiMain.php","line":432,"function":"executeActionWithErrorHandling","class":"ApiMain","type":"->","args":[]},
{"file":"/srv/mediawiki/php-1.27.0-wmf.9/api.php","line":83,"function":"execute","class":"ApiMain","type":"->","args":[]},
{"file":"/srv/mediawiki/w/api.php","line":3,"function":"include","args":["string"]}

Possibly related: T116890: wgUserLanguage in JS should be valid for API (Exception: Invalid language code "nl_nl").

Related Objects

Event Timeline

aaron created this task.Dec 23 2015, 8:54 PM
aaron raised the priority of this task from to Needs Triage.
aaron updated the task description. (Show Details)
aaron added a project: Notifications.
aaron subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 23 2015, 8:54 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Luke081515 triaged this task as High priority.Dec 23 2015, 9:07 PM
Luke081515 edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
Luke081515 set Security to None.
Luke081515 subscribed.

(High or UBN)

Aklapper added a project: Wikimedia-production-error.Dec 24 2015, 1:43 PM
Legoktm subscribed.Dec 25 2015, 7:45 AM

I thought we had fixed the nl_nl bug a few months ago...

• Mattflaschen-WMF renamed this task from Invalid language code "hu_hu" to Invalid language code "hu_hu" (NotificationFormatter->getHumanTimestamp).Dec 26 2015, 11:41 PM
• Mattflaschen-WMF updated the task description. (Show Details)
hashar subscribed.Jan 4 2016, 11:06 AM

We have a few ones with Invalid language code "zh_tw", same trace.

An example query is https://commons.wikimedia.org/w/api.php?notprop=list&meta=notifications&uselang=zh_tw&notlimit=15&notformat=html&notalertunreadfirst=&notmessagecontinue=&action=query&format=json

Catrope moved this task from Untriaged to Ready for pickup on the Collaboration-Team-Archive-2015-2016 board.Jan 19 2016, 3:07 AM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Mar 12 2016, 12:00 AM
• jmatazzoni edited projects, added Collab-Team-2016-Apr-Jun-Q4; removed Collaboration-Team-Archive-2015-2016.Apr 6 2016, 6:43 PM
• jmatazzoni moved this task from Untriaged to In Development on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 6 2016, 8:45 PM
• jmatazzoni moved this task from In Development to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.
hashar unsubscribed.Apr 8 2016, 12:05 PM
Catrope subscribed.May 2 2016, 9:46 PM

This is probably caused by T133822: Crosswatch shows "invalid language code zh_tw", and the actual bug is in MW core crashing when fed an invalid language code. Repurposing bug.

Catrope renamed this task from Invalid language code "hu_hu" (NotificationFormatter->getHumanTimestamp) to MWTimestamp::getHumanTimestamp() throws exception for invalid language code.May 2 2016, 9:48 PM
Catrope edited projects, added MediaWiki-Internationalization, MediaWiki-extensions-CLDR; removed Collab-Team-2016-Apr-Jun-Q4, Notifications.
Krinkle closed this task as Declined.Sep 12 2018, 8:34 PM
Krinkle subscribed.

Not seen in Logstash for at least 30 days.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL