Page MenuHomePhabricator

Making a null edit triggers a new message notification although null edit is not recorded in page history
Closed, ResolvedPublic

Description

Making a null edit (different from a dummy edit) to a certain user's talk page makes the user receive a notification that he has a new message although that the null edit itself is not recorded in the user talk page history.

Steps to reproduce:

  1. Logout of your account.
  2. While logged out make a null edit to your use talk page. (The null edit edit is not recorded in the user talk page history as expected.)
  3. Log in back to your account.

You receive a new message notification. When clicking on the notification link, you are redirected to the most recent diff on your talk page (which is not related to the null edit itself).
Request:

  • MediaWiki should be consistent about what it does with null edits. Since null edits are not recorded in history and they don't appear in watchlists, then they shouldn't trigger a new message notification.

Tested using Google Chrome 47 under Windows 8 on Arabic Wikipedia (arwiki)

Event Timeline

Meno25 raised the priority of this task from to Needs Triage.
Meno25 updated the task description. (Show Details)
Meno25 added a project: Notifications.
Meno25 subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

Change 270756 had a related patch set uploaded (by Matthias Mullie):
Don't store/trigger listeners for null edits

https://gerrit.wikimedia.org/r/270756

Change 270756 merged by jenkins-bot:
Don't store/trigger listeners for null edits

https://gerrit.wikimedia.org/r/270756

@matthiasmullie - there is a case where a notification still comes:

  • go to a wikitext User talk page - add new blank lines to the end of the page
  • login as the user whose User talk page was null edited in the step above - you'll see the Notification.

Note: I was not able to trigger notifications of null edits from Flow based pages.

Yeah, I only fixed up Flow null edits. I'll also take a look at regular wikitext!

Change 272940 had a related patch set uploaded (by Matthias Mullie):
Don't process null edits (or other warnings in article save process)

https://gerrit.wikimedia.org/r/272940

Change 272940 merged by jenkins-bot:
Don't process null edits (or other warnings in article save process)

https://gerrit.wikimedia.org/r/272940

Re-checked the scenario below - no notifications come when null edits are made.

go to a wikitext User talk page - add new blank lines to the end of the page
login as the user whose User talk page was null edited in the step above - you'll see the Notification.