Page MenuHomePhabricator

Do not show Quick Surveys to Do Not Track User
Closed, ResolvedPublic

Description

As a user with Do Not Track enabled, I do not want Quick Surveys displayed to me, so that I do not unnecessarily accidentally click a survey button.

Acceptance criteria

Note: the base EL already has a provision to not log events for DNT. Its example is instructive, however for this task (and later on in EL itself, but that's not mission critical yet) its example should be enhanced to account for MSIE-specific peculiarities, as documented in MDN.

Event Timeline

I wrote an npm package for cross-browser DNT support at the offsite in Amsterdam. Should be useful here.

leila moved this task from Staged to Radar on the Research board.
leila added a subscriber: ori.

thanks, @bmansurov, for taking care of this.
We should plan to increase the sampling rate by 2 folds in T125946 and run the test for 30-min after you deploy T127980. We can then roll back the sampling rate to the current rate. This way, we can quickly make a conclusion about the data loss issue.

Change 273036 had a related patch set uploaded (by Bmansurov):
Do not show a survey if DNT is enabled

https://gerrit.wikimedia.org/r/273036

@leila, could you also update T125946 with the info above? Thanks!

Change 273267 had a related patch set uploaded (by Thcipriani):
Do not show a survey if DNT is enabled

https://gerrit.wikimedia.org/r/273267

Change 273268 had a related patch set uploaded (by Thcipriani):
Do not show a survey if DNT is enabled

https://gerrit.wikimedia.org/r/273268

Change 273036 merged by jenkins-bot:
Do not show a survey if DNT is enabled

https://gerrit.wikimedia.org/r/273036

Change 273267 merged by jenkins-bot:
Do not show a survey if DNT is enabled

https://gerrit.wikimedia.org/r/273267

Change 273268 merged by jenkins-bot:
Do not show a survey if DNT is enabled

https://gerrit.wikimedia.org/r/273268

@leila, @ellery, and @dr0ptp4kt patch is live.
Enable/disable DNT in your browser to see/not see quick surveys: https://en.m.wikipedia.org/wiki/Book?quicksurvey=true

@leila can you verify this is working as expected?