Do not show Quick Surveys to Do Not Track User
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	dr0ptp4kt
	Feb 24 2016, 4:42 PM

Description

As a user with Do Not Track enabled, I do not want Quick Surveys displayed to me, so that I do not unnecessarily accidentally click a survey button.

Acceptance criteria

By client side determination, DNT users are not shown QS.
Patch is SWAT'd and @leila, @ellery, and @dr0ptp4kt are notified when it's live.
~~SWAT deploy https://phabricator.wikimedia.org/T125946#2062225~~ (It doesn't have to be a dependency I guess)

Note: the base EL already has a provision to not log events for DNT. Its example is instructive, however for this task (and later on in EL itself, but that's not mission critical yet) its example should be enhanced to account for MSIE-specific peculiarities, as documented in MDN.

Details

Subject	Repo	Branch	Lines +/-
Do not show a survey if DNT is enabled	mediawiki/extensions/QuickSurveys	wmf/1.27.0-wmf.13	+11 -3
Do not show a survey if DNT is enabled	mediawiki/extensions/QuickSurveys	wmf/1.27.0-wmf.14	+11 -3
Do not show a survey if DNT is enabled	mediawiki/extensions/QuickSurveys	master	+11 -3

Customize query in gerrit

Related Objects

Mentioned In: T254224: Remove Do Not Track support for QuickSurveys
rEQSa09390d2a802: Do not show a survey if DNT is enabled
rEQSad316df18441: Do not show a survey if DNT is enabled
rEQS349df892e7a3: Do not show a survey if DNT is enabled
rEQSe3ee5e688812: Do not show a survey if DNT is enabled
rEQS49fec6e3a9d8: Do not show a survey if DNT is enabled
T125946: Large scale QuickSurvey for reader segmentation research
T127101: QA Eventlogging to Google Forms set up
Mentioned Here: T125946: Large scale QuickSurvey for reader segmentation research

Event Timeline

dr0ptp4kt created this task.Feb 24 2016, 4:42 PM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 24 2016, 4:42 PM

dr0ptp4kt mentioned this in T127101: QA Eventlogging to Google Forms set up.Feb 24 2016, 4:52 PM

I wrote an npm package for cross-browser DNT support at the offsite in Amsterdam. Should be useful here.

Jdlrobson triaged this task as High priority.Feb 24 2016, 6:14 PM

Jdlrobson added a project: Reading-Web-Sprint-67-If, Then, Else...?.

Jdlrobson edited projects, added Reading-Web-Sprint-66-Harry is Tired; removed Reading-Web-Sprint-67-If, Then, Else...?.Feb 24 2016, 6:17 PM

• bmansurov claimed this task.Feb 24 2016, 7:12 PM

• bmansurov moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-66-Harry is Tired board.

leila added a project: Research.Feb 24 2016, 7:20 PM

leila moved this task from Backlog to Radar on the Research board.

leila added a subscriber: ori.

thanks, @bmansurov, for taking care of this.
We should plan to increase the sampling rate by 2 folds in T125946 and run the test for 30-min after you deploy T127980. We can then roll back the sampling rate to the current rate. This way, we can quickly make a conclusion about the data loss issue.