Page MenuHomePhabricator

Stop needing to use wgLegacyEncoding in Wikimedia cluster production
Open, Needs TriagePublic

Event Timeline

Restricted Application added subscribers: JEumerus, Matanya. · View Herald TranscriptFeb 26 2016, 1:30 AM

@Jdforrester-WMF Do you expect T128149: Remove wgLegacyEncoding feature of Revision/BlobStore to have more dependencies than just this one?

The tasks exist separately. This task is about migrating Wikimedia production to not use the variable. T128149 is about (eventually, possibly not yet) removing the functionality from MediaWiki core. It'd be cheap and harmless to keep around (unused by default for years already) for a few releases longer if other parties may be involved as well. There's no rush there.

@Jdforrester-WMF Do you expect T128149: Remove wgLegacyEncoding feature of Revision/BlobStore to have more dependencies than just this one?

The tasks exist separately.

Not that much separately when one is blocker of the other... ;-)

Anyway, I was just wondering, that this might be more or less useless middle-step, hence why I asked...

brion added a subscriber: brion.Feb 29 2016, 7:42 PM

Out of curiosity what are the pain points of it being left in that lead to wanting to remove it? Data already has to be loaded via compressed/encoded/multi-row/external storage/etc so nobody should be reading old raw text entries and being surprised at their encoding since years ago.

Just a desire for cleanliness, or a partial step to adding some sort of different functionality?

Out of curiosity what are the pain points of it being left in that lead to wanting to remove it? Data already has to be loaded via compressed/encoded/multi-row/external storage/etc so nobody should be reading old raw text entries and being surprised at their encoding since years ago.
Just a desire for cleanliness, or a partial step to adding some sort of different functionality?

The former.

brion added a comment.Mar 1 2016, 2:04 AM

The former.

Hehe fair enough. :) In that case I would recommend adding a maintenance script to do the conversion & using it in production to clean up the existing rows, at which point we can safely drop it from our config file.

Maybe deprecate the var to mark it for removal in a future version for T128149 if you feel strongly, but it's a pretty narrow bit of actual code that's fairly well-isolated. (There are exactly two places that use $wgLegacyEncoding, in revision text fetching and password comparisons.)

Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Mar 1 2016, 3:41 AM