Page MenuHomePhabricator

Search Suggestions API call doesn't need the list=prefixsearch parameter
Closed, ResolvedPublic1 Estimated Story Points

Description

I noticed that you use action=query with both generator=prefixsearch and list=prefixsearch.
IIRC when we looked at this (it was when we looked at the way some API consumers generates their requests) we noticed that it generates 2 prefixsearch queries on the backend. I think this adds unnecessary latency.
@dcausse -- discovery mailing list

This is correct. The additional parameters from the API call are unnecessary and can be safely removed with no adverse effects.

Event Timeline

debt triaged this task as Medium priority.Mar 11 2016, 4:20 PM
debt added a project: Discovery-ARCHIVED.
debt added subscribers: JGirault, MSyed.

Change 276783 had a related patch set uploaded (by Jdrewniak):
Removing the 'list' param from the type-ahead API call

https://gerrit.wikimedia.org/r/276783

Jdrewniak set the point value for this task to 1.Mar 15 2016, 12:31 PM

Change 276783 merged by jenkins-bot:
Removing the 'list' param from the type-ahead API call

https://gerrit.wikimedia.org/r/276783

debt subscribed.

Resolving this ticket - will go into production with this: https://phabricator.wikimedia.org/T130755