In https://gerrit.wikimedia.org/r/#/c/274984/, @DLynch implemented the functionality of using Ctrl+Enter to close a dialog with the primary action. Somebody should make sure that this works in all of VE's dialogs (it would be easy to accidentally break this feature with less carefully written event handlers in VE), and that it preserves all the changes made (or otherwise does the same thing as the colored button in top-right corner of the dialog). This is already live on http://en.wikipedia.beta.wmflabs.org/, I checked one or two things and they seemed to work at a glance. (This is basically a QA request, I guess.)
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | Ryasmeen | T129793 Please verify that using Ctrl+Enter in all dialogs and inspectors works to confirm the changes | |||
| Resolved | DLynch | T125860 Provide Ctrl+Enter as a keyboard shortcut to confirm OOui dialogs |
Event Timeline
Comment Actions
I tested most of the dialogs and everything seems to be cool.
The only exception is Insert Media - it doesn't work before clicking "Use this image" - but I'm not sure if it is bug or feature. We may want the user to "use this image" before finish on the one hand, but on the other hand "it is blue button" and it would be nice to behave similarly to Insert template in which when you select the template and press Ctrl+Enter you get to the next step of adding it
Comment Actions
@Ryasmeen: Hi! This task has been assigned to you a while ago. Do you still plan to work on this task?
If this task has been resolved in the meantime: Please update the task status (via Add Action... → Change Status in the dropdown menu).
If this task is not resolved and only if you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks!