Last section not transformed by MobileFormatter
Closed, ResolvedPublic
Actions

Description

The last image on a page doesn't seem to be transformed so that it is wrapped in a noscript tag.
As a result it is loading unconditionally on viewing of page.

Joaquin points out that filterContentInSection doesn't run on the last section.

Expected:

Add new minimum test case in PHPUnit for the MobileFormatter
Fix the broken phpunit test

Details

	Subject	Repo	Branch	Lines +/-
	Apply filterContentInSection to last section	mediawiki/extensions/MobileFrontend	master	+22 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Resolved		dr0ptp4kt	T114542 Next Generation Content Loading and Routing, in Practice
Duplicate		• Jhernandez	T104432 [EPIC]: Improve mobile site performance
Duplicate		dr0ptp4kt	T120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
Resolved		Jdlrobson	T113066 [GOAL] Make Wikipedia more accessible to 2G connections
Resolved		Jdlrobson	T124390 [GOAL] Load images with care
Resolved		Jdlrobson	T129509 Add unit tests in MobileFormatter for lazy loading images transforms
Resolved		Sumit	T130025 Last section not transformed by MobileFormatter

Event Timeline

• bmansurov created this task.Mar 15 2016, 4:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2016, 4:39 PM

Needs verification. @bmansurov let's talk after

Jdlrobson added a project: Reading-Web-Sprint-68-"Java and JavaScript are basically the same".Mar 15 2016, 5:22 PM

Jdlrobson updated the task description. (Show Details)

Page source: P2765

Jdlrobson triaged this task as High priority.Mar 15 2016, 5:22 PM

Jdlrobson renamed this task from Images inside collapsed sections should not be lazy-loaded until the section is expanded to Last section not transformed by MobileFormatter.Mar 15 2016, 5:53 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.

dr0ptp4kt added a parent task: T126590: Deploy lazy images to Mobile web beta.Mar 15 2016, 7:49 PM

Jdlrobson added a parent task: T129509: Add unit tests in MobileFormatter for lazy loading images transforms.Mar 15 2016, 8:54 PM

Jdlrobson mentioned this in T129509: Add unit tests in MobileFormatter for lazy loading images transforms.

Change 277603 had a related patch set uploaded (by Sumit):
Apply filterContentInSection to last section

https://gerrit.wikimedia.org/r/277603

gerritbot added a project: Patch-For-Review.Mar 15 2016, 9:05 PM

@bmansurov could you clarify which broken PHPunit tests are being referred to?

In T130025#2124413, @Sumit wrote:

@bmansurov could you clarify which broken PHPunit tests are being referred to?

The ones that you'll create. You need to create a test where you check whether the last image is being transformed or not. It will fail as it is, and then you'll need to fix it.

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 15 2016, 9:52 PM

Jdlrobson removed a parent task: T126590: Deploy lazy images to Mobile web beta.Mar 15 2016, 10:40 PM

Jdlrobson added a parent task: T124390: [GOAL] Load images with care.

Jdlrobson moved this task from Doing to -1 (Needs More Work) on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 15 2016, 11:02 PM

Sumit moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 16 2016, 2:40 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 16 2016, 5:35 PM

Change 277603 merged by jenkins-bot:
Apply filterContentInSection to last section

https://gerrit.wikimedia.org/r/277603

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 16 2016, 6:00 PM

phuedx closed this task as Resolved.Mar 16 2016, 6:44 PM

phuedx updated the task description. (Show Details)

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.