Page MenuHomePhabricator

Last section not transformed by MobileFormatter
Closed, ResolvedPublic

Description

The last image on a page doesn't seem to be transformed so that it is wrapped in a noscript tag.
As a result it is loading unconditionally on viewing of page.

Joaquin points out that filterContentInSection doesn't run on the last section.

Expected:

  • Add new minimum test case in PHPUnit for the MobileFormatter
  • Fix the broken phpunit test

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
DeclinedNone
OpenNone
Resolveddr0ptp4kt
DuplicateJhernandez
Duplicatedr0ptp4kt
OpenNone
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedSumit

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2016, 4:39 PM

Needs verification. @bmansurov let's talk after

Jdlrobson triaged this task as High priority.Mar 15 2016, 5:22 PM
Jdlrobson renamed this task from Images inside collapsed sections should not be lazy-loaded until the section is expanded to Last section not transformed by MobileFormatter.Mar 15 2016, 5:53 PM

Change 277603 had a related patch set uploaded (by Sumit):
Apply filterContentInSection to last section

https://gerrit.wikimedia.org/r/277603

Sumit claimed this task.Mar 15 2016, 9:06 PM
Sumit added a subscriber: Sumit.

@bmansurov could you clarify which broken PHPunit tests are being referred to?

@bmansurov could you clarify which broken PHPunit tests are being referred to?

The ones that you'll create. You need to create a test where you check whether the last image is being transformed or not. It will fail as it is, and then you'll need to fix it.

Change 277603 merged by jenkins-bot:
Apply filterContentInSection to last section

https://gerrit.wikimedia.org/r/277603

phuedx closed this task as Resolved.Mar 16 2016, 6:44 PM
phuedx updated the task description. (Show Details)