Page MenuHomePhabricator
Create Task
Maniphest T129509

Add unit tests in MobileFormatter for lazy loading images transforms
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Now.

Details

SubjectRepoBranchLines +/-
Updates to MobileFormatter and ApiMobileView PHPUnit testsmediawiki/extensions/MobileFrontendmaster+174 -40
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jhernandez created this task.Mar 10 2016, 5:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2016, 5:34 PM
• jhobs triaged this task as High priority.Mar 10 2016, 6:02 PM
• jhobs added a project: Reading-Web-Sprint-68-"Java and JavaScript are basically the same".
dr0ptp4kt added a parent task: T124390: [GOAL] Load images with care.Mar 10 2016, 11:38 PM
Jdlrobson set the point value for this task to 3.Mar 12 2016, 12:49 AM
dr0ptp4kt renamed this task from Add tests in MobileFormatter for lazy loading images transforms to Add unit tests in MobileFormatter for lazy loading images transforms.Mar 14 2016, 4:33 PM
Jdlrobson changed the point value for this task from 3 to 2.Mar 14 2016, 4:34 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.
Jdlrobson claimed this task.Mar 14 2016, 6:34 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 14 2016, 9:14 PM
gerritbot subscribed.Mar 14 2016, 9:18 PM

Change 277313 had a related patch set uploaded (by Jdlrobson):
Updates to MobileFormatter and ApiMobileView PHPUnit tests

https://gerrit.wikimedia.org/r/277313

gerritbot added a project: Patch-For-Review.Mar 14 2016, 9:18 PM
Jdlrobson added a subscriber: phuedx.Mar 15 2016, 12:10 AM

@phuedx and @Jhernandez over to you for code review. If you'd prefer this broken up into several commits no worries. Also feel free to dissect and fix this between yourselves.

gerritbot added a comment.Mar 15 2016, 10:00 AM

Change 277313 merged by jenkins-bot:
Updates to MobileFormatter and ApiMobileView PHPUnit tests

https://gerrit.wikimedia.org/r/277313

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.Mar 15 2016, 10:11 AM
phuedx removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 15 2016, 8:02 PM
Jdlrobson added a subtask: T130025: Last section not transformed by MobileFormatter.Mar 15 2016, 8:54 PM

T130025 will also give us coverage so let's get that fixed and a test added before sign off.
References tests have been requested in T125897

phuedx closed subtask T130025: Last section not transformed by MobileFormatter as Resolved.Mar 16 2016, 6:45 PM
Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Mar 16 2016, 9:42 PM
Jdlrobson closed this task as Resolved.Mar 16 2016, 11:55 PM
Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-68-"Java and JavaScript are basically the same" board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits