Page MenuHomePhabricator

Fix & restore the "Find a language" search box on www.wikipedia.org portal - API bug?
Open, Needs TriagePublic

Description

Fix the "Find a language" search box formerly on www.wikipedia.org so it can be included again on the page (or wherever else that functionality is useful).

The search box was disabled in T126409, citing an API bug. (Filing as a separate bug since the former feature was simplified to 'remove the buggy box'; it seemed like the UI element would have been useful if it could be fixed.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sj updated the task description. (Show Details)

It doesn't seem to work for existing wikis; only shows a blank page. Wp/<lang>&goto=mainpage also seems to be broken (I guess it's related).

It's failing for Wikipedias only, not other projects. $wmincProjectDatabases['p'] is set to wikiand this is used to retrieve the value of wgServer through wgConf. See WikimediaIncubator::getSubdomain() and WikimediaIncubator::getConf(). Recently wmf-config changed wiki to wikipediaso it's now failing since wiki key is not set in wgServer configuration and is falling back to some weird default. L1340. I guess we need to do some major refactoring to fix this in a non-hackish way?

Is this issue still open? May I work on it?

The box is still not on the page anymore, so I'd say yes.

@MF-Warburg Can you please assign it to me? I would like to try it.

@Ebe123

Sir, just wanted to confirm, this is the repository, right?

@Ebe123 Thank you, sir, I will get started.

@Ebe123 I have created a pull request. I have added the search box. Please let me know, if its working or not.

@Helix17: Thanks a lot! Please see and follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines and fix the commit message (tense, link to Phab ID). (PS: No need to ping folks for no good reason.)

Okay, sir, I will change the commit message. I will keep this in mind Sir.

Change 675449 had a related patch set uploaded (by Priyaraj17; author: Priyaraj17):
[wikimedia/portals@master] Find a language search-box

https://gerrit.wikimedia.org/r/675449

@Helix17: Thanks a lot! (PS: You may avoid assuming people's gender identity, maybe I am not a "sir".)

Ohh, I am so sorry, I just have a habit of calling the people who are senior to me as sir or ma'am. It won't happen again.

Change 676547 had a related patch set uploaded (by Priyaraj17; author: Priyaraj17):

[wikimedia/portals@master] Find a language search-box

https://gerrit.wikimedia.org/r/676547

Change 675449 abandoned by Priyaraj17:

[wikimedia/portals@master] Find a language search-box

Reason:

https://gerrit.wikimedia.org/r/675449

Hey, I had made a mistake earlier and I have corrected it, I went through the codebase and realized this. Here is the link to the pull request.

Change 794768 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/WikimediaIncubator@master] [WIP] Refactor and consolidate settings

https://gerrit.wikimedia.org/r/794768

Change 794768 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Refactor and consolidate config

https://gerrit.wikimedia.org/r/794768

The underlying error in the Wikimedia Incubator's Special:SearchWiki has been fixed now; confirmed on Incubator Beta, will be deployed to the live wiki next week. So if you, @Helix17, or anyone else wants to work on reinstating this on the wikipedia.org portal, that should be easier now.

@Helix17: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

@Pppery So close! :) Perhaps there's a related question for Wikispore if it becomes similarly popular and people start looking for other incubated efforts.