ve.ce.LinearArrowKeyDownHandler.js is largely untested
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Mar 18 2016, 6:05 PM

Details

	Subject	Repo	Branch	Lines +/-
	LinearArrowKeyDownHandler: more tests	VisualEditor/VisualEditor	master	+39 -0
	LinearArrowKeyDownHandler: test more	VisualEditor/VisualEditor	master	+119 -5

		Status	Subtype	Assigned	Task
		Resolved		• marcella	T206138 [EPIC] Increase test coverage for VE.ce code
		Resolved		DLynch	T130389 ve.ce.LinearArrowKeyDownHandler.js is largely untested

Change 279134 had a related patch set uploaded (by DLynch):
LinearArrowKeyDownHandler: test more

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF set the point value for this task to 8.

Change 279134 merged by jenkins-bot:
LinearArrowKeyDownHandler: test more

After If58ea415d we're up to 43% of branches (from 32%); remaining untested cases from quick gander:

Tests when the focus is a block slug
Up/Down arrow keys from a focussed node
Actions with a non-content focussed node
Arrow keys used from a focused node inside a table cell
Shift- (keyboard-)selection from a focused node
Shift-Up/Down selection from a non-block slug non-focused node non-null selection

Also some IE use cases like surface.nativeSelection.extend and other minor edge cases.

How much do we want to do? (OK, all of it, but…)

Change 280677 had a related patch set uploaded (by DLynch):
LinearArrowKeyDownHandler: more tests

I've also made T131361 for the currently-broken cases involving moving off a focused block node while holding shift.

Change 280677 merged by jenkins-bot:
LinearArrowKeyDownHandler: more tests

Closing this as some work completed in 2016. Refiled as T207077 in 2018.