Page MenuHomePhabricator

iDEAL cancel returns donor to Thank You page
Open, MediumPublic2 Estimated Story Points

Description

Steps to reproduce:

You will be returned to the foundationwiki Thank You page, which is incorrect.

Breadcrumb for future explorers: The exciting work here is to merge the Ingenico result switcher with our generalized GatewayPage::handleResultResponse controller.

Event Timeline

We're incorrectly passing a returnto param of Thank_You/{lang}, we should be using the Ingenico result switcher instead.

awight set the point value for this task to 2.Apr 12 2016, 9:59 PM

It got fun. The Ingenico result switcher needs to be merged with the generic handleResultResponse controller.

Change 283093 had a related patch set uploaded (by Awight):
[WIP] Donors using Ingenico should always return to the resultswitcher

https://gerrit.wikimedia.org/r/283093

Change 283105 had a related patch set uploaded (by Awight):
[WIP] Ingenico uses generic response handling controller

https://gerrit.wikimedia.org/r/283105

Change 283276 had a related patch set uploaded (by Awight):
ISSUERID is alphanumeric due to SEPA

https://gerrit.wikimedia.org/r/283276

Change 283553 had a related patch set uploaded (by Awight):
Testing links to exercise secret amounts

https://gerrit.wikimedia.org/r/283553

Change 283553 merged by jenkins-bot:
Testing links to exercise secret amounts

https://gerrit.wikimedia.org/r/283553

Change 283276 merged by jenkins-bot:
ISSUERID is alphanumeric due to SEPA

https://gerrit.wikimedia.org/r/283276

Change 284105 had a related patch set uploaded (by Ejegg):
Also update commented-out bank code

https://gerrit.wikimedia.org/r/284105

Change 284105 merged by jenkins-bot:
Also update commented-out bank code

https://gerrit.wikimedia.org/r/284105

DStrine lowered the priority of this task from High to Medium.Apr 11 2017, 4:28 PM
DStrine added a subscriber: DStrine.

We should recheck if this happens after the new integration.

We do have a few people saying (on the OTRS helpdesk) that they keep receiving banners after donating. They could also be using another device or have strict cookie settings, though.

Reports increasing by the day on OTRS and IRC.

@Sjoerddebruin do donors see the Thank You page after a successful/completed donation (i.e., not the cancel button?). Does it depend on which bank you pay with?

Sorry I can't test the full live iDEAL workflow!

@Sjoerddebruin do donors see the Thank You page after a successful/completed donation (i.e., not the cancel button?). Does it depend on which bank you pay with?

Sorry I can't test the full live iDEAL workflow!

I'm not able to claim every OTRS ticket that comes in, the user on IRC also left before I could ask the question. But now I see that I'm responding to the wrong Phabricator task, I remember one that was about the issue I'm talking about but I hate the Phabricator search engine. Sorry!

Change 283093 abandoned by Awight:
[WIP] Donors using Ingenico should always return to the resultswitcher

https://gerrit.wikimedia.org/r/283093

Change 283105 abandoned by Awight:
[WIP] Ingenico uses generic response handling controller

https://gerrit.wikimedia.org/r/283105