Maniphest T131904

iDEAL cancel returns donor to Thank You page
Open, MediumPublic2 Estimated Story Points
Actions

Description

Steps to reproduce:

Visit i.e. https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=rtbt-ideal-noadd&recurring=&payment_method=rtbt&payment_submethod=rtbt_ideal&utm_source=Waystogive.default~default~default~default~control.rtbt.rtbt_ideal&utm_medium=Waystogive&utm_campaign=C11_Waystogive&utm_key=&language=en&country=NL&returnto=Thank_You%2Fen&amountGiven=&currency_code=EUR&frequency=onetime&amount=3&uselang=en
Fill out form and choose ABN AMRO. Submit.
On the bank page, click Annuleren.

You will be returned to the foundationwiki Thank You page, which is incorrect.

Breadcrumb for future explorers: The exciting work here is to merge the Ingenico result switcher with our generalized GatewayPage::handleResultResponse controller.

Details

Subject	Repo	Branch	Lines +/-
[WIP] Ingenico uses generic response handling controller	mediawiki/extensions/DonationInterface	master	+101 -177
[WIP] Donors using Ingenico should always return to the resultswitcher	mediawiki/extensions/DonationInterface	master	+16 -26
Also update commented-out bank code	mediawiki/extensions/DonationInterface	master	+2 -2
ISSUERID is alphanumeric due to SEPA	mediawiki/extensions/DonationInterface	master	+34 -28
Testing links to exercise secret amounts	mediawiki/vagrant	master	+9 -2

Customize query in gerrit

Event Timeline

awight created this task.Apr 6 2016, 12:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2016, 12:04 AM

• DStrine triaged this task as High priority.Apr 7 2016, 8:25 PM

• DStrine added projects: Fundraising Sprint Ghostbusting , Unplanned-Sprint-Work.

• DStrine moved this task from Triage to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.

Sjoerddebruin subscribed.Apr 10 2016, 7:25 AM

awight claimed this task.Apr 12 2016, 7:44 PM

awight moved this task from Backlog to Doing on the Fundraising Sprint Ghostbusting board.

We're incorrectly passing a returnto param of Thank_You/{lang}, we should be using the Ingenico result switcher instead.

awight set the point value for this task to 2.Apr 12 2016, 9:59 PM

It got fun. The Ingenico result switcher needs to be merged with the generic handleResultResponse controller.

Change 283093 had a related patch set uploaded (by Awight):
[WIP] Donors using Ingenico should always return to the resultswitcher

https://gerrit.wikimedia.org/r/283093

Change 283105 had a related patch set uploaded (by Awight):
[WIP] Ingenico uses generic response handling controller

https://gerrit.wikimedia.org/r/283105

Change 283276 had a related patch set uploaded (by Awight):
ISSUERID is alphanumeric due to SEPA

https://gerrit.wikimedia.org/r/283276

• DStrine added a project: Fundraising Sprint Hermit Crab Husbandry.Apr 13 2016, 10:08 PM

• DStrine removed a project: Unplanned-Sprint-Work.Apr 14 2016, 3:58 PM

awight moved this task from Backlog to Doing on the Fundraising Sprint Hermit Crab Husbandry board.Apr 14 2016, 5:00 PM

Change 283553 had a related patch set uploaded (by Awight):
Testing links to exercise secret amounts

https://gerrit.wikimedia.org/r/283553

• DStrine removed a project: Fundraising Sprint Hermit Crab Husbandry.Apr 14 2016, 10:33 PM

• DStrine moved this task from Current Sprint & Completed in Q4 1516 to Old Unscheduled (prior to 2019) on the Fundraising-Backlog board.

awight updated the task description. (Show Details)Apr 14 2016, 10:35 PM

Change 283553 merged by jenkins-bot:
Testing links to exercise secret amounts

https://gerrit.wikimedia.org/r/283553

Change 283276 merged by jenkins-bot:
ISSUERID is alphanumeric due to SEPA

https://gerrit.wikimedia.org/r/283276

Change 284105 had a related patch set uploaded (by Ejegg):
Also update commented-out bank code

https://gerrit.wikimedia.org/r/284105

Change 284105 merged by jenkins-bot:
Also update commented-out bank code

https://gerrit.wikimedia.org/r/284105

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 20 2016, 1:02 AM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 20 2016, 1:02 AM

Trijnstel subscribed.May 16 2016, 11:09 PM

We should recheck if this happens after the new integration.

We do have a few people saying (on the OTRS helpdesk) that they keep receiving banners after donating. They could also be using another device or have strict cookie settings, though.

Reports increasing by the day on OTRS and IRC.

@Sjoerddebruin do donors see the Thank You page after a successful/completed donation (i.e., not the cancel button?). Does it depend on which bank you pay with?

Sorry I can't test the full live iDEAL workflow!

In T131904#3179905, @Ejegg wrote:

@Sjoerddebruin do donors see the Thank You page after a successful/completed donation (i.e., not the cancel button?). Does it depend on which bank you pay with?

Sorry I can't test the full live iDEAL workflow!

I'm not able to claim every OTRS ticket that comes in, the user on IRC also left before I could ask the question. But now I see that I'm responding to the wrong Phabricator task, I remember one that was about the issue I'm talking about but I hate the Phabricator search engine. Sorry!

• DStrine removed awight as the assignee of this task.Jun 22 2017, 9:05 PM

• mmodell removed a subscriber: awight.Jun 22 2017, 9:33 PM

Change 283093 abandoned by Awight:
[WIP] Donors using Ingenico should always return to the resultswitcher

https://gerrit.wikimedia.org/r/283093

Change 283105 abandoned by Awight:
[WIP] Ingenico uses generic response handling controller

https://gerrit.wikimedia.org/r/283105

Umherirrender removed a project: Patch-For-Review.Apr 2 2022, 8:45 PM

iDEAL cancel returns donor to Thank You pageOpen, MediumPublic2 Estimated Story PointsActions

Description

Details

Event Timeline

iDEAL cancel returns donor to Thank You page
Open, MediumPublic2 Estimated Story Points
Actions