Page MenuHomePhabricator

Notice: Undefined index in /srv/mediawiki/php-1.28.0-wmf.7/extensions/SpamBlacklist/SpamBlacklist_body.php
Closed, ResolvedPublic

Description

Rolled out wmf.7 to group0 yesterday, starting to see 3 index notices in the logs all in SpamBlacklist_body:

Notice: Undefined index: query in /srv/mediawiki/php-1.28.0-wmf.7/extensions/SpamBlacklist/SpamBlacklist_body.php on line 200
Notice: Undefined index: path in /srv/mediawiki/php-1.28.0-wmf.7/extensions/SpamBlacklist/SpamBlacklist_body.php on line 199
Notice: Undefined index: fragment in /srv/mediawiki/php-1.28.0-wmf.7/extensions/SpamBlacklist/SpamBlacklist_body.php on line 201

In wmf.13:

14 Notice: Undefined index: query in /srv/mediawiki/php-1.28.0-wmf.13/extensions/SpamBlacklist/SpamBlacklist_body.php on line 231
14 Notice: Undefined index: fragment in /srv/mediawiki/php-1.28.0-wmf.13/extensions/SpamBlacklist/SpamBlacklist_body.php on line 232

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 22 2016, 5:15 PM

Are these all from mw1017? If so, that was me live hacking testing earlier this morning.

Looks like these were from a bunch of different hosts: mw1186, mw1022, mw1143, etc.

You can see the list over the past 24 hours on logstash: https://logstash.wikimedia.org/#dashboard/temp/AVV5QmZJT4MudYQNhXhS

wfParseUrl can return false, which can result in this notice

The question is, why spam blacklist is handling a bad url

Dereckson updated the task description. (Show Details)Aug 5 2016, 1:57 AM

Seeing it again in wmf.16:

Notice: Undefined index: query in /srv/mediawiki/php-1.29.0-wmf.16/extensions/SpamBlacklist/SpamBlacklist_body.php on line 256

If anyone here would be so kind to review https://gerrit.wikimedia.org/r/#/c/346915/ I would appreciate it. The original code was written in a rush by Lego and got orphaned before it ever worked. This is the third time I ever write PHP code, so I'm kind of unsure if I'm doing anything horribly wrong. Otherwise we should merge this so the poor people who need this logging can finally get it (two years later).

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM