wikidata descriptions should show under title in search results on mobile web. As of today, possibly earlier (on safari iOS and chrome OSX) they are not.
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- T138085: Ensure Wikidata descriptions disabled by default on stable channel prod cluster mobile web Wikipedias
T135429: Deploy Wikidata descriptions to Catalan and Polish mobile web Wikipedias stable
T138788: Refactor Wikibase config variables used by MobileFrontend - Mentioned Here
- T138085: Ensure Wikidata descriptions disabled by default on stable channel prod cluster mobile web Wikipedias
T138788: Refactor Wikibase config variables used by MobileFrontend
Event Timeline
Comment Actions
Good catch @JKatzWMF! Initial investigation shows this was a result of the code checking the wrong variable: the one we use for the tagline descriptions ($wgMFUseWikibaseDescriptions), which we recently set to false by default as part of moving the descriptions to stable. As such, this is definitely a regression and should be fixed ASAP. I'll be bringing this up at standup with the intention to pull it into the current sprint.
Comment Actions
I predict this bug has existed for a long period of time and we've only just noticed it. If that's so I'll challenge the Unbreak now nature. :)
From the documentation
$wgMFUseWikibaseDescription
If set to true, will add Wikidata description to page JS as wgMFDescription variable
$wgMFDisplayWikibaseDescription
If set to true wikidata descriptions will be displayed in UI elements such as search,
nearby and watchlist.
Thus this should be unrelated to UseWikibaseDescriptions.
Note MFDisplayWikibaseDescription is currently true on the cluster so I suspect some MobileFrontend code change broke it.
Investigating...
Comment Actions
Okay we worked this out. Apparently there was a stray config change that I couldn't find that converted wgMFUseWikibaseDescription from true to false.
Talked to @jhobs and it seems wgMFUseWikibaseDescription is incorrectly being used to display the Wikidata description tagline when really it is just a flag to show that Wikibase is enabled and it is available (for gadgets etc - see README)
We originally intended to ship Wikidata descriptions in search results and page at same time so this is where confusion came from.
Agreed to do following:
- Revert wgMFUseWikibaseDescription back to true
- Introduce new config variable in MobileFrontend controlling the tagline which is false by default. Suggested name $wgMFDisplayWikibaseDescriptionAsTagline
Comment Actions
Change 296281 had a related patch set uploaded (by Jhobs):
Refactor wikibase config variables to be less confusing
Comment Actions
Created T138788 to handle the technical debt refactoring portion found during investigation of this regression.
Comment Actions
Change 296345 had a related patch set uploaded (by Jhobs):
Introduce variable for wikidata taglines
Comment Actions
Change 296346 had a related patch set uploaded (by Jhobs):
Introduce variable for wikidata taglines
Comment Actions
Change 296345 abandoned by Jhobs:
Introduce variable for wikidata taglines
Reason:
In favor of Id2e38fd5b60efeb3d4459d9a00ac125364e784b5
Comment Actions
Change 296345 restored by Dereckson:
Introduce variable for wikidata taglines
Reason:
To discard change ID
Comment Actions
Change 296345 abandoned by Dereckson:
Introduce variable for wikidata taglines
Reason:
Change ID are immutable: a new change with another change ID will be offered as a new change on Gerrit.
Comment Actions
Change 296351 had a related patch set uploaded (by Dereckson):
Introduce config variable to control tagline
Comment Actions
Change 296352 had a related patch set uploaded (by Jhobs):
Introduce config variable to control tagline
Comment Actions
Mentioned in SAL [2016-06-28T00:02:52Z] <dereckson@tin> Synchronized php-1.28.0-wmf.7/extensions/MobileFrontend/: Introduce config variable to control tagline (T138738) (duration: 00m 39s)
Comment Actions
Mentioned in SAL [2016-06-28T00:05:41Z] <dereckson@tin> Synchronized php-1.28.0-wmf.6/extensions/MobileFrontend/: Introduce config variable to control tagline (T138738) (duration: 00m 29s)
Comment Actions
Mentioned in SAL [2016-06-28T00:08:34Z] <dereckson@tin> Synchronized wmf-config/InitialiseSettings.php: Introduce config variable to control tagline (T138738, 1/2) (duration: 00m 32s)
Comment Actions
Mentioned in SAL [2016-06-28T00:09:20Z] <dereckson@tin> Synchronized wmf-config/mobile.php: Introduce config variable to control tagline (T138738, 2/2) (duration: 00m 27s)
Comment Actions
The patches (296281 and 296346) fixing this task and, incidentally, a problem with T138085, were able to be backported to 1.28.0-wmf.6 and rolled out to 1.28.0-wmf.7 during today's evening SWAT deployment. I've confirmed on several wikis that Wikidata descriptions are back to working in search (and other locations).
Sorry for the patch spam above; there were some merge issues during SWAT that we tried to workaround in a few different ways.