Page MenuHomePhabricator

[Regression] Comments in diff view no longer formatted italic
Closed, ResolvedPublic

Description

In any diff view (e.g. https://de.wikipedia.org/w/index.php?title=Wikipedia%3AHauptseite&type=revision&diff=152425751&oldid=151585132, for some reason I can't reproduce on en.wikipedia while logged in) the style for the comments is missing. The comments should be shown in italic.

This is caused by rMW9e458504c7b4: Move changeslist CSS classes from mediawiki.legacy.shared (or rather rMWb88cc6edd1be: Follow-up 6af8dcf: Remove duplicate styles in shared.css).

Details

Event Timeline

Schnark created this task.Jul 8 2016, 7:09 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 8 2016, 7:09 AM
Tobi_WMDE_SW renamed this task from [Regression] Comments iin diff view no longer formatted italic to [Regression] Comments in diff view no longer formatted italic.Jul 8 2016, 7:10 AM

The style is also missing when you edit a page and preview your edit summary.

I suppose span.comment should be moved back to shared.css. I guess it wouldn't make sense to include the mw.special.changeslist here. @matmarex?

Yeah, it seems that span.comment is used more widely than the other styles we moved. Sorry for not noticing this :/ Let's do that.

Change 298171 had a related patch set uploaded (by Prtksxna):
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298171

Change 298171 merged by jenkins-bot:
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298171

Change 298402 had a related patch set uploaded (by Jforrester):
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298402

Change 298402 merged by jenkins-bot:
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298402