Page MenuHomePhabricator
Create Task
Maniphest T139722

[Regression] Comments in diff view no longer formatted italic
Closed, ResolvedPublic
Actions

Description

In any diff view (e.g. https://de.wikipedia.org/w/index.php?title=Wikipedia%3AHauptseite&type=revision&diff=152425751&oldid=151585132, for some reason I can't reproduce on en.wikipedia while logged in) the style for the comments is missing. The comments should be shown in italic.

This is caused by rMW9e458504c7b4: Move changeslist CSS classes from mediawiki.legacy.shared (or rather rMWb88cc6edd1be: Follow-up 6af8dcf: Remove duplicate styles in shared.css).

Details

SubjectRepoBranchLines +/-
Move span.comment back to shared.css as its more widely usedmediawiki/corewmf/1.28.0-wmf.9+7 -7
Move span.comment back to shared.css as its more widely usedmediawiki/coremaster+7 -7
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Jul 8 2016, 7:09 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 8 2016, 7:09 AM
Tobi_WMDE_SW renamed this task from [Regression] Comments iin diff view no longer formatted italic to [Regression] Comments in diff view no longer formatted italic.Jul 8 2016, 7:10 AM
Aklapper added a subscriber: • Prtksxna.Jul 8 2016, 3:24 PM
Schnark added a comment.Jul 9 2016, 7:53 AM

The style is also missing when you edit a page and preview your edit summary.

• Prtksxna added a subscriber: matmarex.Jul 9 2016, 8:09 AM

I suppose span.comment should be moved back to shared.css. I guess it wouldn't make sense to include the mw.special.changeslist here. @matmarex?

Umherirrender merged a task: T139831: diff pages missing styles for span.comment.Jul 9 2016, 9:40 AM
Umherirrender merged a task: T139664: Edit comments are no longer italicized in diffs.
Umherirrender added subscribers: Stryn, • MZMcBride, Quiddity, Nirmos.
Umherirrender subscribed.
Urbanecm subscribed.Jul 9 2016, 10:54 AM
matmarex merged a task: T139840: Preview of edit summary on edit form missing style for span.comment.Jul 9 2016, 3:46 PM
matmarex added a comment.Jul 9 2016, 3:48 PM

Yeah, it seems that span.comment is used more widely than the other styles we moved. Sorry for not noticing this :/ Let's do that.

gerritbot subscribed.Jul 10 2016, 5:11 AM

Change 298171 had a related patch set uploaded (by Prtksxna):
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298171

gerritbot added a project: Patch-For-Review.Jul 10 2016, 5:11 AM
IKhitron subscribed.Jul 10 2016, 9:50 AM
gerritbot added a comment.Jul 11 2016, 4:25 PM

Change 298171 merged by jenkins-bot:
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298171

gerritbot added a comment.Jul 11 2016, 11:39 PM

Change 298402 had a related patch set uploaded (by Jforrester):
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298402

gerritbot added a comment.Jul 11 2016, 11:47 PM

Change 298402 merged by jenkins-bot:
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298402

matmarex closed this task as Resolved.Jul 12 2016, 12:40 AM
matmarex assigned this task to • Prtksxna.
matmarex triaged this task as High priority.
matmarex edited projects, added MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)), MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), MW-1.28-release-notes; removed Patch-For-Review.
Aklapper edited projects, added MediaWiki-Page-history; removed MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Sep 20 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL