|mediawiki/extensions/DisableAccount||wmf/1.32.0-wmf.22||+14 -2||Check for users with "" for password and email too|
|mediawiki/extensions/DisableAccount||master||+14 -2||Check for users with "" for password and email too|
Would be nice to just get this done and out of the way
Do we want to temporarily enable it on somewhere like testwiki, create an account, disable them, and then see what the migration looks like? Ie the blocking and the log entries. Then look to run it on the other wikis in one go?
@Reedy If that helps to know later what is exactly needed to do, then okay. The most important is that the wikis using this extension should also be set to $wgBlockDisablesLogin (which should be true for all private wikis) and that they indeed remain unable to access after they're migrated.
Thanks @Reedy - please bear in mind what we said at T106067#3041391. As far as I can see the script just looks for accounts in the 'inactive' user group which is not an accurate search parameter as per our comments above.
T106067#3041409 would be the most correct searching parameters as the 'inactive' user group has been manually added to accounts.
MariaDB [stewardwiki]> select count(*) from user where user_password = "" AND user_email = ""; +----------+ | count(*) | +----------+ | 5 | +----------+ 1 row in set (0.00 sec) MariaDB [stewardwiki]> select count(*) from user where user_password IS null AND user_email IS null; +----------+ | count(*) | +----------+ | 0 | +----------+ 1 row in set (0.00 sec)
Doesn't seem to be exactly the case... https://github.com/wikimedia/mediawiki-extensions-DisableAccount/blob/master/SpecialDisableAccount.php#L71 - The script adds it, and has for a long time