Title attributes not properly removed on hover
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	• jhobs
	Aug 11 2016, 3:55 PM

Description

Problems with mw.popups.removeTooltip (multiple problems):

title attribute of links are not removed on focus, causing qunit test failure (locally only, for some reason)
- Repro steps:
  1. Run qunit tests locally, observe failure of 3rd assertion in ext.popups.core: removeTooltips test. Alternatively, try manually tabbing focus onto a link with popups enabled.
Sometimes on mouseover the title attribute is not removed at all.
- Repro steps:
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/25thjuneChrome (fresh page reload)
  2. Inspect first link ("List of books about Wikipedia"), observe title attribute is present.
  3. Hover over link, observe title attribute is not removed. Repeat steps 1-3 if it is removed. Cannot find consistent manner in which to reproduce, but it happens frequently.
The title attribute is sometimes not restored on mouseout, breaking it for the rest of the page session.
- Repro steps:
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/25thjuneChrome (fresh page reload)
  2. Inspect first link ("List of books about Wikipedia"), observe title attribute is present.
  3. Hover over link, observe title attribute is properly removed. (Repeat step if 2nd problem above is encountered.)
  4. Mouse off of link, observe title attribute is properly restored. (Usually is on first try, anyways.)
  5. Repeat steps 3-4, observe title attribute is not restored. Cannot find consistent manner in which to reproduce, so repeat steps 3-4 until it happens.

Note that none of these problems appear to be race conditions. They all occur even if you wait for scripts to fully load and animations to complete.

Story
As a reader, I don't want to see both the title of the article and the hovercard, as it is distracting

Acceptance Criteria
Title tag doesn't appear when hovercards are on
Title tag appears when hovercards are off

Description

MediaWiki sets the title tag on all internal links, and many/most browsers show it as a small popup when one hovers over the link. This often interfers with hovercards (not always - I'm also seeing lots of hovercards without accompanying title popups).

Example screenshots

from https://hu.wikipedia.org/wiki/James_Bond , browsing anonymously on September 10:

from https://de.wikipedia.org/wiki/Wikipedia:Hauptseite , browsing while logged in with Hovercards beta feature enabled on August 17:

from https://de.wikipedia.org/wiki/Cannes , browsing while logged in with Hovercards beta feature enabled on August 17:

All on Chrome under Linux.

Details

	Subject	Repo	Branch	Lines +/-
	Fix tooltip interactions	mediawiki/extensions/Popups	master	+58 -43
	Hygiene: Simplify removeTooltip and restoreTooltip qunit test	mediawiki/extensions/Popups	master	+5 -14

Customize query in gerrit

Related Objects

Mentioned In: T92932: Hover card often gets stuck in "open" state
T147846: opened in new tab events logged incorrectly for hovercards off group in chrome
T145665: Verify interaction times are logged correctly with hovercards off and on (with the same actions)
Mentioned Here: T150401: Edit button not displayed on wikidata
rEPOP1d028476b66e: Fix tooltip interactions
rEPOP5aa4ccb1dfe2: Hygiene: Simplify removeTooltip and restoreTooltip qunit test
rEPOPd1f0b182b440: Fix tooltip interactions

Event Timeline

• jhobs created this task.Aug 11 2016, 3:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2016, 3:55 PM

• jhobs updated the task description. (Show Details)Aug 11 2016, 4:05 PM

• jhobs updated the task description. (Show Details)

• jhobs triaged this task as Medium priority.Aug 11 2016, 5:17 PM

• jhobs moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

• jhobs moved this task from Needs Prioritization to Incoming on the Web-Team-Backlog board.

• jhobs added a project: Technical-Debt.

• jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

• Jhernandez updated the task description. (Show Details)Sep 14 2016, 4:13 PM

• Jhernandez merged a task: T145370: Hovercards fail to suppress the browser's link title popups.

• Jhernandez added subscribers: • Tbayer, ovasileva, MBinder_WMF and 2 others.

• jhobs raised the priority of this task from Medium to High.Sep 14 2016, 4:13 PM

• Jhernandez renamed this task from mw.popups.removeTooltips is not functioning properly (multiple problems) to Title attributes not properly removed on hover.Sep 14 2016, 4:13 PM

• Jhernandez moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.

• Jhernandez updated the task description. (Show Details)

ovasileva added a project: Reading-Web-Sprint-82-Xpect-Rspec.Sep 15 2016, 4:39 PM

ovasileva moved this task from Needs Prioritization to 2016-17 Q2 on the Web-Team-Backlog board.

MBinder_WMF edited projects, added Page-Previews (2016-17-Q2-Goal); removed Page-Previews.Sep 19 2016, 4:53 PM

Seems to happen in firefox and other browsers too osx/linux, probably everywhere.

In T142723#2656394, @Jhernandez wrote:

Seems to happen in firefox and other browsers too osx/linux, probably everywhere.

I believe it's everywhere. I observed the problem on Chrome on Win7 and OSX.

Removing Technical-Debt as this has been elevated to a proper bug.

ovasileva updated the task description. (Show Details)Sep 23 2016, 3:55 PM

MBinder_WMF set the point value for this task to 3.Sep 26 2016, 4:29 PM

MBinder_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-82-Xpect-Rspec board.

MBinder_WMF removed a project: Reading-Web-Sprint-82-Xpect-Rspec.Sep 26 2016, 4:51 PM

MBinder_WMF moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog board.

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Sep 26 2016, 5:58 PM

ovasileva added a project: Reading-Web-Sprint-83-Y?.Sep 26 2016, 6:20 PM

ovasileva removed a project: Reading-Web-Sprint-83-Y?.Oct 11 2016, 4:49 PM

• jhobs mentioned this in T145665: Verify interaction times are logged correctly with hovercards off and on (with the same actions).Oct 13 2016, 1:56 PM

• jhobs mentioned this in T147846: opened in new tab events logged incorrectly for hovercards off group in chrome.Oct 13 2016, 2:00 PM

@MBinder_WMF I'm unsure of whether to add Unplanned-Sprint-Work to this task as during kickoff we did plan a couple tasks to pull in (and this was one of them).

• jhobs moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Oct 13 2016, 5:35 PM

• jhobs moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-83-Y? board.

(Acknowledging this and its associated points were not originally in the sprint)

Thanks, @jhobs and @Jdlrobson . I agree that this is unplanned (that it was ready to pull in doesn't mean it wasn't originally descoped).

Any updates on this task? It's been a week since work started on the task.

Change 316978 had a related patch set uploaded (by Jhobs):
Fix tooltip interactions

https://gerrit.wikimedia.org/r/316978

gerritbot added a project: Patch-For-Review.Oct 20 2016, 3:56 PM

Sorry about that Baha. The outage I described yesterday went longer than scheduled. I made some more changes to it this morning and have now pushed the patch to hopefully give a bit of time for review before standup. I'll also be uploading a hygiene patch soon.

• jhobs moved this task from Doing to Code Review on the Reading-Web-Sprint-83-Y? board.Oct 20 2016, 3:58 PM

Per @bmansurov's review of rEPOPd1f0b182b440: Fix tooltip interactions, it looks as if there's a little more work to be done.

phuedx moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-83-Y? board.Oct 21 2016, 10:58 AM

• jhobs moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-83-Y? board.Oct 21 2016, 7:01 PM

• NHarateh_WMF added a project: Reading-Web-Sprint-84-Zero-minutes-left.Oct 24 2016, 4:24 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 24 2016, 4:34 PM

• NHarateh_WMF removed a project: Unplanned-Sprint-Work.Oct 24 2016, 5:06 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 24 2016, 7:15 PM

The test still fails for me locally.

We should possibly fix this by doing this: https://gerrit.wikimedia.org/r/318277
I'm not sure what benefit we are adding by attempting to simulate mouse events and this test fails on current master but passes after your patch.

What do you say?

I think the issue you have identified is that binding events inside removeTooltips was a bad idea which I agree with.

Jdlrobson moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 27 2016, 11:59 AM

Change 318277 had a related patch set uploaded (by Jhobs):
Hygiene: Simplify removeTooltip and restoreTooltip qunit test

https://gerrit.wikimedia.org/r/318277

To keep this task up-to-date, @Jdlrobson and I talked on IRC and I agreed that the QUnit test was behaving as a browser test when it shouldn't have been. The hygiene change is a good fix.

Both rEPOP5aa4ccb1dfe2: Hygiene: Simplify removeTooltip and restoreTooltip qunit test and rEPOP1d028476b66e: Fix tooltip interactions should be good to go if someone wants to merge (or find something to -1 about).

Jdlrobson moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 28 2016, 2:27 PM

Jdlrobson mentioned this in T92932: Hover card often gets stuck in "open" state.Oct 31 2016, 4:17 PM

We discussed this in standup sync time. We agreed @jhobs would submit a new patch removing the binding of events in the unit test given the unit being tested has now been simplified. I've just hit +2 now.

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Reading-Web-Sprint-84-Zero-minutes-left board.Nov 3 2016, 5:40 PM

Change 318277 abandoned by Jhobs:
Hygiene: Simplify removeTooltip and restoreTooltip qunit test

Reason:
Made redundant by https://gerrit.wikimedia.org/r/#/c/316978/8

https://gerrit.wikimedia.org/r/318277

Change 316978 merged by jenkins-bot:
Fix tooltip interactions

https://gerrit.wikimedia.org/r/316978

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 3 2016, 6:00 PM

phuedx reassigned this task from • jhobs to • bmansurov.Nov 4 2016, 9:55 AM

Tested on https://en.wikipedia.beta.wmflabs.org/wiki/25thjuneChrome using:

Chrome 53.0.2785.143 (64-bit) and FireFox 49.0.2 on Mac OS 10.11.6 (15G1004)
IE 11 on Windows 7.

Please note that this broke Javascript on Wikidata, throwing the following error:

TypeError: mw.popups.removeTooltips is not a function. (In 'mw.popups.removeTooltips($elements)', 'mw.popups.removeTooltips' is undefined)

After a little debugging, we found that wikidata is serving an old version of the file inside articles. When accessing the module directly, the said function is not present at https://www.wikidata.org/w/load.php?modules=ext.popups.targets.desktopTarget&debug=true&lang=en&only=scripts&skin=vector.

Cause was found, continue on T150401.

Aklapper removed a subscriber: Page-Previews.May 17 2023, 7:34 AM

Maintenance_bot removed a project: Patch-For-Review.May 17 2023, 8:10 AM

	F4459228: Hovercard vs. title popup in hu_James_Bond 2016-09-10.png
	Sep 14 2016, 4:13 PM

	F4459234: Hovercard vs. title popup in de_Cannes 2016-08-17.png
	Sep 14 2016, 4:13 PM

	F4459231: Hovercard vs. title popup in de_Wikipedia_Hauptseite 2016-08-17.png
	Sep 14 2016, 4:13 PM

Title attributes not properly removed on hoverClosed, ResolvedPublic3 Estimated Story PointsActions