Edit button not displayed on wikidata
Closed, ResolvedPublic
Actions

Description

When I want to edit statments or identifiers on any wikidata item this does no longer work as there isno edit button available since today (11 november 2016) everything worked well yesterday. I verified with Firefox 49.0.2

When i verified with Google Chrome Version 54.0.2840.99 m everything worked perfectly well.

I've verified this issue on the following items

https://www.wikidata.org/wiki/Q193841
https://www.wikidata.org/wiki/Q27810764
https://www.wikidata.org/wiki/Q421462
The installed software on wikidata at the moment I noticed this was:

Installed software
Product Version
MediaWiki 1.29.0-wmf.2 (rMWdd68a1bc4d81)
21:45, 8 November 2016
HHVM 3.12.7 (srv)
MariaDB 10.0.23-MariaDB-log
ICU 52.1
Elasticsearch 2.3.5
LuaSandbox 2.0.12
Lua 5.1.5

Related Objects

Mentioned In: T149801: [EPIC] Refactor Hovercards (née Popups)
T142723: Title attributes not properly removed on hover
Mentioned Here: rMWdd68a1bc4d81: Creating new WMF 1.29.0-wmf.2 branch

Event Timeline

Robby created this task.Nov 10 2016, 5:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2016, 5:51 AM

ups I mistaked in the date I noticed it today 10 november 2016 and everything worked well yesterday evening 9 november 2016.

By now (some minutes later) everything is back to normal. So most probably it was just due to some issues on the wikidata servers.

I notice the same issue again.

Robby raised the priority of this task from Lowest to Medium.Nov 10 2016, 6:43 AM

I can confirm this. I don't see the edit buttons either.
I see one error in my Javascript console: mw.popups.removeTooltips is not a function

I see the gadget PopupsFix is broken. When I deactivate that gadget I get the edit buttons.

Lea_Lacroix_WMDE subscribed.Nov 10 2016, 8:55 AM

• iecetcwcpggwqpgciazwvzpfjpwomjxn subscribed.Nov 10 2016, 9:06 AM

• Glorian_Yapinus subscribed.Nov 10 2016, 9:19 AM

Mate subscribed.Nov 10 2016, 9:30 AM

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Nov 10 2016, 10:08 AM

Lydia_Pintscher raised the priority of this task from Medium to High.Nov 10 2016, 10:11 AM

Sjoerddebruin mentioned this in T142723: Title attributes not properly removed on hover.Nov 10 2016, 10:28 AM

Disabled the gadget for now, see here; https://www.wikidata.org/w/index.php?title=MediaWiki%3AGadget-PopupsFix.js&action=historysubmit&type=revision&diff=405100022&oldid=305114720

Thanks :)

The relevant code change happened in https://gerrit.wikimedia.org/r/316978. The function removeTooltips used by the gadget does not exist any more, instead there is a removeTooltip (without "s").

Wikidata admins, please try what happens if you do nothing but removing the "s". I believe this may already work just fine.

Pinging @jhobs and @Jdlrobson since they did the change.

• jhobs mentioned this in T149801: [EPIC] Refactor Hovercards (née Popups).Nov 10 2016, 3:09 PM

The tip @thiemowmde gave about removing the s did the trick. I removed it in https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-PopupsFix.js&diff=prev&oldid=405295392 and can still edit Wikidata.

thiemowmde closed this task as Resolved.Nov 10 2016, 5:32 PM

thiemowmde assigned this task to Mbch331.

thiemowmde added a project: Wikidata-Sprint-2016-11-08.

thiemowmde moved this task from consider for next sprint to in progress on the Wikidata board.

thiemowmde moved this task from Proposed to Done on the Wikidata-Sprint-2016-11-08 board.

many thanks to all those who helped solving this issue!

FYI, it's on our (the Reading Web Team's) radar to build Wikidata support directly into the extension. It may take a while as we're currently refactoring the extension, but just wanted to let you all know that this incident didn't go unnoticed. :)

In T150401#2787030, @jhobs wrote:

FYI, it's on our (the Reading Web Team's) radar to build Wikidata support directly into the extension. It may take a while as we're currently refactoring the extension, but just wanted to let you all know that this incident didn't go unnoticed. :)

Great to hear!

The same issue reappeared today!

I've tried to deactivate the gadget' PopupsFix' but his did not influence the issue.

Jdlrobson unsubscribed.Nov 28 2016, 10:37 PM

I now noticed that everything seems working correctly with Firefox 50.0 while i noticed the issue with Firefox 52.0 a2 (Aurora) I hope more testing will help clarifying the issue.

After making some more tests today everything is back to normal as well with firefox 52 : 52.0a2 (2016-11-28) (32-bit)

Edit button not displayed on wikidataClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Edit button not displayed on wikidata
Closed, ResolvedPublic
Actions