Couldn't find constant ProofreadPage::AS_HOOK_ERROR in ProofreadPage::onEditFilterMergedContent
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

This error was spotted more than 600 times in production this morning:

error: Couldn't find constant ProofreadPage::AS_HOOK_ERROR in /srv/mediawiki/php-1.28.0-wmf.15/extensions/ProofreadPage/ProofreadPage.body.php on line 625

https://github.com/wikimedia/mediawiki-extensions-ProofreadPage/blob/wmf/1.28.0-wmf.15/ProofreadPage.body.php#L623

Details

	Subject	Repo	Branch	Lines +/-
	Fix unknown constant AS_HOOK_ERROR issue in ProofreadPage	mediawiki/extensions/ProofreadPage	wmf/1.28.0-wmf.15	+1 -1
	Fix unknown constant AS_HOOK_ERROR issue in ProofreadPage	mediawiki/extensions/ProofreadPage	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T143894: Feedback for European SWAT window
Mentioned Here: rEPRPb7302130dec9: Hooks: Replace deprecated APIEditBeforeSave with EditFilterMergedContent

Event Timeline

Dereckson created this task.Aug 20 2016, 10:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2016, 10:10 AM

Dereckson renamed this task from Couldn't find constant ProofreadPage::AS_HOOK_ERROR in to Couldn't find constant ProofreadPage::AS_HOOK_ERROR in ProofreadPage::onEditFilterMergedContent.Aug 20 2016, 10:13 AM

Dereckson triaged this task as High priority.

Dereckson added a project: ProofreadPage.

Dereckson updated the task description. (Show Details)

Dereckson added a subscriber: Tpt.

ProofreadPage::AS_HOOK_ERROR has been introduced in commit b7302130de.

AS_HOOK_ERROR is a constant from EditPage class.

class EditPage {
…
    /**
     * Status: Article update aborted by a hook function
     */
    const AS_HOOK_ERROR = 210;
…

Change 305773 had a related patch set uploaded (by Dereckson):
Fix unknown constant AS_HOOK_ERROR issue in ProofreadPage

https://gerrit.wikimedia.org/r/305773

gerritbot added a project: Patch-For-Review.Aug 20 2016, 10:24 AM

Dereckson claimed this task.Aug 20 2016, 10:26 AM

Dereckson moved this task from Backlog to Top priority on the ProofreadPage board.

Dereckson moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.

Change 305773 merged by jenkins-bot:
Fix unknown constant AS_HOOK_ERROR issue in ProofreadPage

https://gerrit.wikimedia.org/r/305773

Change 305776 had a related patch set uploaded (by Dereckson):
Fix unknown constant AS_HOOK_ERROR issue in ProofreadPage

https://gerrit.wikimedia.org/r/305776

Dereckson moved this task from Top priority to Pagelist Widget on the ProofreadPage board.Aug 20 2016, 11:47 AM

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 20 2016, 12:00 PM

Change 305776 merged by jenkins-bot:
Fix unknown constant AS_HOOK_ERROR issue in ProofreadPage

https://gerrit.wikimedia.org/r/305776

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 22 2016, 1:00 PM

Mentioned in SAL [2016-08-22T13:43:19Z] <dereckson@tin> Synchronized php-1.28.0-wmf.15/extensions/ProofreadPage/ProofreadPage.body.php: Fix unknown constant AS_HOOK_ERROR issue in ProofreadPage (T143471) (duration: 00m 48s)

Jdforrester-WMF closed this task as Resolved.Aug 22 2016, 3:37 PM

hashar mentioned this in T143894: Feedback for European SWAT window.Aug 25 2016, 2:04 PM

Krinkle moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.Mar 19 2019, 3:46 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM

Couldn't find constant ProofreadPage::AS_HOOK_ERROR in ProofreadPage::onEditFilterMergedContentClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

Couldn't find constant ProofreadPage::AS_HOOK_ERROR in ProofreadPage::onEditFilterMergedContent
Closed, ResolvedPublicPRODUCTION ERROR
Actions