Page MenuHomePhabricator

wgIsProbablyEditable is true for blacklisted page - When a page is protected by the title blacklist, the mobile editing interface is still enabled
Open, MediumPublic

Description

The following problems were observed editing logged out. I have not tested them when logged in to an account.

When a page is protected in the normal way, such as my userpage https://en.m.wikipedia.org/wiki/User:BethNaught , the mobile interface issues a pop-up when the edit icon is pressed and the editor redirects back to the page, if the user does not have sufficient permissions to edit.

However, when a page is not 'protected' but instead the title blacklist prevents its editing or creation, the editing interface opens and the user is allowed to proceed up to pressing the save button, on which the uninformative and unfriendly message "Error, edit not saved" pops up (this part was fixed as T65335).

The following pages on English Wikipedia are blocked from non-autoconfirmed creation and editing respectively by the blacklist: https://en.m.wikipedia.org/wiki/Talk:Morgan_is_a_moron , https://en.m.wikipedia.org/wiki/User_talk:Bonadea/Editnotice . The above-mentioned issue can be seen here.

For consistency with normal protection and for user-friendliness, the mobile site should recognise title blacklist prohibitions and prevent access to the editor in cases where the user does not have sufficient permissions. Moreover the error message should be appropriately informative.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2016, 8:51 PM
BethNaught renamed this task from When a page is protected by the title blacklist, the mobile editing interface is enabled to When a page is protected by the title blacklist, the mobile editing interface is still enabled.Sep 10 2016, 8:56 PM
ovasileva triaged this task as Medium priority.Sep 14 2016, 4:46 PM
ovasileva raised the priority of this task from Medium to High.
ovasileva moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
jhobs added a subscriber: jhobs.

Adding VisualEditor as I think it was requested we add it even for non-visual-editor-editing tasks, IIRC.

ovasileva lowered the priority of this task from High to Low.Sep 15 2016, 4:20 PM

@Jdlrobson Do you have any thoughts around why we're not respecting this? Would it be hard to do?

Jdlrobson renamed this task from When a page is protected by the title blacklist, the mobile editing interface is still enabled to wgIsProbablyEditable is true for blacklisted page - When a page is protected by the title blacklist, the mobile editing interface is still enabled.Jun 5 2017, 5:41 PM
Jdlrobson raised the priority of this task from Low to Medium.
Jdlrobson added a project: VisualEditor.
Jdlrobson moved this task from Needs Prioritization to 2014-15 Q4 on the Readers-Web-Backlog board.

This is an editing bug. I'm not sure how the title blacklist can be accessed via JS (if at all). We rely on wgIsProbablyEditable which is true for blacklisted pages.

Deskana added a subscriber: Deskana.Jun 6 2017, 7:12 PM

Is this not the point of it being "probably" editable? It's not necessarily telling you for sure whether it is or not, for performance reasons.

Is this not the point of it being "probably" editable? It's not necessarily telling you for sure whether it is or not, for performance reasons.

That's fair :)
I'm not sure how viable it is to check the title at the start of the workflow but it does seem like something that can be checked up front.

Deskana moved this task from To Triage to Freezer on the VisualEditor board.Sep 20 2017, 12:40 PM
matmarex updated the task description. (Show Details)Sep 30 2019, 4:32 PM