Maniphest T219848

Unprivileged users see "edit" on cascade protected page
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Xaosflux
	Apr 2 2019, 4:00 AM

Description

Updated description

This bug is present on web version too. It's not peculiar to the mobile site.
Images from T240532#5739729
Viewing and atteming to edit cascades protected page as non-logged (unprivileged) user

While viewing	Clicking "edit"

Initial description

When attempting to edit a page which is protected using the cascading protection mechanism, the MobileFrontEnd workflow goes too far before stopping.

Example, this page is protected and looks protected using the Vector skin, but appears unprotected on mobile. (Load not-logged-in to demonstrate)

DESKTOP: https://test.wikipedia.org/wiki/Template:Something_to_cascade
MFE: https://test.m.wikipedia.org/wiki/Template:Something_to_cascade

It allows the user to start editing, collects their edit, confirms it, asks for a summary, then finally fails with an ungraceful: "Error, edit not saved." leading the editor with only the option to abandon their change. The editor never should have got that far, the page should let them know it is protected and stop immediately.

Related Objects

Mentioned In: T240532: Privileged users see "view source" on cascade protected page
T228897: Unhelpful error message: "Error, edit not saved." (mobile-frontend-editor-error)
Mentioned Here: T13700: Edit tab on cascade protected pages
T240532: Privileged users see "view source" on cascade protected page
T145304: wgIsProbablyEditable is true if an abuse filter would prevent the user from editing (e.g. TitleBlacklist)
T217217: Visual editor and 2017 wikitext editor mishandle cascading protection

Event Timeline

Xaosflux created this task.Apr 2 2019, 4:00 AM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptApr 2 2019, 4:00 AM

Reported on enwiki by Jmar67 in https://en.wikipedia.org/w/index.php?title=Talk:Main_Page&oldid=890569090#Editable_entries

I was able to reproduce this with a normal protected page, but then I it appeared to fix after a page purge - is consistently breaking with pages that are cascade protected though.

See also T217217, an identical bug for visual and 2017 wikitext editors

Pppery added projects: MediaWiki-Page-protection, Editing-team.Apr 2 2019, 7:02 PM

Pppery removed a project: Editing-team.

Jdrewniak triaged this task as Medium priority.Apr 3 2019, 9:11 PM

Jdrewniak updated the task description. (Show Details)

Jdrewniak added a project: Web-Team-Backlog.

I'm guessing this is a bug for VisualEditor project but let me know if that's not the case.

JTannerWMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Apr 9 2019, 3:26 PM

In T219848#5083247, @Jdlrobson wrote:

I'm guessing this is a bug for VisualEditor project but let me know if that's not the case.

While there is an identical bug in VisualEditor that @Pppery linked, this task is about a bug in the mobile wikitext editor in MobileFrontend.

(Similar issue caused by TitleBlacklist protection: T145304)

matmarex mentioned this in T228897: Unhelpful error message: "Error, edit not saved." (mobile-frontend-editor-error).Sep 16 2019, 11:52 PM

Ammarpad mentioned this in T240532: Privileged users see "view source" on cascade protected page.Dec 14 2019, 9:43 AM

In T219848, @Xaosflux wrote:

Example, this page is protected and looks protected using the Vector skin, but appears unprotected on mobile. (Load not-logged-in to demonstrate)
DESKTOP: https://test.wikipedia.org/wiki/Template:Something_to_cascade

It looks unprotected to me everywhere. This bug is not peculiar to mobile

Ammarpad renamed this task from MobileFrontEnd detects wrong protection level, causing the edit workflow to dead end to Unprivileged users see "edit" on cascade protected page.Dec 14 2019, 9:57 AM

Ammarpad updated the task description. (Show Details)

Ammarpad updated the task description. (Show Details)Dec 14 2019, 10:05 AM

Masumrezarock100 awarded a token.Dec 14 2019, 12:47 PM

Keyacom subscribed.Dec 14 2019, 7:05 PM

In T219848#5741336, @Ammarpad wrote:

In T219848, @Xaosflux wrote:

Example, this page is protected and looks protected using the Vector skin, but appears unprotected on mobile. (Load not-logged-in to demonstrate)
DESKTOP: https://test.wikipedia.org/wiki/Template:Something_to_cascade

It looks unprotected to me everywhere. This bug is not peculiar to mobile

That the navigation has the tab "edit" is an old bug and already marked as invalid for performance reason (T13700)

This bug is that the edit form of mobile view is open as if the page is editable and than the save gives the error.
When open the editform the mobile view must ask for the full permission check (expensive). The quick permission check is when viewing (cheap).

Jdlrobson moved this task from Backlog to Team:Editing on the MobileFrontend board.Jul 24 2020, 2:33 AM

Izno moved this task from Backlog to Cascade on the MediaWiki-Page-protection board.Jan 7 2021, 10:51 PM

Umherirrender unsubscribed.Feb 27 2021, 10:06 PM

Willy1018 subscribed.Apr 26 2021, 3:36 PM

toorich subscribed.Apr 27 2021, 11:39 AM

SD_hehua subscribed.May 3 2021, 7:35 AM

Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 15 2021, 5:16 PM

Jdlrobson removed a project: Web-Team-Backlog (Tracking).Oct 20 2021, 3:28 PM

	F31474898: Screen Shot 2019-12-13 at 17.44.09.png
	Dec 14 2019, 10:05 AM

	F31474900: Screen Shot 2019-12-13 at 17.44.17.png
	Dec 14 2019, 10:05 AM

Unprivileged users see "edit" on cascade protected pageOpen, MediumPublicActions