Page MenuHomePhabricator

Unprivileged users see "edit" on cascade protected page
Open, MediumPublic

Description

Updated description

This bug is present on web version too. It's not peculiar to the mobile site.
Images from T240532#5739729
Viewing and atteming to edit cascades protected page as non-logged (unprivileged) user

While viewingClicking "edit"
Screen Shot 2019-12-13 at 17.44.09.png (480×640 px, 109 KB)
Screen Shot 2019-12-13 at 17.44.17.png (480×640 px, 90 KB)
Initial description

When attempting to edit a page which is protected using the cascading protection mechanism, the MobileFrontEnd workflow goes too far before stopping.

Example, this page is protected and looks protected using the Vector skin, but appears unprotected on mobile. (Load not-logged-in to demonstrate)

DESKTOP: https://test.wikipedia.org/wiki/Template:Something_to_cascade
MFE: https://test.m.wikipedia.org/wiki/Template:Something_to_cascade

It allows the user to start editing, collects their edit, confirms it, asks for a summary, then finally fails with an ungraceful: "Error, edit not saved." leading the editor with only the option to abandon their change. The editor never should have got that far, the page should let them know it is protected and stop immediately.

Event Timeline

I was able to reproduce this with a normal protected page, but then I it appeared to fix after a page purge - is consistently breaking with pages that are cascade protected though.

See also T217217, an identical bug for visual and 2017 wikitext editors

Jdrewniak triaged this task as Medium priority.Apr 3 2019, 9:11 PM
Jdrewniak updated the task description. (Show Details)
Jdrewniak added a project: Readers-Web-Backlog.
Jdlrobson added a subscriber: Jdlrobson.

I'm guessing this is a bug for VisualEditor project but let me know if that's not the case.

I'm guessing this is a bug for VisualEditor project but let me know if that's not the case.

While there is an identical bug in VisualEditor that @Pppery linked, this task is about a bug in the mobile wikitext editor in MobileFrontend.

(Similar issue caused by TitleBlacklist protection: T145304)

In T219848, @Xaosflux wrote:

Example, this page is protected and looks protected using the Vector skin, but appears unprotected on mobile. (Load not-logged-in to demonstrate)
DESKTOP: https://test.wikipedia.org/wiki/Template:Something_to_cascade

It looks unprotected to me everywhere. This bug is not peculiar to mobile

Ammarpad renamed this task from MobileFrontEnd detects wrong protection level, causing the edit workflow to dead end to Unprivileged users see "edit" on cascade protected page.Dec 14 2019, 9:57 AM
Ammarpad updated the task description. (Show Details)
In T219848, @Xaosflux wrote:

Example, this page is protected and looks protected using the Vector skin, but appears unprotected on mobile. (Load not-logged-in to demonstrate)
DESKTOP: https://test.wikipedia.org/wiki/Template:Something_to_cascade

It looks unprotected to me everywhere. This bug is not peculiar to mobile

That the navigation has the tab "edit" is an old bug and already marked as invalid for performance reason (T13700)

This bug is that the edit form of mobile view is open as if the page is editable and than the save gives the error.
When open the editform the mobile view must ask for the full permission check (expensive). The quick permission check is when viewing (cheap).