Page MenuHomePhabricator
Create Task
Maniphest T145517

Minerva feature classes leak into Vector skin
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When you visit https://en.wikipedia.org/wiki/Main_Page and inspect the body element, you'll notice that it has feature-footer-v2 class

Note that previously, it also had the feature-page-action-bar-v2 class.
Our feature flagged classes should only apply to the Minerva skin.

AC

  • Do not leak any feature classes to vector (or any skin other than Minerva). Hook should only run on Minerva (and probably be in the skins hooks)

Details

SubjectRepoBranchLines +/-
Don't leak CSS feature classesmediawiki/extensions/MobileFrontendmaster+82 -30
Hygiene: Move OutputPageBodyAttributes handlermediawiki/extensions/MobileFrontendmaster+87 -86
Customize query in gerrit

Related Objects

Event Timeline

• bmansurov created this task.Sep 13 2016, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2016, 2:39 PM
• bmansurov added a project: Web-Team-Backlog.Sep 13 2016, 5:13 PM
Jdlrobson added subscribers: ovasileva, Jdlrobson.Sep 13 2016, 5:15 PM

This should block pushing the footer to stable. @ovasileva do we have such a ticket?

ovasileva added a parent task: T145442: Move footer changes to stable.EditedSep 13 2016, 7:49 PM

Added as blocker to T145442: Move footer changes to stable

• bmansurov added a comment.Sep 13 2016, 9:01 PM

@ovasileva I think this is about the page actions (edit, watchstar, and language buttons) you see when you visit https://en.m.wikipedia.org/wiki/Book rather than the footer.

ovasileva removed a parent task: T145442: Move footer changes to stable.Sep 14 2016, 4:37 PM
ovasileva triaged this task as High priority.Sep 14 2016, 4:42 PM
ovasileva added a project: good first task.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 14 2016, 4:43 PM
• bmansurov updated the task description. (Show Details)Sep 14 2016, 4:43 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Sep 14 2016, 4:43 PM
Jdlrobson updated the task description. (Show Details)Sep 14 2016, 4:57 PM
ovasileva moved this task from Triaged but Future to Product Owner Backlog on the Web-Team-Backlog board.Sep 15 2016, 2:58 PM
Krinkle awarded a token.Sep 21 2016, 6:09 PM
Krinkle subscribed.
ovasileva moved this task from Product Owner Backlog to Triaged but Future on the Web-Team-Backlog board.Oct 3 2016, 12:54 PM
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Oct 11 2016, 9:09 PM

I suggest we remove this code now that the footer is live and the default. This would solve this problem.

Jdlrobson added a comment.Oct 11 2016, 9:09 PM
This comment was removed by Jdlrobson.
ovasileva added a comment.Oct 12 2016, 9:18 AM

@Jdlrobson - I think we were confused initially. This is about page actions, not the footer.

Jdlrobson renamed this task from "feature-page-action-bar-v2" is leaking to vector to Minerva feature classes leak into Vector skin.Oct 12 2016, 3:06 PM
Jdlrobson updated the task description. (Show Details)
• bmansurov updated the task description. (Show Details)Oct 14 2016, 5:00 PM
ovasileva added a project: Reading-Web-Sprint-84-Zero-minutes-left.Oct 19 2016, 4:27 PM
ovasileva set the point value for this task to 2.
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 24 2016, 5:07 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Oct 24 2016, 6:34 PM
gerritbot subscribed.Oct 25 2016, 11:11 AM

Change 317803 had a related patch set uploaded (by Phuedx):
Don't leak CSS feature classes

https://gerrit.wikimedia.org/r/317803

gerritbot added a project: Patch-For-Review.Oct 25 2016, 11:11 AM

Change 317804 had a related patch set uploaded (by Phuedx):
Hygiene: Move OutputPageBodyAttributes handler

https://gerrit.wikimedia.org/r/317804

phuedx claimed this task.Oct 25 2016, 11:12 AM
phuedx moved this task from To Do to Code Review on the Reading-Web-Sprint-84-Zero-minutes-left board.
phuedx moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 25 2016, 1:43 PM
phuedx added a subscriber: pmiazga.Oct 25 2016, 1:49 PM

Per @pmiazga's review of rEMFR1f7fc411c60c: Don't leak CSS feature classes.

gerritbot added a comment.Oct 26 2016, 8:39 AM

Change 317804 abandoned by Phuedx:
Hygiene: Move OutputPageBodyAttributes handler

Reason:
See Ia05625c8 for detail.

https://gerrit.wikimedia.org/r/317804

phuedx moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 26 2016, 10:00 AM
Krinkle unsubscribed.Oct 26 2016, 3:09 PM
Krinkle subscribed.
Jdlrobson moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 26 2016, 3:48 PM

Some responses are needed to questions from @pmiazga and myself.

phuedx added a comment.Oct 26 2016, 5:19 PM

@Jdlrobson: I've responded and submitted a new patch set.

phuedx moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 26 2016, 5:20 PM
phuedx moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 27 2016, 7:56 AM

^ @bmansurov left a comment related to T147944: [EPIC] Remove SkinMinervaBeta class and I think it's relevant.

phuedx moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 27 2016, 9:59 AM
Jdlrobson moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 27 2016, 3:10 PM
Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 28 2016, 11:35 AM
gerritbot added a comment.Oct 28 2016, 11:50 AM

Change 317803 merged by jenkins-bot:
Don't leak CSS feature classes

https://gerrit.wikimedia.org/r/317803

phuedx reassigned this task from phuedx to • bmansurov.Nov 1 2016, 10:43 AM
phuedx subscribed.
• bmansurov closed this task as Resolved.Nov 1 2016, 6:50 PM
• bmansurov removed • bmansurov as the assignee of this task.

Signed off. Visited https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page and noticed that the body element doesn't have the feature-footer-v2 class. The same class is present when I visited https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits