Page MenuHomePhabricator
Create Task
Maniphest T151054

Allow generic hovercards to appear in special cases
Closed, ResolvedPublic
Actions

Description

Story

As a as user, I want the ability to know when a preview is not available for the page I am viewing

Description

Build generic hovercard

Acceptance Criteria

Generic hovercards - these will be used when we cannot display hovercards for certain pages. They will contain the following:

  • Icon: Sad face icon
  • Text: Looks like there isn’t a page preview for this topic
  • Link: Read article
  • Selecting “Read acticle” will navigate users to the article
  • Generic hovercards will not contain a settings cog
  • All other functionality will be as in other previews
  • Note: the mockup displays a “write page preview” link. This link will NOT be available
  • Generic hovercards will appear in the following cases:
  • Articles with no lead paragraph
  • Other edge cases

no-page-preview.png (658×1 px, 307 KB)

Details

SubjectRepoBranchLines +/-
previews: Add generic fallback previewmediawiki/extensions/Popupsmpga+199 -47
previews: Tidy up stylesmediawiki/extensions/Popupsmpga+9 -57
Customize query in gerrit

Related Objects

Event Timeline

ovasileva created this task.Nov 18 2016, 1:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2016, 1:11 PM
ovasileva triaged this task as High priority.Nov 18 2016, 1:11 PM
ovasileva added a project: Web-Team-Backlog.
Aklapper added a project: Page-Previews.Nov 18 2016, 1:13 PM

I assume this is about Page-Previews code hence adding project

ovasileva added a subscriber: • Nirzar.Nov 18 2016, 1:13 PM

@Nirzar - I was speaking to Sam about potentially having a link that allows users to report bugs - could navigate to a task in phabricator. Could be a good idea (potentially for a future iteration/improvement). Or we could do it for now and only display for logged-in users. It would ultimately be another task. Thoughts?

Aklapper added a comment.Nov 18 2016, 1:15 PM
In T151054#2805926, @ovasileva wrote:

potentially having a link that allows users to report bugs - could navigate to a task in phabricator.

I think MultimediaViewer has that when displaying an image fails. Might make sense to check that code.

ovasileva updated the task description. (Show Details)Nov 18 2016, 1:17 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Nov 18 2016, 1:27 PM
• Nirzar added a comment.Nov 18 2016, 10:10 PM

@ovasileva but is it a bug? i thought it was just lack of content

ovasileva added a comment.Nov 21 2016, 1:49 PM

@Nirzar - sort of yes and no. The use case would be something like:

  1. You go to an article that has no paragraph
  2. You get the generic modal that says "we don't have a preview for this"
  3. You file a bug saying "this article has no preview" for whatever reason
  4. We look at it

The real problem is that in order for us to set the generic popup in the first place, we know that the edge cases exists, we just don't have a solution for it yet. So I guess it makes more sense to just drop this idea or think of an alternate workflow that could actually help us.

Jdlrobson subscribed.Nov 23 2016, 4:18 PM

Is this task stalled till post rewrite?

ovasileva added subscribers: phuedx, • jhobs.Nov 23 2016, 4:34 PM

It will be a part of rewrite if we can get to it during this sprint. The remainder of hovercards, as of requirements, are at the top of triaged but future for @phuedx and/or @jhobs to pull from during the sprint once the big card is resolved (or as a part of it)

phuedx added a comment.Nov 28 2016, 1:03 PM

@Nirzar: Could you upload the mock to Zeplin (or upload the icon to Phabricator).

• Nirzar added a comment.Nov 28 2016, 9:27 PM

@phuedx here you go https://zpl.io/1NEfNl

gerritbot subscribed.Nov 29 2016, 1:00 PM

Change 324163 had a related patch set uploaded (by Phuedx):
previews: Tidy styles

https://gerrit.wikimedia.org/r/324163

gerritbot added a project: Patch-For-Review.Nov 29 2016, 1:00 PM

Change 324164 had a related patch set uploaded (by Phuedx):
WIP: previews: Add generic fallback preview

https://gerrit.wikimedia.org/r/324164

phuedx added a comment.Nov 29 2016, 1:08 PM

@Nirzar: A couple of trivial nitpicks about the wording: are "topic" and "article" appropriate in all circumstances?

ovasileva moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog board.Nov 29 2016, 1:53 PM
ovasileva added a comment.Nov 29 2016, 2:16 PM

I think topic is okay, but maybe we can change "article" to "page"? although read page sounds strange as well...

ovasileva added a project: Reading-Web-Sprint-86-🔪🦃.Nov 29 2016, 2:16 PM
ovasileva edited projects, added Page-Previews (2016-17-Q2-Goal); removed Page-Previews.Nov 29 2016, 6:03 PM
• Tbayer subscribed.Nov 30 2016, 12:56 AM
gerritbot added a comment.Nov 30 2016, 10:31 AM

Change 324163 merged by jenkins-bot:
previews: Tidy up styles

https://gerrit.wikimedia.org/r/324163

phuedx added a comment.Nov 30 2016, 10:47 AM

@ovasileva, @Nirzar: If you preview the Empty or Redirects to a page that doesn't exist pages here, then you'll see the generic preview.

phuedx closed this task as Resolved.Dec 2 2016, 7:59 AM
phuedx claimed this task.

Per T150814#2835851 and T150814#2838105.

phuedx moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-86-🔪🦃 board.Dec 2 2016, 7:59 AM
gerritbot added a comment.Dec 2 2016, 12:06 PM

Change 324164 merged by jenkins-bot:
previews: Add generic fallback preview

https://gerrit.wikimedia.org/r/324164

ovasileva changed the task status from Duplicate to Resolved.Dec 5 2016, 4:05 PM
ovasileva closed this task as a duplicate of T138607: Hovercard isn't showing any content when page has no lead section.

sorry - meant to merge {t138607} into this

ovasileva merged a task: T138607: Hovercard isn't showing any content when page has no lead section.Dec 5 2016, 4:06 PM
ovasileva added subscribers: Volker_E, dr0ptp4kt, Quiddity and 6 others.
Jdlrobson merged a task: T248681: Wrong page preview if page starts with <h2> in Popups extension.Mar 27 2020, 4:13 PM
Jdlrobson added a subscriber: ItSpiderman.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits