Page MenuHomePhabricator
Create Task
Maniphest T153359

Replace use of deprecated methods (mainly in ApiErrorReporter)
Closed, ResolvedPublic
Actions

Description

rMW4e6810e4a2c1: API: i18n for warnings and errors deprecated several things in the API. The relevant deprecations here are:

  • ApiBase::dieUsage() replaced with ApiBase::dieWithError()
  • ApiBase::setWarning() replaced with ApiBase::addWarning()
  • ApiBase::getErrorFromStatus() replaced with ApiErrorFormatter::arrayFromStatus()
  • UsageException replaced with ApiUsageException (Gerrit change 327545 seems to be working on this one)

Gerrit change 321464 has some more details on possible replacements for the use of the ApiBase methods in your ApiErrorReporter class. The interface being added in Gerrit change 325984 might also be handy.

Details

SubjectRepoBranchLines +/-
Minor refactorings and cleanups in ApiErrorReporter and testsmediawiki/extensions/Wikibasemaster+13 -18
WIP: Update for API error i18nmediawiki/extensions/Wikibasemaster+20 -0
Don't use deprecated methods in ApiErrorReporter.mediawiki/extensions/Wikibasemaster+133 -76
Replace deprecated methods in ApiErrorReportermediawiki/extensions/Wikibasemaster+16 -13
Remove ApiUsageException related dead code from EntityLoadingHelperTestmediawiki/extensions/Wikibasemaster+6 -14
Inject ApiBase into ItemByTitleHelper for proper error reportingmediawiki/extensions/Wikibasemaster+27 -2
Replace all deprecated UsageException in Repo with ApiUsageExceptionmediawiki/extensions/Wikibasemaster+249 -262
Customize query in gerrit

Related Objects
Search...

Event Timeline

Anomie created this task.Dec 15 2016, 9:25 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptDec 15 2016, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Dec 15 2016, 9:26 PM

Change 321464 had a related patch set uploaded (by Anomie):
WIP: Update for API error i18n

https://gerrit.wikimedia.org/r/321464

gerritbot added a project: Patch-For-Review.Dec 15 2016, 9:26 PM
gerritbot added a comment.Dec 16 2016, 7:42 AM

Change 327545 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace all deprecated UsageException in Repo with ApiUsageException

https://gerrit.wikimedia.org/r/327545

thiemowmde claimed this task.Dec 16 2016, 7:44 AM
thiemowmde triaged this task as Low priority.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde added a project: Wikidata-Former-Sprint-Board.
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde added subscribers: Lydia_Pintscher, daniel, • Aleksey_WMDE and 2 others.
gerritbot added a comment.Dec 16 2016, 8:10 AM

Change 327704 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace deprecated methods in ApiErrorReporter

https://gerrit.wikimedia.org/r/327704

thiemowmde moved this task from in progress to needs discussion or investigation on the Wikidata board.Dec 19 2016, 9:59 AM
thiemowmde moved this task from Review to Proposed on the Wikidata-Former-Sprint-Board board.
thiemowmde removed a project: Patch-For-Review.
gerritbot added a comment.Dec 19 2016, 10:01 AM

Change 327704 abandoned by Thiemo Mättig (WMDE):
Replace deprecated methods in ApiErrorReporter

Reason:
If you believe that a first small, incomplete step forward deserves a -1 just for being what it is, I'm wasting my time. Feel free to continue working on this.

https://gerrit.wikimedia.org/r/327704

gerritbot added a comment.Dec 19 2016, 10:14 AM

Change 328151 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Inject ApiBase into ItemByTitleHelper for proper error reporting

https://gerrit.wikimedia.org/r/328151

gerritbot added a project: Patch-For-Review.Dec 19 2016, 10:14 AM
gerritbot added a comment.Dec 19 2016, 10:40 AM

Change 328153 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove ApiUsageException related dead code from EntityLoadingHelperTest

https://gerrit.wikimedia.org/r/328153

gerritbot added a comment.Dec 19 2016, 5:33 PM

Change 327545 merged by jenkins-bot:
Replace all deprecated UsageException in Repo with ApiUsageException

https://gerrit.wikimedia.org/r/327545

gerritbot added a comment.Dec 29 2016, 4:16 PM

Change 328151 merged by Daniel Kinzler:
Inject ApiBase into ItemByTitleHelper for proper error reporting

https://gerrit.wikimedia.org/r/328151

gerritbot added a comment.Dec 29 2016, 4:30 PM

Change 328153 merged by jenkins-bot:
Remove ApiUsageException related dead code from EntityLoadingHelperTest

https://gerrit.wikimedia.org/r/328153

thiemowmde removed a project: Patch-For-Review.Mar 13 2017, 5:58 PM
Lydia_Pintscher added a comment.Apr 28 2017, 1:35 PM

What still needs to be done here?

Anomie added a comment.Apr 28 2017, 1:46 PM
In T153359#3220755, @Lydia_Pintscher wrote:

What still needs to be done here?

Updating your ApiErrorReporter class to not use the deprecated methods. There was some relevant discussion on https://gerrit.wikimedia.org/r/#/c/327704/ after it was abandoned.

Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.May 5 2017, 12:29 PM
daniel moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Jun 19 2017, 10:26 AM

Pending: get https://gerrit.wikimedia.org/r/#/c/353545/ and its follow-ups merged.

daniel raised the priority of this task from Low to Medium.Jun 19 2017, 10:28 AM
daniel added a parent task: T168367: Disable custom error reporting in the API if new error format is requested..Jun 20 2017, 9:08 AM
gerritbot added a comment.Jun 22 2017, 4:31 PM

Change 360872 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Minor refactorings and cleanups in ApiErrorReporter and tests

https://gerrit.wikimedia.org/r/360872

gerritbot added a project: Patch-For-Review.Jun 22 2017, 4:31 PM

Change 353545 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don't use deprecated methods in ApiErrorReporter.

https://gerrit.wikimedia.org/r/353545

gerritbot added a comment.Jun 22 2017, 5:12 PM

Change 321464 abandoned by Anomie:
WIP: Update for API error i18n

Reason:
Done in Ib5b1eae2ab66e633a438d2705d7b96f386f16939

https://gerrit.wikimedia.org/r/321464

gerritbot added a comment.Jun 23 2017, 6:39 AM

Change 360872 abandoned by Thiemo Mättig (WMDE):
Minor refactorings and cleanups in ApiErrorReporter and tests

Reason:
This became obsolete because Ib5b1eae got merged.

https://gerrit.wikimedia.org/r/360872

WMDE-leszek closed this task as Resolved.Jun 23 2017, 7:53 AM
WMDE-leszek reopened this task as Open.
WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
WMDE-leszek subscribed.

I might have marked this as resolved too early. Can we call this done @daniel @thiemowmde ?

aude added a comment.EditedJun 26 2017, 1:13 AM

We have lost some of the error descriptions.

currently on Wikidata:

https://www.wikidata.org/w/api.php?action=wbgetentities

{
    "error": {
        "code": "param-missing",
        "info": "A parameter that is required was missing. (Either provide the item \"ids\" or pairs of \"sites\" and \"titles\" for corresponding pages)",
        "messages": [
            {
                "name": "wikibase-api-param-missing",
                "parameters": [],
                "html": {
                    "*": "A parameter that is required was missing."
                }
            }
        ],
        "*": "See https://www.wikidata.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
    },
    "servedby": "mw1278"
}

Wikibase master:

{
    "error": {
        "code": "param-missing",
        "info": "A parameter that is required was missing.",
        "messages": [
            {
                "name": "wikibase-api-param-missing",
                "parameters": [],
                "html": {
                    "*": "A parameter that is required was missing."
                }
            }
        ],
        "*": "See https://wikidatawiki/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
    }
}

Think we want to make the full api error messages (including descriptions) translatable and add i18n messages for them.

The way ApiErrorReporter works now, the messages are based on the error code. (e.g. wikibase-api-param-missing). This error code is shared by numerous different api modules, each with a different error description.

We should still share the error code and not change it (api users might depend on how it is now), but allow the message / description to differ and be translatable.

thiemowmde closed this task as Resolved.Jun 26 2017, 8:53 AM
thiemowmde reassigned this task from thiemowmde to daniel.
thiemowmde removed a project: Patch-For-Review.

I'm closing this for now because the Wikibase code base does not contain calls to the methods and classes listed in this tickets description any more.

@aude, I'm working on these right now, see https://gerrit.wikimedia.org/r/360871.

aude mentioned this in T168859: Restore descriptions in Wikibase api error message.Jun 26 2017, 12:51 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits