Selected text is not replaced in new wikitext editor when a paste gets transformed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Tgr
	Dec 23 2016, 11:12 AM

Description

Steps to reproduce:

open something for editing in NWE
copy an URL to the clipboard
select some text in the edit window
press Ctrl-V to paste

Expected result: selected text is removed, the URL (or a corresponding internal link wikitext) is inserted in its place
Actual result: The URL (or transformed wikitext) is inserted after the selected text.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (139bdf7)	mediawiki/extensions/VisualEditor	master	+5 -24
	Overwrite selected content when pasting via DataTransferItem	VisualEditor/VisualEditor	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T154041: Pasting to replace selected text doesn't replace the text
Mentioned Here: rGVED139bdf7add81: Merge "Pass text as string to insertDocument when detected as plain text"

Event Timeline

Tgr created this task.Dec 23 2016, 11:12 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 23 2016, 11:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• AlexMonk-WMF mentioned this in T154041: Pasting to replace selected text doesn't replace the text.Dec 24 2016, 5:24 PM

I dug into this a bit, it looks like ve.ce.Surface.prototype.handleDataTransferItems always collapses to end. @Esanders?

• Whatamidoing-WMF merged a task: T154041: Pasting to replace selected text doesn't replace the text.Dec 24 2016, 11:07 PM

• Whatamidoing-WMF added subscribers: • Whatamidoing-WMF, IKhitron, Kaartic.

Dvorapa subscribed.Dec 29 2016, 6:31 PM

• AlexMonk-WMF merged a task: T154377: Not replacing pasted links.Jan 1 2017, 1:37 AM

• AlexMonk-WMF added a subscriber: Wargo.

Jdforrester-WMF triaged this task as High priority.Jan 6 2017, 12:52 AM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Jdforrester-WMF set the point value for this task to 1.

Schnark merged a task: T154979: Pasting URLs adds to instead of replaces selection in Visual Editor's wikitext mode.Jan 10 2017, 11:04 AM

Schnark added a subscriber: Distelfinck.

Schnark subscribed.

Dvorapa added a project: VisualEditor-CopyPaste.Jan 25 2017, 2:32 PM

Change 334681 had a related patch set uploaded (by Esanders):
Overwrite selected content when pasting via DataTransferItem

https://gerrit.wikimedia.org/r/334681

gerritbot added a project: Patch-For-Review.Jan 27 2017, 5:24 PM

Jdforrester-WMF closed this task as Resolved.Jan 29 2017, 6:02 PM

Jdforrester-WMF assigned this task to Esanders.

Change 334681 merged by jenkins-bot:
Overwrite selected content when pasting via DataTransferItem

https://gerrit.wikimedia.org/r/334681

Change 334906 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (139bdf7)

https://gerrit.wikimedia.org/r/334906

Change 309472 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (139bdf7)

https://gerrit.wikimedia.org/r/309472

Change 309472 merged by jenkins-bot:
Update VE core submodule to master (139bdf7)

https://gerrit.wikimedia.org/r/309472

This is now fixed in master.

In this edit, I selected the contents of the section and pasted a single-line URL over the whole thing (at 19:47 on Tuesday/four hours after the latest version was deployed).

The old URL was replaced by the new URL, but the rest of the contents stayed in place. Is that behavior still fixed-in-a-future-release, or was the fix only partial?

It doesn't look like the code has been deployed yet to MW.

Selected text is not replaced in new wikitext editor when a paste gets transformedClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Selected text is not replaced in new wikitext editor when a paste gets transformed
Closed, ResolvedPublic1 Estimated Story Points
Actions