Page MenuHomePhabricator
Create Task
Maniphest T154188

Echo qunit test has a time based race condition ( ext.echo.dm - mw.echo.dm.NotificationItem Constructing items FAILED )
Closed, ResolvedPublic
Actions

Description

This is the second time this has occurred recently: Jekins has failed because the timestamp generated by the code is one second off from the expected value, most likely because the code takes some time to run and the seconds hand of the clock might tick once in the mean time. example

A QUnit test for Echo has a race condition with a timestamp. The expected time and function results have a one second resolution and can divert:

Chrome 53.0.2785 (Linux 0.0.0) ext.echo.dm - mw.echo.dm.NotificationItem Constructing items FAILED
Empty data (getTimestamp)
Expected: "2016-12-15T13:54:41Z"
Actual: "2016-12-15T13:54:42Z"

Details

SubjectRepoBranchLines +/-
Use fake timer in Echo unit testsmediawiki/extensions/EchoREL1_28+9 -4
Use fake timer in Echo unit testsmediawiki/extensions/EchoREL1_28+11 -5
Use fake timer in Echo unit testsmediawiki/extensions/Echomaster+32 -27
Fix 'getTimestamp' default check in NotificationItem unit testmediawiki/extensions/Echomaster+14 -2
Customize query in gerrit

Event Timeline

Huji created this task.Dec 27 2016, 5:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 27 2016, 5:30 PM
Paladox added a project: Continuous-Integration-Infrastructure.Dec 27 2016, 10:21 PM
Paladox subscribed.
hashar renamed this task from Jenkins should tolerate a one second delay to Echo qunit test has a time based race condition ( ext.echo.dm - mw.echo.dm.NotificationItem Constructing items FAILED ).Dec 28 2016, 11:26 AM
hashar edited projects, added Notifications; removed Continuous-Integration-Infrastructure, Jenkins.
hashar updated the task description. (Show Details)
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 28 2016, 11:26 AM
hashar added subscribers: • MSchottlender-WMF, hashar.Dec 28 2016, 11:37 AM

Tests added by Moriel. The race is the expected timestamp is forged first, then a notification object created which get a timestamp independently and can thus be different.

gerritbot subscribed.Jan 3 2017, 7:17 PM

Change 321793 had a related patch set uploaded (by Catrope):
Fix 'getTimestamp' default check in NotificationItem unit test

https://gerrit.wikimedia.org/r/321793

gerritbot added a project: Patch-For-Review.Jan 3 2017, 7:17 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage.Jan 3 2017, 7:34 PM
• jmatazzoni moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
hashar assigned this task to • Catrope.Jan 3 2017, 7:42 PM

Thank you for taking care of that. Race conditions are nasty :]

• Catrope reassigned this task from • Catrope to Mooeypoo.Jan 3 2017, 8:54 PM
• Catrope subscribed.

(That was actually Moriel's patch, not mine. It predates this task, so all I did was tag it.)

• Catrope reassigned this task from Mooeypoo to SBisson.Jan 3 2017, 9:44 PM
• Catrope added a subscriber: Mooeypoo.

Reassigning to Stephane because Moriel's busy and he isn't.

gerritbot added a comment.Jan 4 2017, 9:21 PM

Change 330480 had a related patch set uploaded (by Sbisson):
Use fake timer in Echo unit tests

https://gerrit.wikimedia.org/r/330480

gerritbot added a comment.Jan 4 2017, 10:02 PM

Change 321793 abandoned by Sbisson:
Fix 'getTimestamp' default check in NotificationItem unit test

Reason:
Should be fixed by I6b0c8ae06360e6da016d97361cc2ccdeaf2e4343

https://gerrit.wikimedia.org/r/321793

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 4 2017, 10:03 PM
gerritbot added a comment.Jan 4 2017, 10:27 PM

Change 330480 merged by jenkins-bot:
Use fake timer in Echo unit tests

https://gerrit.wikimedia.org/r/330480

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 4 2017, 11:00 PM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 6 2017, 7:53 PM
Etonkovidova subscribed.Jan 12 2017, 12:16 AM

@SBisson The most recent failure was in https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/21081/console (Build #21081 (Jan 11, 2017 6:42:25 PM)):

18:45:39 Chrome 55.0.2883 (Linux 0.0.0) ext.echo.dm - mw.echo.dm.NotificationItem Constructing items FAILED
18:45:39 	Empty data (getTimestamp)
18:45:39 	Expected: "2017-01-11T18:45:37Z"
18:45:39 	Actual: "2017-01-11T18:45:38Z"

After that up to the Build #21142 (Jan 11, 2017 11:47:38 PM), mediawiki-extensions-qunit-jessie is marked with SUCCESS.

hashar added a comment.Jan 12 2017, 11:01 PM

That January 11th failure was for a patch made against the REL1_28 branch.

So I guess we could backport https://gerrit.wikimedia.org/r/#/c/330480/ ?

gerritbot added a comment.Jan 12 2017, 11:05 PM

Change 331927 had a related patch set (by Paladox) published:
Use fake timer in Echo unit tests

https://gerrit.wikimedia.org/r/331927

gerritbot added a comment.Jan 16 2017, 3:27 PM

Change 332335 had a related patch set uploaded (by Paladox):
Use fake timer in Echo unit tests

https://gerrit.wikimedia.org/r/332335

gerritbot added a comment.Jan 16 2017, 3:28 PM

Change 331927 abandoned by Paladox:
Use fake timer in Echo unit tests

Reason:
Done here https://gerrit.wikimedia.org/r/332335

https://gerrit.wikimedia.org/r/331927

Etonkovidova added a comment.EditedJan 17 2017, 9:14 PM

Checked - no more "Empty data (getTimestamp)" errors for mediawiki-extensions-qunit-jessie tests. There are some failures (e.g. the most recent #21343), but with a different error.

QA recommendation: Resolve.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 17 2017, 9:15 PM
• jmatazzoni closed this task as Resolved.Jan 17 2017, 10:39 PM
gerritbot added a comment.Apr 14 2017, 11:57 AM

Change 332335 abandoned by Reedy:
Use fake timer in Echo unit tests

https://gerrit.wikimedia.org/r/332335

Huji removed a project: Patch-For-Review.Nov 5 2017, 2:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits