Turn off patrolling in ruwiki
Closed, InvalidPublic
Actions

Assigned To

Authored By

	MBH
	Dec 29 2016, 2:22 PM

Description

Please, turn off completely patrolling (native wiki engine functionality) in ruwiki. Since 2008 ruwiki has FlaggedRevs reviewing (that called "patrolling" in community), but old patrolling confuses many users, see for example https://ru.wikipedia.org/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A4%D0%BE%D1%80%D1%83%D0%BC/%D0%A2%D0%B5%D1%85%D0%BD%D0%B8%D1%87%D0%B5%D1%81%D0%BA%D0%B8%D0%B9#K10 This request was sent to bugzilla before 2010, but patrolling was turned off not completely, it still exist in logs.

Discussion: https://ru.wikipedia.org/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A4%D0%BE%D1%80%D1%83%D0%BC/%D0%9F%D1%80%D0%B5%D0%B4%D0%BB%D0%BE%D0%B6%D0%B5%D0%BD%D0%B8%D1%8F#.D0.9E.D0.BA.D0.BE.D0.BD.D1.87.D0.B0.D1.82.D0.B5.D0.BB.D1.8C.D0.BD.D0.BE.D0.B5_.D0.BE.D1.82.D0.BA.D0.BB.D1.8E.D1.87.D0.B5.D0.BD.D0.B8.D0.B5_.22.D1.81.D1.82.D0.B0.D1.80.D0.BE.D0.B3.D0.BE_.D0.BF.D0.B0.D1.82.D1.80.D1.83.D0.BB.D0.B8.D1.80.D0.BE.D0.B2.D0.B0.D0.BD.D0.B8.D1.8F.22

Details

	Subject	Repo	Branch	Lines +/-
	Turn off patrolling in ruwiki	operations/mediawiki-config	master	+31 -25

Customize query in gerrit

Related Objects

Mentioned In: T316393: Disable all patrolling functions on de.wikipedia
T102818: Disable patrolling on de.wikipedia
T158662: Turn off patrolling on bs.wiki and configure FlaggedRevs
T154990: Add bnwiki, enwiki and commons as import source in bd.wikimedia.org
T154367: Phabricator log message misses previous (default) name of Paste after renaming a Paste
Mentioned Here: T154990: Add bnwiki, enwiki and commons as import source in bd.wikimedia.org
P4690 T154285: Turn off patrolling in ruwiki

Event Timeline

MBH created this task.Dec 29 2016, 2:22 PM

Restricted Application added subscribers: Base, Aklapper. · View Herald TranscriptDec 29 2016, 2:22 PM

Amire80 awarded a token.Dec 29 2016, 3:58 PM

MarcoAurelio edited projects, added Wikimedia-Site-requests; removed MediaWiki-Configuration, MediaWiki-Patrolling.Dec 29 2016, 4:41 PM

Dereckson moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.Dec 29 2016, 7:03 PM

Gamliel_Fishkin subscribed.Dec 30 2016, 1:48 AM

I'm looking at the files and I don't see patrolling enabled for ruwiki. The automatic edit patrol done by sysops is not removable I think.

https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%96%D1%83%D1%80%D0%BD%D0%B0%D0%BB%D1%8B&type=patrol&user=Oude-rusman&page=&tagfilter= this isn't sysop, this is FlaggedRevs autopatroller.

What happens to the new page patrol logs and patroller flag related user right log entries in case the task is resolved?

So you wish to unassign autopatrol from all users?

@MarcoAurelio Old patrolling is enabled for files, wgUseFilePatrol in IS.

So you wish to unassign autopatrol from all users?

Exactly.

In T154285#2908590, @Base wrote:

What happens to the new page patrol logs and patroller flag related user right log entries in case the task is resolved?

I think nothing. History can't be changed as well as logs.

In T154285#2908595, @MaxBioHazard wrote:

So you wish to unassign autopatrol from all users?

Exactly.

Was this discussed at ruwiki?

Urbanecm moved this task from Config - to process to Analysis / under discussion on the Wikimedia-Site-requests board.Dec 31 2016, 2:56 PM

No, I didn't thought it should be discussed.

I think it should. Also please discuss if you wish to disable the old-style file patrolling too (it seems to be handled in FlaggedRevs too).

But https://ru.wikipedia.org/wiki/special:listgrouprights says that patrol right withdrawn from all usergroups, including admins.

Strange, I can't see it in config files... For example https://bg.wikipedia.org/wiki/Специални:Групови_права doesn't show autopatrol at all for the sysop group.

What a mess :-)

Sysops at ruwiki have patrol and autopatrol permissions. Both are (IIRC) standard in mediawiki core.
wgUseRCPatrol is set to false by default, and there's no override for ruwiki. Not the problem.
wgUseNPPatrol is set to true by default but ruwiki has set it to false. Not the problem.
wgUseFilePatrol is set to true by default, only huwiki has opted-out. This might need to be turned off.

My idea is, so far, this:

P4690 T154285: Turn off patrolling in ruwiki

1	diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php
2	index 6585c9e..9323903 100644
3	--- a/wmf-config/InitialiseSettings.php
4	+++ b/wmf-config/InitialiseSettings.php
5	@@ -7058,6 +7058,7 @@ $wgConf->settings = [
6	'wgUseFilePatrol' => array(
7	'default' => true,
8	'huwiki' => false, // T21241
9	+ 'ruwiki' => false, // T154285
10	),
11
12	# wgNoFollow... @{
13	@@ -8652,32 +8653,31 @@ $wgConf->settings = [
14	],
15	],
16	'+ruwiki' => [
17	- '*' => [ 'patrolmarks' => true, ],
18	+ '*' => [
19	+ 'patrolmarks' => true,
20	+ ],
21	+ 'arbcom' => [ // T51334
22	+ 'abusefilter-log-detail' => true,
23	+ 'browsearchive' => true,
24	+ 'deletedhistory' => true,
25	+ 'deletedtext' => true,
26	+ ],
27	'autoconfirmed' => [
28	'collectionsaveascommunitypage' => false, // T85780
29	],
30	'bot' => [
31	- 'move-categorypages' => true, // T87230
32	+ 'autopatrol' => false, // T154285
33	'changetags' => true, // T136187
34	- ],
35	- 'rollbacker' => [ 'rollback' => true ],
36	- 'uploader' => [ // T14334
37	- 'upload' => true,
38	- 'reupload-own' => true,
39	- 'reupload' => true,
40	- ],
41	- 'user' => [ // T68871
42	- 'move-categorypages' => false,
43	- 'changetags' => false, // T136187
44	+ 'move-categorypages' => true, // T87230
45	],
46	'closer' => [
47	- 'move-categorypages' => true, // T68871
48	'delete' => true,
49	+ 'move-categorypages' => true, // T68871
50	+ 'move-subpages' => true, // T76131
51	+ 'reupload' => true,
52	+ 'reupload-own' => true,
53	'suppressredirect' => true,
54	'upload' => true,
55	- 'reupload-own' => true,
56	- 'reupload' => true,
57	- 'move-subpages' => true, // T76131
58	],
59	'engineer' => [ // T144599
60	'apihighlimits' => true,
61	@@ -8694,26 +8694,35 @@ $wgConf->settings = [
62	'suppressredirect' => true,
63	],
64	'filemover' => [ // T32984
65	+ 'move-categorypages' => true, // T68871
66	+ 'move-subpages' => true, // T76131
67	'movefile' => true,
68	+ 'reupload' => true,
69	+ 'reupload-own' => true,
70	'suppressredirect' => true,
71	'upload' => true,
72	+ ],
73	+
74	+ 'uploader' => [ // T14334
75	+ 'upload' => true,
76	'reupload-own' => true,
77	'reupload' => true,
78	- 'move-categorypages' => true, // T68871
79	- 'move-subpages' => true, // T76131
80	+ ],
81	+ 'user' => [ // T68871
82	+ 'changetags' => false, // T136187
83	+ 'move-categorypages' => false,
84	+ ],
85	+ 'rollbacker' => [
86	+ 'rollback' => true
87	],
88	'suppressredirect' => [ // T40408, T68871
89	- 'suppressredirect' => true,
90	'move-categorypages' => true,
91	- ],
92	- 'arbcom' => [ // T51334
93	- 'browsearchive' => true,
94	- 'deletedhistory' => true,
95	- 'deletedtext' => true,
96	- 'abusefilter-log-detail' => true,
97	+ 'suppressredirect' => true,
98	],
99	'sysop' => [
100	+ 'autopatrol' => false, // T154285
101	'changetags' => true, // T136187
102	+ 'patrol' => false, // T154285
103	],
104	],
105	'ruwikiquote' => [

where we remove from bots the autopatrol right and the patrol and autopatrol right from sysops (plus I ordered everything in alphabetical order). Let me know if that would work.

MarcoAurelio mentioned this in T154367: Phabricator log message misses previous (default) name of Paste after renaming a Paste.Dec 31 2016, 4:29 PM

Urbanecm updated the task description. (Show Details)Jan 1 2017, 9:29 AM

@MaxBioHazard Thanks for the link.

@MarcoAurelio At least it should stop patrol anything from my POV and stop old patrol events appear in logs (as they won't exist).

The discussion ended, all users voted for a full disable of old-style patrolling (including files).

Change 331605 had a related patch set uploaded (by Urbanecm):
Turn off patrolling in ruwiki

https://gerrit.wikimedia.org/r/331605

gerritbot added a project: Patch-For-Review.Jan 11 2017, 1:23 PM

Okay, I've uploaded a patch for this to gerrit based on the on from @MarcoAurelio. I'll deploy it today.

Urbanecm claimed this task.Jan 11 2017, 1:24 PM

Urbanecm triaged this task as Medium priority.

Urbanecm moved this task from Analysis / under discussion to To deploy on the Wikimedia-Site-requests board.

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJan 11 2017, 1:25 PM

Urbanecm moved this task from Backlog to To deploy on the User-Urbanecm board.Jan 11 2017, 1:25 PM

What means

'+ruwiki' => [
		'*' => [
			'patrolmarks' => true,
		],

that remains in new code? If this is a right to see patrol marks, maybe it should be disabled too?

Yes, you're right. It means View recent changes patrol marks. I'll disable it.

Change 331605 merged by jenkins-bot:
Turn off patrolling in ruwiki

https://gerrit.wikimedia.org/r/331605

Mentioned in SAL (#wikimedia-operations) [2017-01-11T14:11:43Z] <hashar@tin> Synchronized wmf-config/InitialiseSettings.php: Import source on bd.wikimedia.org T154990 + Turn of patrolling on ruwiki T154285 (duration: 00m 42s)

Urbanecm closed this task as Resolved.Jan 11 2017, 2:13 PM

Still not fixed: https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F%3A%D0%96%D1%83%D1%80%D0%BD%D0%B0%D0%BB%D1%8B&type=patrol&user=&page=&year=&month=-1&hide_thanks_log=1&hide_tag_log=1&hide_review_log=1

It seems FlaggedRevs mark every edit reviewed by this tool as patrolled using the old way.

"Patrolling of reviewable pages is disabled, but flagged revisions are marked as patrolled in Recent Changes. This will mean that the only way to patrol a reviewable revision is to flag it. Non-reviewable pages still behave as normal (depending on site patrol settings). " confirm it.

Urbanecm moved this task from To deploy to Analysis / under discussion on the Wikimedia-Site-requests board.Jan 14 2017, 8:03 AM

Urbanecm moved this task from To deploy to Backlog on the User-Urbanecm board.Jan 14 2017, 5:17 PM

Urbanecm moved this task from Backlog to Working on on the User-Urbanecm board.Jan 17 2017, 5:39 PM

Can this behaviour be changed? By adding an option to extension options or just removing this functionality?

@MaxBioHazard Sadly not currently. The extension doesn't allow to turn it off per wiki so I can't change it just for ruwiki. Closing it as invalid because requested action can't be done.

You can create new ticket under MediaWiki-extensions-FlaggedRevs and ask the developers to add this feature as a feature request.

Srdjan mentioned this in T158662: Turn off patrolling on bs.wiki and configure FlaggedRevs.Mar 5 2017, 8:05 PM

Wnme mentioned this in T102818: Disable patrolling on de.wikipedia.Aug 26 2022, 6:03 PM

Wnme mentioned this in T316393: Disable all patrolling functions on de.wikipedia .Aug 26 2022, 6:23 PM

FriedrickMILBarbarossa added a project: Russian-Sites.Aug 27 2022, 9:32 PM

Turn off patrolling in ruwikiClosed, InvalidPublicActions

Description

Details

Related Objects

Event Timeline

Turn off patrolling in ruwiki
Closed, InvalidPublic
Actions