Page MenuHomePhabricator
Create Task
Maniphest T155799

mobile.pagelist JS code should be part of mobile.startup
Closed, ResolvedPublic
Actions

Description

mobile.pagelist is loaded by default on every MobileFrontend page view because of the fact it is used in mobile.search

Let's fold this functionality into the mobile.startup module.

Details

SubjectRepoBranchLines +/-
Don't use deprecated mobile.pagelist/PageListmediawiki/extensions/MobileFrontendmaster+1 -1
Hygiene: mobile.pagelist folded into mobile.startupmediawiki/extensions/MobileFrontendmaster+10 -22
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jan 20 2017, 1:14 AM
gerritbot subscribed.Jan 20 2017, 8:05 PM

Change 333293 had a related patch set uploaded (by Jdlrobson):
Hygiene: mobile.pagelist folded into mobile.startup

https://gerrit.wikimedia.org/r/333293

gerritbot added a project: Patch-For-Review.Jan 20 2017, 8:05 PM
Jdlrobson triaged this task as Low priority.Jan 24 2017, 7:39 PM
Jdlrobson added a project: Reading-Web-Sprint-90-🍌.
Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jan 24 2017, 7:48 PM
• bmansurov added a project: Unplanned-Sprint-Work.Jan 25 2017, 4:41 PM
phuedx removed a project: Epic.Jan 25 2017, 5:46 PM
• bmansurov moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.Jan 25 2017, 6:33 PM
• bmansurov moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.Jan 25 2017, 11:31 PM

@phuedx would you please sign off as it is a technical task?

Jdlrobson moved this task from Ready for Signoff to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.Jan 25 2017, 11:47 PM
Jdlrobson added a comment.Jan 25 2017, 11:57 PM

(patch is not merged as it depends on T155801)

phuedx moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.Jan 26 2017, 1:31 PM
phuedx claimed this task.Jan 26 2017, 2:19 PM

^ Per T155799#2970819.

gerritbot added a comment.Jan 26 2017, 2:21 PM

Change 333293 merged by jenkins-bot:
Hygiene: mobile.pagelist folded into mobile.startup

https://gerrit.wikimedia.org/r/333293

gerritbot added a comment.Jan 26 2017, 2:46 PM

Change 334352 had a related patch set uploaded (by Phuedx):
Don't use deprecated mobile.pagelist/PageList

https://gerrit.wikimedia.org/r/334352

phuedx added a comment.Jan 26 2017, 2:47 PM

^ Trivial, trivial update to remove a deprecation notice that I saw while signing this off on the Beta Cluster.

phuedx added a comment.Jan 26 2017, 2:49 PM

This LGTM. The search results, which are powered by WatchstarPageList (and PageList, by definition), work as expected. I'll resolve this once rEMFR86c3262bd263: Don't use deprecated mobile.pagelist/PageList has been merged.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 26 2017, 3:00 PM
gerritbot added a comment.Jan 26 2017, 3:50 PM

Change 334352 merged by jenkins-bot:
Don't use deprecated mobile.pagelist/PageList

https://gerrit.wikimedia.org/r/334352

Jdlrobson removed a project: Patch-For-Review.Jan 26 2017, 4:39 PM
phuedx closed this task as Resolved.Jan 26 2017, 5:23 PM
MBinder_WMF moved this task from Triaged but Future to 2016-17 Q3 on the Web-Team-Backlog board.Oct 10 2017, 7:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits