Maniphest T155801

Merge mobile.toast into mobile.startup
Closed, ResolvedPublic
Actions

Description

mobile.toast is loaded by default on every MobileFrontend page view

Let's fold this functionality into the mobile.startup module.

Note that Thanks makes use of this module so care needs to be taken in making this happen.

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: Remove mobile.toast pointer	mediawiki/extensions/MobileFrontend	master	+1 -7
	Remove MobileFrontend toast dependency	mediawiki/extensions/Thanks	master	+2 -4
	Hygiene: Move mobile.toast into mobile.startup	mediawiki/extensions/MobileFrontend	master	+26 -37

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
		Resolved		Jdlrobson	T171000 [EPIC] Minerva works independently of MobileFrontend
		Resolved		Jdlrobson	T166905 [EPIC] Talk about and improve our frontend code architecture
		Declined		None	T144402 Extract MobileFrontend UI components to an external well documented library
		Resolved		Jdlrobson	T155801 Merge mobile.toast into mobile.startup

Event Timeline

Jdlrobson created this task.Jan 20 2017, 1:15 AM

Change 333151 had a related patch set uploaded (by Jdlrobson):
Hygiene: Move mobile.toast into mobile.startup

https://gerrit.wikimedia.org/r/333151

gerritbot added a project: Patch-For-Review.Jan 20 2017, 1:28 AM

Jdlrobson triaged this task as Low priority.Jan 24 2017, 7:39 PM

Jdlrobson added a project: Reading-Web-Sprint-90-🍌.

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.Jan 24 2017, 7:42 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jan 24 2017, 7:48 PM

• bmansurov added a project: Unplanned-Sprint-Work.Jan 25 2017, 4:40 PM

• bmansurov moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.Jan 25 2017, 6:33 PM

Jdlrobson mentioned this in T155799: mobile.pagelist JS code should be part of mobile.startup.Jan 25 2017, 11:57 PM

Change 333151 merged by jenkins-bot:
Hygiene: Move mobile.toast into mobile.startup

https://gerrit.wikimedia.org/r/333151

phuedx moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.Jan 26 2017, 1:31 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 26 2017, 2:00 PM

Jdlrobson removed projects: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), Patch-For-Review.Jan 26 2017, 4:38 PM

Jdlrobson added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).

Jdlrobson moved this task from Ready for Signoff to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.Jan 26 2017, 7:28 PM

Change 334417 had a related patch set uploaded (by Jdlrobson):
Remove MobileFrontend toast dependency

https://gerrit.wikimedia.org/r/334417

Change 334418 had a related patch set uploaded (by Jdlrobson):
Deprecate mobile.toast

https://gerrit.wikimedia.org/r/334418

Change 334417 merged by jenkins-bot:
Remove MobileFrontend toast dependency

https://gerrit.wikimedia.org/r/334417

Change 334418 merged by jenkins-bot:
Hygiene: Remove mobile.toast pointer

https://gerrit.wikimedia.org/r/334418

Jdlrobson removed a project: Patch-For-Review.Jan 26 2017, 9:12 PM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.

This is a technical task. No errors or warnings on beta cluster any more.

Mooeypoo mentioned this in T156429: RC - Selecting all filters in a group makes them grey out .Jan 26 2017, 11:55 PM

MBinder_WMF moved this task from Triaged but Future to 2016-17 Q3 on the Web-Team-Backlog board.Oct 10 2017, 7:38 PM