IRC relay broken in master
Closed, ResolvedPublic
Actions

Description

This also broke our IRC relay ($wgRCFeeds['irc'] = array( 'formatter' => 'IRCColourfulRCFeedFormatter', ...) ).

	Subject	Repo	Branch	Lines +/-
	rcfeed: Ensure formatter (and other params) is passed to RCFeedEngine	mediawiki/core	master	+4 -4

		Status	Subtype	Assigned	Task
		Resolved		thcipriani	T155526 MW-1.29.0-wmf.11 deployment blockers
		Resolved		Krinkle	T157106 IRC relay broken in master

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2017, 6:52 AM

This blocks upgrade for us and should be Unbreak now, right?

Nemo_bis added a subscriber: Krinkle.

In T157106#2995692, @Nemo_bis wrote:

This blocks upgrade for us and should be Unbreak now, right?

Does this affect prod? If so yes, anything that affects prod is high priority.

Change 335969 had a related patch set uploaded (by Krinkle):
rcfeed: Ensure formatter (and other params) is passed to RCFeedEngine

Krinkle renamed this task from IRC relay broken to IRC relay broken in master.Feb 6 2017, 7:23 PM

Krinkle claimed this task.

Krinkle triaged this task as Unbreak Now! priority.

Change 335969 merged by jenkins-bot:
rcfeed: Ensure formatter (and other params) is passed to RCFeedEngine

Fixed according to @Nikerabbit.