Stop supporting Firefogg in Upload Wizard now that Firefox is making it impossible
Open, Needs TriagePublic

Description

As can be seen in this screenshot:
https://commons.wikimedia.org/wiki/File:Screenshot_of_upload_wizard_error.jpeg

the upload wizard is failing for me. It is doing so consistent, and has been for several I amusing Firefox (50.0.1 - the up--to-date version) on a high-spec Windows10 machine, The problem persists, even after I restart my machine. Even if I try to upload more than one image at once, it reports "1 of 1 file uploaded" and does not show the "continue" button.

Reported twice:

Backtrace:

NS_ERROR_UNEXPECTED:   load.php:47
        mw.FirefoggHandler.prototype.start https://commons.wikimedia.org/w/load.php:47:411
        mw.UploadWizardUpload.prototype.start https://commons.wikimedia.org/w/load.php:99:396
        uw.controller.Upload.prototype.transitionOne https://commons.wikimedia.org/w/load.php:203:409
        bound  self-hosted
        uw.ConcurrentQueue.prototype.executeNext https://commons.wikimedia.org/w/load.php:194:609
        uw.ConcurrentQueue.prototype.startExecuting https://commons.wikimedia.org/w/load.php:194:877
        uw.controller.Upload.prototype.startQueuedUploads https://commons.wikimedia.org/w/load.php:203:652
        uw.controller.Upload.prototype.setUploadFilled https://commons.wikimedia.org/w/load.php:204:991
        uw.controller.Upload.prototype.addFile https://commons.wikimedia.org/w/load.php:204:272
        uw.controller.Upload.prototype.addFiles/< https://commons.wikimedia.org/w/load.php:204:480
        .each https://commons.wikimedia.org/w/load.php:5:226
        uw.controller.Upload.prototype.addFiles https://commons.wikimedia.org/w/load.php:204:440
        UWControllerUpload/< https://commons.wikimedia.org/w/load.php:201:955
        oo.EventEmitter.prototype.emit https://commons.wikimedia.org/w/load.php:588:836
        uw.ui.Upload.prototype.setupFileInputCtrl/< https://commons.wikimedia.org/w/load.php:221:214
        jQuery.event.dispatch https://commons.wikimedia.org/w/load.php:65:913
        jQuery.event.add/elemData.handle https://commons.wikimedia.org/w/load.php:60:459
Ijon created this task.Sun, Feb 5, 12:46 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptSun, Feb 5, 12:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Permalink to report & copied screenshot for ease of access:

@Pigsonthewing does this still appear if you clear browser cache? and/or enable debug mode? If it's still there, anything in your browser console?

matmarex changed the title from "Upload Wizard receives file but "Continue" does not appear" to "Upload Wizard receives file but "Continue" does not appear (on Firefox, with Firefogg installed)".Mon, Feb 6, 3:21 PM
matmarex edited the task description. (Show Details)
matmarex edited the task description. (Show Details)
Pigsonthewing added a comment.EditedMon, Feb 6, 3:24 PM

Original report at:

https://commons.wikimedia.org/wiki/Commons:Village_pump#Upload_wizard_error

Where I have recently replied to a request for a console log.

And no, clearing the browser cache made no effect. When using:

https://commons.wikimedia.org/wiki/Special:UploadWizard?debug=true

the symptoms are the same.

I suspect something in a new Firefox version is breaking how Firefogg works. (Some random bug, unrelated to the planned shutdown of extensions of this type – see https://blog.mozilla.org/addons/2016/11/23/add-ons-in-2017/ and https://firefogg.org/.) The error message (pasted in description) is very unhelpful in determining exactly what. Given this, I don't think anyone would be interested in hearing our bug reports.

On my Firefox 52 (beta), installing the Firefogg extension doesn't work entirely (nothing breaks like described in this report, but UploadWizard doesn't detect Firefogg being present at all).

Unless anyone can confirm that Firefogg transcoding in UploadWizard actually works for them, we should probably just disable the integration quickly somehow to avoid breaking the experience for everyone.

Removing the Firefox add-on fixed this for me.

On my Firefox 52 (beta), installing the Firefogg extension doesn't work entirely (nothing breaks like described in this report, but UploadWizard doesn't detect Firefogg being present at all).

Actually, it's Firefox 52 already dropping support for extensions like Firefogg. The blog post I linked seemed to suggest this will happen later, but https://developer.mozilla.org/en-US/Firefox/Releases/52 says:

All NPAPI plugin support except Flash has been dropped (see Plug-in support has been dropped
other than Flash for more details). Flash usage is also set to be phased out in the future.

Firefox 52 is to be released in March 2017. So I say let's just disable Firefogg support now.

Change 336434 had a related patch set uploaded (by Bartosz Dziewoński):
Disable Firefogg support by default

https://gerrit.wikimedia.org/r/336434

Jdforrester-WMF changed the title from "Upload Wizard receives file but "Continue" does not appear (on Firefox, with Firefogg installed)" to "Stop supporting Firefogg in Upload Wizard now that Firefox is making it impossible".Tue, Feb 7, 7:50 PM
Jdforrester-WMF added a project: User-notice.
jrbs added a subscriber: jrbs.Tue, Feb 7, 10:47 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

I don't think it's worth scrambling to fix this just to switch it off three weeks later. :-(

Change 336610 had a related patch set uploaded (by Matthias Mullie):
Remove Firefogg

https://gerrit.wikimedia.org/r/336610

Change 336434 merged by jenkins-bot:
Disable Firefogg support by default

https://gerrit.wikimedia.org/r/336434

Change 336650 had a related patch set uploaded (by Bartosz Dziewoński):
Disable Firefogg support by default

https://gerrit.wikimedia.org/r/336650

Change 336651 had a related patch set uploaded (by Bartosz Dziewoński):
Disable Firefogg support by default

https://gerrit.wikimedia.org/r/336651

Change 336650 merged by jenkins-bot:
Disable Firefogg support by default

https://gerrit.wikimedia.org/r/336650

Change 336651 merged by jenkins-bot:
Disable Firefogg support by default

https://gerrit.wikimedia.org/r/336651

Mentioned in SAL (#wikimedia-operations) [2017-02-08T19:05:49Z] <dereckson@tin> Synchronized php-1.29.0-wmf.10/extensions/UploadWizard/UploadWizard.config.php: Disable Firefogg support (T157201) (duration: 00m 46s)

Mentioned in SAL (#wikimedia-operations) [2017-02-08T19:08:04Z] <dereckson@tin> Synchronized php-1.29.0-wmf.11/extensions/UploadWizard/UploadWizard.config.php: Disable Firefogg support (T157201) (duration: 00m 44s)

With these changes being deployed, UploadWizard will not try to use Firefogg, and thus this issue should be resolved even if you have it installed.

I'm leaving the task open until https://gerrit.wikimedia.org/r/336610 is merged (which removes all of the unused code).

See T157319 for investigation of a possible replacement for Firefogg :(