Page MenuHomePhabricator

EchoDiscussionParserTest is slow
Closed, ResolvedPublic

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hmm this probably points to the underlying code being slow, not just the tests themselves. I suspect this is because it uses wfDiff() a lot.

Change 333673 had a related patch set uploaded (by WMDE-Fisch):
DiscussionParserTest only create users when needed

A while ago @Addshore slightly improved the test setup there to speed them up. Just needs reviews.

Change 333673 merged by jenkins-bot:
DiscussionParserTest only create users when needed

@WMDE-Fisch @Addshore Very nice :)

I'll mark this as resolved! If you want to explore additional optimisations to the user creation, I'd recommend exploring the getTestUser() and getMutableTestUser() methods on MediaWikiTestCase.

Krinkle assigned this task to Addshore.
Krinkle triaged this task as Medium priority.