Page MenuHomePhabricator

EchoDiscussionParserTest is slow
Closed, ResolvedPublic

Details

Related Gerrit Patches:
mediawiki/extensions/Echo : masterDiscussionParserTest only create users when needed

Event Timeline

Krinkle created this task.Feb 14 2017, 9:09 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 14 2017, 9:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hmm this probably points to the underlying code being slow, not just the tests themselves. I suspect this is because it uses wfDiff() a lot.

Change 333673 had a related patch set uploaded (by WMDE-Fisch):
DiscussionParserTest only create users when needed

https://gerrit.wikimedia.org/r/333673

A while ago @Addshore slightly improved the test setup there to speed them up. Just needs reviews.

Change 333673 merged by jenkins-bot:
DiscussionParserTest only create users when needed

https://gerrit.wikimedia.org/r/333673

@WMDE-Fisch @Addshore Very nice :)

I'll mark this as resolved! If you want to explore additional optimisations to the user creation, I'd recommend exploring the getTestUser() and getMutableTestUser() methods on MediaWikiTestCase.

https://integration.wikimedia.org/ci/job/mediawiki-extensions-php55-trusty/1719/testReport/(root)/EchoDiscussionParserTest/history/

Krinkle closed this task as Resolved.Feb 24 2017, 9:34 PM
Krinkle assigned this task to Addshore.
Krinkle triaged this task as Medium priority.
Restricted Application added a project: User-Addshore. · View Herald TranscriptFeb 24 2017, 9:34 PM