| Krinkle | |
| Feb 14 2017, 9:09 PM |
| F5824148: Screen Shot 2017-02-24 at 13.28.59.png | |
| Feb 24 2017, 9:34 PM |
| F5806243: Screen Shot 2017-02-23 at 20.54.16.png | |
| Feb 24 2017, 4:56 AM |
| F5631106: Screen Shot 2017-02-14 at 13.07.59.png | |
| Feb 14 2017, 9:09 PM |
| F5631110: Screen Shot 2017-02-14 at 13.08.45.png | |
| Feb 14 2017, 9:09 PM |
This is currently the slowest test suite in shared extension gate Jenkins job (mediawiki-extensions-php55-trusty). Usually takes 30-60 seconds.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| DiscussionParserTest only create users when needed | mediawiki/extensions/Echo | master | +41 -20 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Addshore | T158120 EchoDiscussionParserTest is slow | |||
| Resolved | WMDE-Fisch | T93625 Don't use wfDiff() in Echo |
Hmm this probably points to the underlying code being slow, not just the tests themselves. I suspect this is because it uses wfDiff() a lot.
rECHOa1cb603bb34a: Use internal diff engine landed 2 weeks ago. T93625: Don't use wfDiff() in Echo is closed.
However, it seems EchoDiscussionParserTest run time has not changed (~39-53 seconds).
Change 333673 had a related patch set uploaded (by WMDE-Fisch):
DiscussionParserTest only create users when needed
A while ago @Addshore slightly improved the test setup there to speed them up. Just needs reviews.
Change 333673 merged by jenkins-bot:
DiscussionParserTest only create users when needed
@WMDE-Fisch @Addshore Very nice :)
I'll mark this as resolved! If you want to explore additional optimisations to the user creation, I'd recommend exploring the getTestUser() and getMutableTestUser() methods on MediaWikiTestCase.
