⚓ T93625 Don't use wfDiff() in Echo

	Subject	Repo	Branch	Lines +/-
	Remove test for internal diff engine acceptance	mediawiki/extensions/Echo	master	+0 -30
	Use internal diff engine	mediawiki/extensions/Echo	master	+9 -10

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T158120 EchoDiscussionParserTest is slow
		Resolved		WMDE-Fisch	T93625 Don't use wfDiff() in Echo

MaxSem created this task.Mar 23 2015, 6:32 PM

MaxSem raised the priority of this task from to Needs Triage.

MaxSem updated the task description. (Show Details)

MaxSem subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 6:32 PM

EBernhardson triaged this task as Low priority.Mar 24 2015, 5:44 PM

Umherirrender mentioned this in T97145: internal_api_error_Exception: [22e05a83] Exception Caught: wfDiff(): popen() failed errors on English Wikipedia.Apr 24 2015, 5:00 PM

ori claimed this task.May 20 2015, 8:08 PM

ori added projects: Performance-Team, Performance Issue.

ori set Security to None.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 20 2015, 8:08 PM

Look into using HHVM's LightProcess https://github.com/facebook/hhvm/blob/master/hphp/util/light-process.h

I'd rather say don't call external processes at all :)

Done in Ia5239c1e7.

Quiddity moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.May 27 2015, 9:14 AM

Krinkle moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Jun 23 2015, 5:26 AM

In T93625#1311400, @ori wrote:

Done in Ia5239c1e7.

I think that's supposed to be rOMWC4f333a850fe9: Unset $wgDiff, so we stop shelling out to diff, but that still doesn't fix this bug, which is to not use wfDiff().

A volunteer wants to wfDeprecate() it, thus Echo's unit tests migh break if diffing is tested at all.

ori moved this task from Doing (old) to Backlog: Maintenance, non-prioritized on the Performance-Team board.Oct 19 2015, 6:16 PM

WMDE-leszek subscribed.Jun 1 2016, 7:36 AM

Krinkle moved this task from Backlog: Maintenance, non-prioritized to Radar on the Performance-Team board.Sep 29 2016, 8:19 PM

Change 335791 had a related patch set uploaded (by Legoktm):
Use internal diff engine

https://gerrit.wikimedia.org/r/335791

gerritbot added a project: Patch-For-Review.Feb 3 2017, 7:07 PM

Change 335791 merged by jenkins-bot:
Use internal diff engine

https://gerrit.wikimedia.org/r/335791

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 10 2017, 12:00 PM

matej_suchanek added a parent task: T158120: EchoDiscussionParserTest is slow.Feb 22 2017, 8:55 PM

After Echo, there is one usage left in Wikimedia Git (not counting unit tests and maintenance scripts).

wikimedia/mediawiki-extensions-AbuseFilter – AFComputedVariable.php

157					$text2 = $vars->getVar( $text2Var )->toString() . "\n";
158					$result = wfDiff( $text1, $text2 );

In T93625#3048109, @Krinkle wrote:

After Echo, there is one usage left in Wikimedia Git (not counting unit tests and maintenance scripts). wikimedia/mediawiki-extensions-AbuseFilter

I created T158850: Don't use wfDiff() in AbuseFilter for AbuseFilter.

So this task T93625 could get closed as resolved?

Huji added a subtask: T158850: Don't use wfDiff() in AbuseFilter.Feb 23 2017, 11:05 PM

Krinkle closed this task as Resolved.Feb 24 2017, 4:51 AM

Krinkle mentioned this in T158120: EchoDiscussionParserTest is slow.Feb 24 2017, 4:56 AM

Legoktm renamed this task from Don't use wfDiff() to Don't use wfDiff() in Echo.Feb 24 2017, 11:15 AM

Legoktm removed a subtask: T158850: Don't use wfDiff() in AbuseFilter.

Legoktm mentioned this in T158850: Don't use wfDiff() in AbuseFilter.

Change 339622 had a related patch set uploaded (by WMDE-Fisch):
Remove test for internal diff engine acceptance

https://gerrit.wikimedia.org/r/339622

Change 339622 merged by jenkins-bot:
Remove test for internal diff engine acceptance

https://gerrit.wikimedia.org/r/339622