Page MenuHomePhabricator

Add disabling comment syntax to resource-modules linter
Closed, ResolvedPublic

Description

See T146748: Lint JS sources dependency graph against ResourceModules configuration for context.

Feature request: resource-modules/issues/2

In order to avoid error reporting in the CI linting in special situations

We need to be able to disable parsing of parts of the code using special comment syntax (in the same vein of // eslint-disable)

The remaining work involves setting up the Jenkins job to run on every commit. We may need help from Release Engineering to do this.

AC

Event Timeline

Jdlrobson renamed this task from Add disabling comment syntax to resource-modules linter to Add disabling comment syntax to resource-modules linter and setup Jenkins job.Apr 17 2017, 4:15 PM

I'm thinking of proposing this and various cards relating to tooling for sprint 97

Jhernandez renamed this task from Add disabling comment syntax to resource-modules linter and setup Jenkins job to Add disabling comment syntax to resource-modules linter.Apr 26 2017, 10:20 AM
Jhernandez closed this task as Resolved.
Jhernandez updated the task description. (Show Details)

This one was resolved as part of the parent T146748, sorry I didn't see it before.

The part that wasn't done is setup jenkins job which I guess meant promote job to stable in MobileFrontend. That would be the next checkbox in the parent: Migrate experimental CI job to stable on MobileFrontend.

@Jdlrobson I've created T163882: Migrate experimental CI job mwext-MobileFrontend-npm-run-lint-modules to stable for that, will add as subtask of your epic and put it in sprint +1.