⚓ T160190 [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height)

Subject	Repo	Branch	Lines +/-
Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (f6e399eed)	mediawiki/extensions/VisualEditor	wmf/1.29.0-wmf.16	+1 -1
ve.ui.DesktopContext: Prevent hiding of the context popup	VisualEditor/VisualEditor	wmf/1.29.0-wmf.16	+4 -1
ve.ui.DesktopContext: Prevent hiding of the context popup	VisualEditor/VisualEditor	master	+4 -1
Update VE core submodule to master (ac6d7031c)	mediawiki/extensions/VisualEditor	master	+1 -1

Ryasmeen created this task.Mar 10 2017, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2017, 6:56 PM

Actually, it's happening for all context menus.

Screen Shot 2017-03-10 at 11.09.22 AM.png (738×1 px, 364 KB)

Ryasmeen renamed this task from [Regression pre wmf.16] Link Inspector is appearing broken on the first attempt every session to [Regression pre wmf.16] All Inspectors and context menus are appearing broken on the first attempt every session. .Mar 10 2017, 7:12 PM

Ryasmeen renamed this task from [Regression pre wmf.16] All Inspectors and context menus are appearing broken on the first attempt every session. to [Regression pre-wmf.16] All Inspectors and context menus are appearing broken on the first attempt every session. .Mar 10 2017, 7:22 PM

Jdforrester-WMF renamed this task from [Regression pre-wmf.16] All Inspectors and context menus are appearing broken on the first attempt every session. to [Regression pre-wmf.16] Context menus for items below the screen appear broken (no vertical height).Mar 10 2017, 8:40 PM

Jdforrester-WMF triaged this task as Unbreak Now! priority.

Jdforrester-WMF added projects: OOUI, VisualEditor-EditingTools.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF added a subscriber: Catrope.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptMar 10 2017, 8:40 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Mar 10 2017, 8:40 PM

Ryasmeen renamed this task from [Regression pre-wmf.16] Context menus for items below the screen appear broken (no vertical height) to [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height).Mar 14 2017, 11:02 PM

Jdforrester-WMF assigned this task to Catrope.Mar 16 2017, 2:05 AM

Jdforrester-WMF mentioned this in T160197: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" .Mar 16 2017, 5:58 PM

To reproduce (other than on first try):

Make a context menu appear.
Scroll it offscreen.
Make another context menu appear.

The second context menu will always have zero height.

Change 343221 had a related patch set uploaded (by Bartosz Dziewoński):
[VisualEditor/VisualEditor] ve.ui.DesktopContext: Prevent hiding of the context popup

https://gerrit.wikimedia.org/r/343221

gerritbot added a project: Patch-For-Review.Mar 17 2017, 12:21 AM

Change 343221 merged by jenkins-bot:
[VisualEditor/VisualEditor] ve.ui.DesktopContext: Prevent hiding of the context popup

https://gerrit.wikimedia.org/r/343221

Change 343224 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (ac6d7031c)

https://gerrit.wikimedia.org/r/343224

Change 343224 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (ac6d7031c)

https://gerrit.wikimedia.org/r/343224

Ryasmeen added a project: Verified.Mar 17 2017, 1:23 AM

Change 343229 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor] ve.ui.DesktopContext: Prevent hiding of the context popup

https://gerrit.wikimedia.org/r/343229

Change 343229 merged by jenkins-bot:
[VisualEditor/VisualEditor] ve.ui.DesktopContext: Prevent hiding of the context popup

https://gerrit.wikimedia.org/r/343229

Change 343411 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (rGVEDf6e399eed0a2)

https://gerrit.wikimedia.org/r/343411

Change 343411 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to wmf/1.29.0-wmf.16 HEAD (rGVEDf6e399eed0a2)

https://gerrit.wikimedia.org/r/343411

Mentioned in SAL (#wikimedia-operations) [2017-03-17T23:36:35Z] <catrope@tin> Synchronized php-1.29.0-wmf.16/extensions/VisualEditor/lib/ve: Fixes for T154123 T160479 T160190 T160197 (duration: 00m 42s)

Now pushed to production; sorry to all affected.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 17 2017, 11:37 PM

Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Mar 18 2017, 12:42 AM

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 28 2017, 11:41 PM

Volker_E moved this task from Backlog to Waiting for breaking release on the OOUI board.May 3 2017, 9:05 PM

Volker_E moved this task from Waiting for breaking release to Resolved outside releases on the OOUI board.Mar 22 2018, 5:40 AM

[Regression wmf.16] Context menus for items below the screen appear broken (no vertical height)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Details

Related Objects

Event Timeline

	F6413954: Screen Shot 2017-03-10 at 11.09.22 AM.png
	Mar 10 2017, 7:10 PM

	F6413304: Screen Shot 2017-03-10 at 10.52.33 AM.png
	Mar 10 2017, 6:56 PM

[Regression wmf.16] Context menus for items below the screen appear broken (no vertical height)Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[Regression wmf.16] Context menus for items below the screen appear broken (no vertical height)
Closed, ResolvedPublic1 Estimated Story Points
Actions