Page MenuHomePhabricator

Remove zend tests from wmf branches
Closed, DuplicatePublic

Description

For the master branch, we obviously still need Zend tests enabled; however, for the wmf branches of MediaWiki and extensions the Zend tests may be a superfluous burden.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2017, 5:35 PM

I kept them around because mwscript is still bound to Zend PHP5 ( T146285 ) which was in reaction to T132751: "Elastica: missing curl_init_pooled method" due to mwscript job running with PHP 5 on terbium.

So triggering the PHP5 jobs might cover the corner case of code being run as maintenance script and we have a lot of it: job runners, getting all wikis configuration etc.

But maybe I am over paranoid and we could just drop them. Though I would still love to see T146285 to be finally fixed.

So triggering the PHP5 jobs might cover the corner case of code being run as maintenance script and we have a lot of it: job runners, getting all wikis configuration etc.

Emphasis is on might. Job runners don't run via runJobs anymore, it's a loop to the RPC endpoint now. I think the benefit is very minor. Let's just drop them