Page MenuHomePhabricator
Create Task
Maniphest T94149

Get rid of Zend 5.5 tests for wmf branches
Closed, ResolvedPublic
Actions

Description

Once there are no more Zend PHP machines running in Wikimedia production there is no need to trigger the Zend-based tests for wmf branches.

With the recent introduction of MySQL the PHPUnit ones went from 6 to more than 10 minutes which is slowing down merges for no reason (T93556).

Details

SubjectRepoBranchLines +/-
Skip php 5.5 for mediawiki wmf branchesintegration/configmaster+5 -0
Drop transient Zuul rulesintegration/configmaster+0 -20
wmf branches: drop mediawiki-core-phpcs-trustyintegration/configmaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReedyT94149 Get rid of Zend 5.5 tests for wmf branches
 ResolvedNoneT86081 Complete the use of HHVM over Zend PHP on the Wikimedia cluster
 ResolvedJoeT86096 Switch HAT appservers to trusty's ICU (or newer)
 ResolvedJoeT78765 Convert jobrunners to HHVM
 ResolvedJoeT84842 Convert eqiad imagescalers to HHVM, Trusty
 ResolvedtstarlingT91468 HHVM with FastCGI does not support streaming output
 ResolvedJoeT93194 Create an HHVM 3.6.0 package, adding Tim's streaming patch
 ResolvedkaldariT58041 updateCollation.php script prohibitively slow for very large wikis
 ResolvedjcrespoT130692 Add new indexes from eec016ece6d2b30addcdf3d3efcc2ba59b10e858 to production databases
 ResolvedVolansT128353 Switchover to new s3 master
 ResolvedPRODUCTION ERRORaaronT126436 Spikes of mediawiki in read only for job runners after altering the s2 slaves topology
 InvalidNoneT126632 Scap should restart job runners to pick up new config
 DeclinedArielGlennT94277 Convert snapshot hosts to use HHVM and trusty
 ResolvedArielGlennT111586 Snapshot hosts need to be manually added to dataset1001's exports
 ResolvedoriT113932 HHVM does not recognize compress.bzip2 streams
 DeclinedNoneT117534 DCAT-AP: XML produces invalid output with HHVM
 ResolvedMoritzMuehlenhoffT143648 Merge facebook/hhvm@9d2be6c30b into build of next hhvm release
 ResolvedJoeT87036 Convert work machines (tin, terbium) to Trusty and hhvm usage
 ResolvedJoeT116728 Reimage mw1152 as a terbium replacement
 ResolvedJoeT124024 Be able to switch programmatically between deployment servers in codfw and eqiad
 ResolvedAndrewT98813 Move wikitech (silver) to HHVM
 ResolvedJoeT104747 Convert tmh100[12] to HHVM and trusty
 DuplicatefgiunchediT107313 Backport ffmpeg 2.7.3 to Trusty
 Resolved• brookeT69953 ogv transcodes have broken audio tracks with ffmpeg2theora 0.29 (Trusty upstream)
 Resolved• brookeT103335 Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie)
 Resolvedbd808T110707 Upgrade Beta Cluster tmh* host(s) to HHVM and Trusty
 ResolvedJoeT113284 Frequent job timeouts on HHVM video scalers
 ResolvedfgiunchediT146285 Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7)
 ResolvedPRODUCTION ERROREBernhardsonT132751 "Elastica: missing curl_init_pooled method" due to mwscript job running with PHP 5 on terbium
 ResolvedKrenairT125540 New version of File:Duniya Na Mane, 1937.webm
 ResolvedNoneT25748 Bad label on upload max filesize at upload page in spanish version
 ResolvedhasharT146286 mwscript on jessie mediawiki fails
 ResolvedtstarlingT145819 Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes
 ResolvedtstarlingT111441 SiteConfiguration::getConfig() does not work in Wikimedia production
 ResolvedLegoktmT190547 Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM
 ResolvedLegoktmT190548 Update mediawiki-core-qunit-selenium-jessie/mediawiki-extensions-qunit-jessie jobs from PHP5 to PHP7/HHVM
 ResolvedLegoktmT147778 Switch MediaWiki coverage job from PHP 5 to PHP 7
 ResolvedNoneT147781 MediaWiki code coverage fails on Zend PHP 7.0 due to a database error
 ResolvedPRODUCTION ERRORAnomieT191863 SearchEngineTest fails during PHPUnit coverage job "no such table: unittest_page"

Event Timeline

hashar created this task.Mar 27 2015, 10:56 AM
hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar added a project: Continuous-Integration-Infrastructure.
hashar subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2015, 10:56 AM
Krinkle updated the task description. (Show Details)Mar 27 2015, 12:34 PM
Krinkle set Security to None.
Krinkle triaged this task as Medium priority.Mar 29 2015, 7:57 AM
Legoktm subscribed.Mar 29 2015, 8:02 AM

Um, Wikimedia most certainly still uses Zend PHP, see T84842 for example.

Krinkle moved this task from Untriaged to Backlog on the Continuous-Integration-Infrastructure board.Apr 7 2015, 2:33 PM
Legoktm added a subtask: T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster.Apr 11 2015, 11:54 PM
Krenair subscribed.Apr 13 2015, 5:31 PM
Ricordisamoa subscribed.Apr 20 2015, 5:16 PM
jeremyb subscribed.Jun 30 2015, 5:44 AM
Krenair mentioned this in T98813: Move wikitech (silver) to HHVM.Jun 30 2015, 1:42 PM
hashar changed the task status from Open to Stalled.Oct 6 2015, 11:47 AM
hashar moved this task from Backlog to Externally Blocked on the Continuous-Integration-Infrastructure board.
Anomie subscribed.Nov 24 2015, 3:22 PM

In T118932: RfC: Raise MediaWiki's PHP version requirement to 5.5 and update coding standards it looks like we're considering bumping the MediaWiki PHP version requirement to PHP 5.5, while HHVM currently seems to be aiming at 5.6. In the past it has been useful that unit tests are also run with something like our minimum target version of PHP to help avoid breaking compatibility.

Legoktm added a comment.Nov 24 2015, 4:49 PM

Yep, this task is just about tests on the wmf deployment branches.

greg updated the task description. (Show Details)Nov 24 2015, 4:52 PM
greg awarded a token.
Anomie added a comment.Nov 24 2015, 5:22 PM

Oh, I misread it.

Anomie unsubscribed.Nov 24 2015, 5:22 PM
hashar added a comment.Nov 25 2015, 3:43 PM

Yup this specific task is about removing the Zend based Jenkins jobs whenever the Wikimedia infrastructure has been fully migrated to HHVM. At this point we will no more care about Zend and that will speed up gate-and-submit for wmf branches.

I should show up at the RFC meeting tonight for T118932 .

hashar mentioned this in T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster.Feb 8 2016, 11:24 PM
hashar moved this task from Externally Blocked to Next on the Continuous-Integration-Infrastructure board.Feb 19 2016, 9:13 PM
hashar added a subscriber: ori.

@ori confirmed on T86081 that Zend 5.3 is gone:

In T86081#2012595, @ori wrote:
In T86081#2010135, @hashar wrote:

This task is a blocker for getting rid of Zend 5.3 Jenkins jobs for WMF branches and master branches deployed on Wikimedia infra ( T94149 ).

There is still three blockers, but they don't seem to have Zend 5.3 running still:

T98813: Move wikitech (silver) to HHVM
T94277: Convert snapshot hosts to use HHVM and trusty
T86096: Switch HAT appservers to trusty's ICU (or newer)

Can subscribers to this task please confirm the three task above are no more for migrating out of Zend 5.3? If nothing left running Zend 5.3 we will get rid of the related Jenkins jobs.

Yes, confirmed. Wikitech and the snapshot hosts are running 5.5.9, and T86096 is blocked by the migration, not blocking it.

So we can filter out Zend based jobs for wmf branches.

hashar removed a subtask: T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster.Feb 19 2016, 9:15 PM
JanZerebecki added a parent task: T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster.Feb 20 2016, 3:47 PM
Krinkle removed a parent task: T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster.Feb 20 2016, 10:43 PM
Krinkle added a subtask: T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster.
Krinkle subscribed.

Test must remain until HHVM roll out is complete, not the other way around.

Krinkle unsubscribed.Feb 23 2016, 4:55 PM
hashar changed the task status from Stalled to Open.Mar 17 2017, 11:29 PM
hashar merged a task: T160669: Remove zend tests from wmf branches.
hashar edited projects, added Continuous-Integration-Infrastructure (Little Steps Sprint); removed Continuous-Integration-Infrastructure.
hashar added subscribers: thcipriani, Paladox, • demon, greg.
In T160669#3111374, @demon wrote:
In T160669#3110067, @hashar wrote:

So triggering the PHP5 jobs might cover the corner case of code being run as maintenance script and we have a lot of it: job runners, getting all wikis configuration etc.

Emphasis is on might. Job runners don't run via runJobs anymore, it's a loop to the RPC endpoint now. I think the benefit is very minor. Let's just drop them

So we are going to remove Zend for wmf branches in the interest of lowering load on CI and speed up feedback/merge for wmf branch.

hashar added a comment.Mar 20 2017, 4:35 PM

Talked about it again during the release engineering meeting. We believe that although maintenance script are still using Zend php5.5, running tests on every single patch is unlikely to catch any issue and thus have little purpose beside slowing down merges.

gerritbot subscribed.Mar 24 2017, 4:05 PM

Change 344642 had a related patch set uploaded (by Hashar):
[integration/config@master] wmf branches: drop mediawiki-extensions-php55-trusty

https://gerrit.wikimedia.org/r/344642

gerritbot added a project: Patch-For-Review.Mar 24 2017, 4:05 PM

Change 344643 had a related patch set uploaded (by Hashar):
[integration/config@master] wmf branches: drop mediawiki-core-phpcs-trusty

https://gerrit.wikimedia.org/r/344643

gerritbot added a comment.Mar 24 2017, 4:24 PM

Change 344645 had a related patch set uploaded (by Hashar):
[integration/config@master] Drop transient Zuul rules

https://gerrit.wikimedia.org/r/344645

gerritbot added a comment.Mar 24 2017, 4:26 PM

Change 344643 abandoned by Hashar:
wmf branches: drop mediawiki-core-phpcs-trusty

Reason:
Can be done with a generic rule .*php55.* .

https://gerrit.wikimedia.org/r/344643

hashar added a comment.Mar 27 2017, 8:48 AM

Wikitech on silver still runs Zend php 5.5 :(

gerritbot added a comment.Mar 27 2017, 9:02 AM

Change 344645 merged by jenkins-bot:
[integration/config@master] Drop transient Zuul rules

https://gerrit.wikimedia.org/r/344645

greg added a comment.Mar 27 2017, 5:33 PM
In T94149#3133077, @hashar wrote:

Wikitech on silver still runs Zend php 5.5 :(

I forget, why is that?

greg added a comment.Mar 27 2017, 7:00 PM
In T94149#3134755, @greg wrote:
In T94149#3133077, @hashar wrote:

Wikitech on silver still runs Zend php 5.5 :(

I forget, why is that?

OSM :(

gerritbot added a comment.Jun 6 2017, 2:24 PM

Change 344642 abandoned by Hashar:
Skip php 5.5 for mediawiki wmf branches

Reason:
We can't get rid of php 5.5 jobs yet :(

https://gerrit.wikimedia.org/r/344642

hashar changed the task status from Open to Stalled.Jun 6 2017, 2:26 PM
hashar edited projects, added Continuous-Integration-Config, Release-Engineering-Team; removed Patch-For-Review.

Stalled, pending completion of Zend -> HHVM migration.

greg edited projects, added Release-Engineering-Team (Backlog); removed Release-Engineering-Team.Jun 13 2017, 11:51 PM
EddieGP subscribed.Oct 1 2017, 8:27 PM

Should this be declined due to T176370?

Paladox added a comment.Oct 1 2017, 8:48 PM

Yeh, one should be filled for getting rid of the hhvm tests.

• demon closed this task as Declined.Oct 2 2017, 10:45 PM
hashar reopened this task as Open.Oct 4 2017, 1:05 PM

That is to remove the Zend 5.5 based jobs. That is pending on https://gerrit.wikimedia.org/r/358896 Stop forcing php5 in mwscript

hashar renamed this task from Get rid of zend tests for wmf branches to Get rid of Zend 5.5 tests for wmf branches.Oct 4 2017, 1:05 PM
Legoktm added a comment.Oct 4 2017, 4:47 PM

It's blocked on more than that - we still use PHP 5.5 for dumps and wikitech (silver).

MaxSem closed subtask T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster as Declined.Oct 14 2017, 12:35 AM
Jdforrester-WMF added a subtask: T178538: Bump PHP requirement to 5.6 in 1.31.Oct 18 2017, 10:22 PM
tstarling closed subtask T178538: Bump PHP requirement to 5.6 in 1.31 as Declined.Nov 22 2017, 11:00 PM
Krinkle removed a subtask: T178538: Bump PHP requirement to 5.6 in 1.31.Jan 10 2018, 10:59 PM
Krinkle mentioned this in T184638: Identify uses of Zend PHP5 in Wikimedia production.Jan 10 2018, 11:02 PM
gerritbot added a comment.Mar 14 2018, 5:08 PM

Change 344642 restored by Hashar:
Skip php 5.5 for mediawiki wmf branches

https://gerrit.wikimedia.org/r/344642

Jdforrester-WMF changed the status of subtask T86081: Complete the use of HHVM over Zend PHP on the Wikimedia cluster from Declined to Resolved.Mar 21 2018, 12:10 AM
Krinkle added a parent task: T172165: Require either PHP 7.0+ or HHVM in MW 1.31.Apr 9 2018, 4:06 PM
Krinkle added a parent task: T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM.Apr 9 2018, 4:11 PM
Krinkle removed a parent task: T172165: Require either PHP 7.0+ or HHVM in MW 1.31.
Krinkle changed the task status from Open to Stalled.Apr 10 2018, 1:50 PM

This should be the last thing to happen in the chain of this tasks' parent (T190547), and should not happen until after Wikimedia no longer runs PHP5 with MediaWiki anywhere in production.

dcausse subscribed.Apr 13 2018, 8:50 AM
Jdforrester-WMF removed a parent task: T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM.Apr 13 2018, 4:31 PM
Jdforrester-WMF added a subtask: T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM.
Legoktm closed subtask T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM as Resolved.Apr 18 2018, 5:38 PM
Jdforrester-WMF changed the task status from Stalled to Open.May 30 2018, 3:39 PM
Jdforrester-WMF subscribed.

No longer stalled.

Jdforrester-WMF closed this task as Resolved.May 30 2018, 4:28 PM
Jdforrester-WMF assigned this task to Reedy.

Indeed, done last week in https://gerrit.wikimedia.org/r/#/c/434922/

gerritbot added a comment.Aug 27 2018, 2:23 PM

Change 344642 abandoned by Hashar:
Skip php 5.5 for mediawiki wmf branches

Reason:
Obsolete.

https://gerrit.wikimedia.org/r/344642

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits