Page MenuHomePhabricator

Visual diff doesn't show changes to categories or redirects
Closed, ResolvedPublic8 Estimated Story Points

Description

Steps to reproduce:

  1. Open a page for editing in VE.
  2. Add a category.
  3. Review your changes as visual diff.

Expected: The addition of the category is shown in the diff.
Actual: The diff claims there are no changes.

Reported by multiple editors, including User:Sario528 at https://www.mediawiki.org/wiki/Topic:Uyjly6vii1zsep7w

Example: https://www.mediawiki.org/w/index.php?title=User:ESanders_(WMF)/sandbox&type=revision&diff=4296712&oldid=4296711&diffmode=visual

Event Timeline

Jdforrester-WMF set the point value for this task to 8.

Probably a simple message like "There are (also) changes to metadata not visible in the main content, please see the wikitext diff for them" would suffice.

Change 755429 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Give categories a rendering in preview mode

https://gerrit.wikimedia.org/r/755429

Whatamidoing-WMF renamed this task from Visual diff doesn't show changes to categories to Visual diff doesn't show changes to categories or redirects.Apr 11 2022, 6:55 PM
nammonsanta set Due Date to Apr 30 2022, 5:00 PM.May 1 2022, 2:32 PM

Change 767905 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Show redirect meta items in visual diff

https://gerrit.wikimedia.org/r/767905

Change 755429 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Render category diff

https://gerrit.wikimedia.org/r/755429

Change 767905 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Show redirect meta items in visual diff

https://gerrit.wikimedia.org/r/767905

EAkinloose subscribed.

✅ Visual diff show changes to metadata

Changes to Categories

Screenshot 2023-04-05 at 20.00.56.png (1×1 px, 161 KB)

Screenshot 2023-04-05 at 20.04.12.png (834×2 px, 179 KB)

Redirects
{F36940491}

{F36940493}

EAkinloose claimed this task.