Page MenuHomePhabricator
Create Task
Maniphest T161631

[Task] Remove "all" option for Special:EntitiesWithout*"
Closed, ResolvedPublic
Actions

Description

We have removed the option to select items in Special:EntitiesWithoutDescriptions and Special:EntitiesWithoutLabels in T147638. This was done for performance reasons. The "all" option is still problematic. We should remove it as it does not make sense to have it if the SpecialPage should only be used for listing properties.

Removing (or at least, re-defining) the "all" option is needed to resolve T160887: Wikibase\Repo\Store\Sql\SqlEntitiesWithoutTermFinder::getEntitiesWithoutTerm can take 19 hours to execute and it is run by the web requests user.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Major clean-up to SpecialEntitiesWithoutPagemediawiki/extensions/Wikibasemaster+53 -49
Require an entity type to be specified when searching for entitites without label or description.mediawiki/extensions/Wikibasewmf/1.29.0-wmf.17+33 -17
Require an entity type to be specified when searching for entitites without label or description.mediawiki/extensions/Wikibasemaster+33 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Mar 28 2017, 4:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2017, 4:55 PM
gerritbot subscribed.Mar 28 2017, 5:25 PM

Change 345186 had a related patch set uploaded (by Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Require an entity type to be specified when searching for entitites without label or description.

https://gerrit.wikimedia.org/r/345186

gerritbot added a project: Patch-For-Review.Mar 28 2017, 5:25 PM
daniel updated the task description. (Show Details)Mar 28 2017, 5:33 PM
aude subscribed.Mar 29 2017, 4:46 AM

error I get with https://gerrit.wikimedia.org/r/#/c/345186/ when going to https://wikidatawiki/wiki/Special:EntitiesWithoutDescription (before selecting anything in the form and without any request params)

Screenshot from 2017-03-29 00:44:31.png (452×868 px, 22 KB)

Marostegui moved this task from Triage to Blocked external/Not db team on the DBA board.Mar 29 2017, 6:30 AM
thiemowmde moved this task from incoming to in progress on the Wikidata board.Mar 29 2017, 9:36 AM
thiemowmde added a project: MediaWiki-extensions-WikibaseRepository.
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde added subscribers: thiemowmde, hoo.
thiemowmde assigned this task to daniel.Mar 29 2017, 9:41 AM
thiemowmde moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Mar 30 2017, 11:29 AM

Change 345532 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Major clean-up to SpecialEntitiesWithoutPage

https://gerrit.wikimedia.org/r/345532

gerritbot added a comment.Mar 30 2017, 11:02 PM

Change 345186 merged by Aude:
[mediawiki/extensions/Wikibase@master] Require an entity type to be specified when searching for entitites without label or description.

https://gerrit.wikimedia.org/r/345186

gerritbot added a comment.Mar 30 2017, 11:12 PM

Change 345782 had a related patch set uploaded (by Aude; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@wmf/1.29.0-wmf.17] Require an entity type to be specified when searching for entitites without label or description.

https://gerrit.wikimedia.org/r/345782

gerritbot added a comment.Mar 30 2017, 11:31 PM

Change 345782 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.29.0-wmf.17] Require an entity type to be specified when searching for entitites without label or description.

https://gerrit.wikimedia.org/r/345782

thiemowmde lowered the priority of this task from High to Low.Mar 31 2017, 9:01 AM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
matej_suchanek added a parent task: T96040: Wikibase special pages (tracking).Mar 31 2017, 2:26 PM
daniel mentioned this in T160887: Wikibase\Repo\Store\Sql\SqlEntitiesWithoutTermFinder::getEntitiesWithoutTerm can take 19 hours to execute and it is run by the web requests user.Apr 4 2017, 12:36 PM
gerritbot added a comment.Apr 7 2017, 5:35 PM

Change 345532 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Major clean-up to SpecialEntitiesWithoutPage

https://gerrit.wikimedia.org/r/345532

• Aleksey_WMDE updated the task description. (Show Details)Apr 8 2017, 9:50 AM
• Aleksey_WMDE subscribed.

Done?

WMDE-leszek subscribed.Apr 11 2017, 2:47 PM

Done?

ping @Lydia_Pintscher @daniel

Lydia_Pintscher closed this task as Resolved.Apr 11 2017, 2:50 PM
Lydia_Pintscher moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Apr 17 2017, 5:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL