Page MenuHomePhabricator

Catchable fatal error: Argument 1 passed to Title::equals() must be an instance of Title, null given
Closed, ResolvedPublic

Description

Catchable fatal error: Argument 1 passed to Title::equals() must be an instance of Title, null given in /srv/mediawiki/php-1.29.0-wmf.18/includes/Title.php on line 4282

Error started when I pushed 1.29.0-wmf.18 to group1 today

Logstash Link: https://logstash.wikimedia.org/goto/3c9617dc70c814c02568962c944a62bc

#0 /srv/mediawiki/php-1.29.0-wmf.18/includes/Title.php(4282): MWExceptionHandler::handleError(integer, string, string, integer, array, array) 
#1 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(121): Title->equals(NULL)
#2 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(102): ProofreadPagePage->findIndexTitle()
#3 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(173): ProofreadPagePage->getIndex()
#4 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(257): ProofreadPagePage->getImageWidth()
#5 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/PageViewAction.php(43): ProofreadPagePage->getPageContainerEnd()
#6 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(497): ProofreadPage\Page\PageViewAction->show()
#7 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(291): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(860): MediaWiki->performRequest() 
#9 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(521): MediaWiki->main()
#10 /srv/mediawiki/php-1.29.0-wmf.18/index.php(43): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2017, 7:23 PM
thcipriani triaged this task as Unbreak Now! priority.Mar 29 2017, 7:24 PM

Added as a blocker for 1.29.0-wmf.18, set UBN!

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptMar 29 2017, 7:26 PM
thcipriani updated the task description. (Show Details)Mar 29 2017, 10:43 PM

So, 4282 is just the end of the definition of the exists() function in patched wmf.18, FWIW. No stack trace. Someone is passing in null rather than a new Title() in some circumstance, but…

thcipriani updated the task description. (Show Details)Mar 29 2017, 11:13 PM
thcipriani closed this task as Resolved.Mar 29 2017, 11:17 PM
thcipriani assigned this task to Tpt.
thcipriani updated the task description. (Show Details)

Seems like this is another piece of T161734: fatal error: Argument 1 passed to ProofreadIndexPage::newFromTitle() must be an instance of Title, ProofreadIndexPage given and seems like it may be solved by the patch that was merged there now that I'm looking at it.

@thcipriani Thanks. We've got stacktraces since T45086.

Looks like all the warnings from wikisource.org wikis.

A sample:

#0 /srv/mediawiki/php-1.29.0-wmf.18/includes/Title.php(4282)
#1 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(121): Title->equals(NULL)
#2 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(102): ProofreadPagePage->findIndexTitle()
#3 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(173): ProofreadPagePage->getIndex()
#4 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/ProofreadPagePage.php(257): ProofreadPagePage->getImageWidth()
#5 /srv/mediawiki/php-1.29.0-wmf.18/extensions/ProofreadPage/includes/page/PageViewAction.php(43): ProofreadPagePage->getPageContainerEnd()
#6 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(497): ProofreadPage\Page\PageViewAction->show()
#7 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(291): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(860): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.29.0-wmf.18/includes/MediaWiki.php(521): MediaWiki->main()
#10 /srv/mediawiki/php-1.29.0-wmf.18/index.php(43): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM